Ant-design: [Feature Request] Improve Typography copyable

Created on 24 Jun 2020  ·  3Comments  ·  Source: ant-design/ant-design

Now we support a copy button with original text: https://codesandbox.io/s/interesting-river-vtoqf?file=/index.js

<Paragraph copyable={{ text: 'Hello, Ant Design!' }} />

There is three problems to resolve:

  1. Cannot customize copy icon.
  2. The copy icon has extra margin-left.
  3. There is no good way to change default Copy and Copied in Tooltip.

image

The new API we are looking for should be:

<Paragraph
  copyable={{
    text: 'Hello, Ant Design!',
    onCopy: () => {},
+   icon: <Icon />,
+   tooltips: ['Copy', 'Copied'],
  }} 
/>
help wanted 💡 Feature Request

Most helpful comment

It is a common need to customize tooltip for each copy button.

All 3 comments

Hello @afc163. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @afc163, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献!

giphy

tooltips is no need. It's controlled by ConfigProvider locale. icon support customize is good enough.

It is a common need to customize tooltip for each copy button.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

yangbin1994 picture yangbin1994  ·  3Comments

xtznhzxdev picture xtznhzxdev  ·  3Comments

drcmda picture drcmda  ·  3Comments

taikongfeizhu picture taikongfeizhu  ·  3Comments

longhuasishen picture longhuasishen  ·  3Comments