Yarn: Inconsistencia en el método de parámetro de igual (Objeto)

Creado en 9 abr. 2021 · 4Comentarios · Fuente: FabricMC/yarn

Actualmente, hay equals(Object object) , equals(Object obj) , equals(Object o) y equals(Object other) en las asignaciones de hilos. Sería bueno resolver la inconsistencia.

Lista de asignaciones de iguales (Objeto) (buscadas por expresiones regulares equals (Ljava/lang/Object;)Z\n.*ARG 1 )

82 results - 80 files

mappings\net\minecraft\advancement\Advancement.mapping:
  17:   METHOD equals (Ljava/lang/Object;)Z
  18:       ARG 1 o

mappings\net\minecraft\advancement\criterion\Criterion.mapping:
  22:       METHOD equals (Ljava/lang/Object;)Z
  23:           ARG 1 o

mappings\net\minecraft\block\Block.mapping:
  262:      METHOD equals (Ljava/lang/Object;)Z
  263:          ARG 1 o

mappings\net\minecraft\client\gl\GlBlendState.mapping:
  28:   METHOD equals (Ljava/lang/Object;)Z
  29:       ARG 1 o

mappings\net\minecraft\client\realms\dto\RealmsServer.mapping:
  21:   METHOD equals (Ljava/lang/Object;)Z
  22:       ARG 1 obj

mappings\net\minecraft\client\realms\util\TextRenderingUtils.mapping:
  20:       METHOD equals (Ljava/lang/Object;)Z
  21:           ARG 1 o
  32:       METHOD equals (Ljava/lang/Object;)Z
  33:           ARG 1 o

mappings\net\minecraft\client\render\VertexFormat.mapping:
  5:    METHOD equals (Ljava/lang/Object;)Z
  6:        ARG 1 o

mappings\net\minecraft\client\render\VertexFormatElement.mapping:
  12:   METHOD equals (Ljava/lang/Object;)Z
  13:       ARG 1 o

mappings\net\minecraft\client\render\entity\model\EntityModelLayer.mapping:
  7:    METHOD equals (Ljava/lang/Object;)Z
  8:        ARG 1 other

mappings\net\minecraft\client\render\model\ModelLoader.mapping:
  74:       METHOD equals (Ljava/lang/Object;)Z
  75:           ARG 1 o

mappings\net\minecraft\client\render\model\MultipartUnbakedModel.mapping:
  7:    METHOD equals (Ljava/lang/Object;)Z
  8:        ARG 1 o

mappings\net\minecraft\client\render\model\json\ModelVariant.mapping:
  11:   METHOD equals (Ljava/lang/Object;)Z
  12:       ARG 1 o

mappings\net\minecraft\client\render\model\json\ModelVariantMap.mapping:
   9:   METHOD equals (Ljava/lang/Object;)Z
  10:       ARG 1 o

mappings\net\minecraft\client\render\model\json\MultipartModelComponent.mapping:
  7:    METHOD equals (Ljava/lang/Object;)Z
  8:        ARG 1 o

mappings\net\minecraft\client\render\model\json\Transformation.mapping:
  10:   METHOD equals (Ljava/lang/Object;)Z
  11:       ARG 1 o

mappings\net\minecraft\client\render\model\json\WeightedUnbakedModel.mapping:
  5:    METHOD equals (Ljava/lang/Object;)Z
  6:        ARG 1 o

mappings\net\minecraft\client\resource\language\LanguageDefinition.mapping:
  11:   METHOD equals (Ljava/lang/Object;)Z
  12:       ARG 1 o

mappings\net\minecraft\client\util\InputUtil.mapping:
  38:       METHOD equals (Ljava/lang/Object;)Z
  39:           ARG 1 other

mappings\net\minecraft\client\util\VideoMode.mapping:
  16:   METHOD equals (Ljava/lang/Object;)Z
  17:       ARG 1 o

mappings\net\minecraft\command\argument\CoordinateArgument.mapping:
   9:   METHOD equals (Ljava/lang/Object;)Z
  10:       ARG 1 o

mappings\net\minecraft\command\argument\DefaultPosArgument.mapping:
   9:   METHOD equals (Ljava/lang/Object;)Z
  10:       ARG 1 o

mappings\net\minecraft\command\argument\LookingPosArgument.mapping:
   9:   METHOD equals (Ljava/lang/Object;)Z
  10:       ARG 1 o

mappings\net\minecraft\data\client\model\PropertiesMap.mapping:
  11:   METHOD equals (Ljava/lang/Object;)Z
  12:       ARG 1 o

mappings\net\minecraft\entity\Entity.mapping:
  86:   METHOD equals (Ljava/lang/Object;)Z
  87:       ARG 1 o

mappings\net\minecraft\entity\ai\pathing\PathNode.mapping:
  19:   METHOD equals (Ljava/lang/Object;)Z
  20:       ARG 1 o

mappings\net\minecraft\entity\attribute\EntityAttributeModifier.mapping:
  21:   METHOD equals (Ljava/lang/Object;)Z
  22:       ARG 1 o

mappings\net\minecraft\entity\data\TrackedData.mapping:
  7:    METHOD equals (Ljava/lang/Object;)Z
  8:        ARG 1 o

mappings\net\minecraft\entity\effect\StatusEffectInstance.mapping:
  50:   METHOD equals (Ljava/lang/Object;)Z
  51:       ARG 1 o

mappings\net\minecraft\item\map\MapBannerMarker.mapping:
  12:   METHOD equals (Ljava/lang/Object;)Z
  13:       ARG 1 o

mappings\net\minecraft\item\map\MapIcon.mapping:
  13:   METHOD equals (Ljava/lang/Object;)Z
  14:       ARG 1 o

mappings\net\minecraft\loot\provider\number\ConstantLootNumberProvider.mapping:
  5:    METHOD equals (Ljava/lang/Object;)Z
  6:        ARG 1 object

mappings\net\minecraft\nbt\NbtByte.mapping:
   9:   METHOD equals (Ljava/lang/Object;)Z
  10:       ARG 1 o

mappings\net\minecraft\nbt\NbtByteArray.mapping:
   9:   METHOD equals (Ljava/lang/Object;)Z
  10:       ARG 1 o

mappings\net\minecraft\nbt\NbtCompound.mapping:
  8:    METHOD equals (Ljava/lang/Object;)Z
  9:        ARG 1 o

mappings\net\minecraft\nbt\NbtDouble.mapping:
  8:    METHOD equals (Ljava/lang/Object;)Z
  9:        ARG 1 o

mappings\net\minecraft\nbt\NbtFloat.mapping:
  8:    METHOD equals (Ljava/lang/Object;)Z
  9:        ARG 1 o

mappings\net\minecraft\nbt\NbtInt.mapping:
  7:    METHOD equals (Ljava/lang/Object;)Z
  8:        ARG 1 o

mappings\net\minecraft\nbt\NbtIntArray.mapping:
   9:   METHOD equals (Ljava/lang/Object;)Z
  10:       ARG 1 o

mappings\net\minecraft\nbt\NbtList.mapping:
  13:   METHOD equals (Ljava/lang/Object;)Z
  14:       ARG 1 o

mappings\net\minecraft\nbt\NbtLong.mapping:
  7:    METHOD equals (Ljava/lang/Object;)Z
  8:        ARG 1 o

mappings\net\minecraft\nbt\NbtLongArray.mapping:
  11:   METHOD equals (Ljava/lang/Object;)Z
  12:       ARG 1 o

mappings\net\minecraft\nbt\NbtShort.mapping:
  7:    METHOD equals (Ljava/lang/Object;)Z
  8:        ARG 1 o

mappings\net\minecraft\nbt\NbtString.mapping:
  8:    METHOD equals (Ljava/lang/Object;)Z
  9:        ARG 1 o

mappings\net\minecraft\resource\ResourceImpl.mapping:
  13:   METHOD equals (Ljava/lang/Object;)Z
  14:       ARG 1 o

mappings\net\minecraft\resource\ResourcePackProfile.mapping:
  40:   METHOD equals (Ljava/lang/Object;)Z
  41:       ARG 1 o

mappings\net\minecraft\server\world\BlockEvent.mapping:
  11:   METHOD equals (Ljava/lang/Object;)Z
  12:       ARG 1 o

mappings\net\minecraft\server\world\ChunkTicket.mapping:
  13:   METHOD equals (Ljava/lang/Object;)Z
  14:       ARG 1 obj

mappings\net\minecraft\server\world\ThreadedAnvilChunkStorage.mapping:
  165:      METHOD equals (Ljava/lang/Object;)Z
  166:          ARG 1 o

mappings\net\minecraft\stat\Stat.mapping:
   9:   METHOD equals (Ljava/lang/Object;)Z
  10:       ARG 1 o

mappings\net\minecraft\state\property\Property.mapping:
  10:   METHOD equals (Ljava/lang/Object;)Z
  11:       ARG 1 o
  36:       METHOD equals (Ljava/lang/Object;)Z
  37:           ARG 1 o

mappings\net\minecraft\structure\JigsawJunction.mapping:
  13:   METHOD equals (Ljava/lang/Object;)Z
  14:       ARG 1 o

mappings\net\minecraft\text\BaseText.mapping:
  6:    METHOD equals (Ljava/lang/Object;)Z
  7:        ARG 1 obj

mappings\net\minecraft\text\ClickEvent.mapping:
  7:    METHOD equals (Ljava/lang/Object;)Z
  8:        ARG 1 obj

mappings\net\minecraft\text\HoverEvent.mapping:
  8:    METHOD equals (Ljava/lang/Object;)Z
  9:        ARG 1 obj

mappings\net\minecraft\text\Style.mapping:
  33:   METHOD equals (Ljava/lang/Object;)Z
  34:       ARG 1 obj

mappings\net\minecraft\util\Identifier.mapping:
  23:   METHOD equals (Ljava/lang/Object;)Z
  24:       ARG 1 other

mappings\net\minecraft\util\collection\Weight.mapping:
  8:    METHOD equals (Ljava/lang/Object;)Z
  9:        ARG 1 o

mappings\net\minecraft\util\dynamic\Codecs.mapping:
  37:       METHOD equals (Ljava/lang/Object;)Z
  38:           ARG 1 o

mappings\net\minecraft\util\dynamic\GlobalPos.mapping:
  8:    METHOD equals (Ljava/lang/Object;)Z
  9:        ARG 1 o

mappings\net\minecraft\util\math\BlockBox.mapping:
  31:   METHOD equals (Ljava/lang/Object;)Z
  32:       ARG 1 o

mappings\net\minecraft\util\math\Box.mapping:
  23:   METHOD equals (Ljava/lang/Object;)Z
  24:       ARG 1 o

mappings\net\minecraft\util\math\ChunkPos.mapping:
  12:   METHOD equals (Ljava/lang/Object;)Z
  13:       ARG 1 o

mappings\net\minecraft\util\math\EulerAngle.mapping:
  11:   METHOD equals (Ljava/lang/Object;)Z
  12:       ARG 1 o

mappings\net\minecraft\util\math\Matrix3f.mapping:
  23:   METHOD equals (Ljava/lang/Object;)Z
  24:       ARG 1 object

mappings\net\minecraft\util\math\Matrix4f.mapping:
  24:   METHOD equals (Ljava/lang/Object;)Z
  25:       ARG 1 o

mappings\net\minecraft\util\math\Quaternion.mapping:
  23:   METHOD equals (Ljava/lang/Object;)Z
  24:       ARG 1 o

mappings\net\minecraft\util\math\Vec3d.mapping:
  13:   METHOD equals (Ljava/lang/Object;)Z
  14:       ARG 1 o

mappings\net\minecraft\util\math\Vec3f.mapping:
  19:   METHOD equals (Ljava/lang/Object;)Z
  20:       ARG 1 o

mappings\net\minecraft\util\math\Vec3i.mapping:
  18:   METHOD equals (Ljava/lang/Object;)Z
  19:       ARG 1 o

mappings\net\minecraft\util\math\Vector4f.mapping:
  15:   METHOD equals (Ljava/lang/Object;)Z
  16:       ARG 1 o

mappings\net\minecraft\util\math\floatprovider\ClampedNormalFloatProvider.mapping:
  12:   METHOD equals (Ljava/lang/Object;)Z
  13:       ARG 1 object

mappings\net\minecraft\util\math\floatprovider\ConstantFloatProvider.mapping:
  7:    METHOD equals (Ljava/lang/Object;)Z
  8:        ARG 1 object

mappings\net\minecraft\util\math\floatprovider\TrapezoidFloatProvider.mapping:
  10:   METHOD equals (Ljava/lang/Object;)Z
  11:       ARG 1 object

mappings\net\minecraft\util\math\floatprovider\UniformFloatProvider.mapping:
  8:    METHOD equals (Ljava/lang/Object;)Z
  9:        ARG 1 object

mappings\net\minecraft\util\math\intprovider\ConstantIntProvider.mapping:
  7:    METHOD equals (Ljava/lang/Object;)Z
  8:        ARG 1 object

mappings\net\minecraft\util\math\intprovider\UniformIntProvider.mapping:
  8:    METHOD equals (Ljava/lang/Object;)Z
  9:        ARG 1 object

mappings\net\minecraft\world\GameRules.mapping:
  161:      METHOD equals (Ljava/lang/Object;)Z
  162:          ARG 1 obj

mappings\net\minecraft\world\ScheduledTick.mapping:
  16:   METHOD equals (Ljava/lang/Object;)Z
  17:       ARG 1 o

mappings\net\minecraft\world\biome\Biome.mapping:
  160:      METHOD equals (Ljava/lang/Object;)Z
  161:          ARG 1 object

mappings\net\minecraft\world\poi\PointOfInterest.mapping:
  15:   METHOD equals (Ljava/lang/Object;)Z
  16:       ARG 1 obj

bug refactor vote

Fuente

enbrain

🚀1 ❤1

Comentario más útil

Yo también estoy a favor de usar o . Además de ser lo que se usa en Object#equals , también es el más comúnmente usado en todos los hilos, y creo que se usa en los proyectos de código abierto de Mojang y en otros lugares [cita requerida].

other es el antiguo estándar que solía usar, así que aceptaré la culpa de los que estén allí.
object parece que la gente acaba de aceptar la sugerencia automática que da Enigma debido a la falta de una regla establecida.

Sollace en 9 abr. 2021

👍2

Todos 4 comentarios

Personalmente, preferiría equals(Object other) . Sin embargo, tenga en cuenta que java.lang.Object usa o .

haykam821 en 9 abr. 2021

Apoyo o . other en el código fuente suele ser el nombre de la variable local que se usa para una instancia de un tipo específico después de una verificación getClass() == o instanceof .