Freecodecamp: Change ordered list to unordered list in project challenges

Created on 31 May 2016  ·  10Comments  ·  Source: freeCodeCamp/freeCodeCamp

Challenge Name

Any of the project challenge pages (e.g https://www.freecodecamp.com/challenges/show-the-local-weather)

Issue Description

Currently, the project challenges have an ordered list, listing the requirements and instructions for the challenge. However, I think there are too many "lists" as there is a bulleted list and the numerical list.

Firstly, I remember reading someone making an issue or comment on how the rule numbers usually make a weird contrast with its list number, like so where Rule #1 is listed as #2 in the list:

image

Secondly, there appears to be a redundancy in "lists," where you have the check boxes but also the numbered list items. Each item is already separated by spaces so I don't think you _really_ need the numbers.

Numbers in a list, in my opinion, should have some meaning to it like needing to know there are 3 or 4 requirements for something. But in this case, the numbers don't really tell you much except there are 10 or so lines to read, which knowing the number is inconsequential to solving the challenge.

Proposed Fix

Change the ordered list to an unordered one. To make these changes, I think all we'd need to do is change this line from ol to ul (correct me if I'm wrong). Overall, I think these changes will give a cleaner look to the challenges.

Screenshot

Currently:
image

Proposed Change:
image

cc/ @hallaathrad

help wanted UI

Most helpful comment

@sanskar-modi, feel free to tackle this now! We have decided to remove the checkboxes and numbers.

Please, check our Guidelines for Contributing and if you need any assistance reach out to the Contributors Chat room.

All 10 comments

I think this is a lot better!

can i try this or there is more discussion on this ??

@sanskar-modi let's wait for @hallaathrad opinion!

Hmm haven't checked on all cases, but at least right now it makes a lot of sense to me. I'd say we take it, and then if any specific challenge requires an ordered list, we go an fix it on a case by case.
LGTM.


PS: While we're at it, can we try to figure out whether we actually need checkboxes? Most of the time they've seemed pointless to me in a practical sense.

We could probably go without the checkboxes as well.

image

We could probably center the list a little as well. I just did a quick HTML change to show what it'll look like.

Perfect, now a matter of removing the space on the left of the list, and we should be golden.
what do you think @FreeCodeCamp/issue-moderators ?

Yup, lets save some more real estate!

@hallaathrad @raisedadead, yeah let's do it!

@sanskar-modi, feel free to tackle this now! We have decided to remove the checkboxes and numbers.

Please, check our Guidelines for Contributing and if you need any assistance reach out to the Contributors Chat room.

Looks like this has been fixed. Reopen if I'm mistaken.

Was this page helpful?
0 / 5 - 0 ratings