Githawk: Collection view in repos do not respect safe area

Created on 11 Feb 2019 · 12Comments · Source: GitHawkApp/GitHawk

GitHawk Upload by BasThomas

Bug Report Dump (Auto-generated)

Version 1.27.1 (1546622353)
Device: iPhone X (iOS 12.1.2)
TestFlight: true

🐛 bug ✨ good first issue

Source

BasThomas

👍3

Most helpful comment

⏩ #2666

j-f1 on 6 Mar 2019

👍2

All 12 comments

I can take a look at this.

RJ-Clegg on 28 Feb 2019

🎉2

is this still an issue? i could help :)

ivenprillwitz on 5 Mar 2019

is this still an issue? i could help :)

Only managed to get time to look at this now. I'll let you know if I have any issues. Thanks!

RJ-Clegg on 5 Mar 2019

@BasThomas - How did you get the UITabBar to disappear?
I've gone to the exact repo from the screenshot - via search and from bookmarks. The UITabBar remains in place; even whilst scrolling.

With the UITabBar on screen; this issue isn't reproducible.

RJ-Clegg on 5 Mar 2019

If you open it from Notifications, the tab bar is not present.

j-f1 on 5 Mar 2019

If you open it from Notifications, the tab bar is not present.

Thanks, will check it out

RJ-Clegg on 5 Mar 2019

And from the navigation bar in an issue 😊

_{Sent with GitHawk}

BasThomas on 5 Mar 2019

Ah yeah, only from the navbar in an issue. I wonder — should this just be worked around by always showing the tab bar?

j-f1 on 5 Mar 2019

And from the navigation bar in an issue 😊

Sent with GitHawk

Thanks, I am able to reproduce it easily enough now. I'll have a fix soon when I get home this evening.

RJ-Clegg on 6 Mar 2019

🎉1

Ah yeah, only from the navbar in an issue. I wonder — should this just be worked around by always showing the tab bar?

@j-f1 not sure, but I feel that should / can be tackled separately.

_{Sent with GitHawk}

BasThomas on 6 Mar 2019

👍2

⏩ #2666

j-f1 on 6 Mar 2019

👍2

Just taking a quick look at this one in the RepositoryViewController, seems like is an issue with the XLPagerTabStrip dependency. Here https://github.com/xmartlabs/XLPagerTabStrip/issues/722