Mycroft-core: [Meta] Berbagai masalah basis kode yang membatasi kolaborasi dan penerapan

Dibuat pada 20 Mei 2016  ·  15Komentar  ·  Sumber: MycroftAI/mycroft-core

  • [x] File Python sama sekali tidak memiliki header lisensi - tidak cocok untuk kolaborasi
  • [x] Basis kode tidak sesuai dengan PEP8.
  • [x] Sistem build sangat funky dan memiliki visi terowongan untuk Ubuntu

Masalah PEP8:

./mycroft-base-setup.py:3:80: E501 line too long (92 > 79 characters)
./test/client/audio_consumer_test.py:5:80: E501 line too long (91 > 79 characters)
./test/client/audio_consumer_test.py:6:80: E501 line too long (83 > 79 characters)
./test/client/audio_consumer_test.py:37:80: E501 line too long (86 > 79 characters)
./test/client/audio_consumer_test.py:43:80: E501 line too long (81 > 79 characters)
./test/client/audio_consumer_test.py:46:80: E501 line too long (93 > 79 characters)
./test/client/audio_consumer_test.py:51:80: E501 line too long (109 > 79 characters)
./test/client/audio_consumer_test.py:52:80: E501 line too long (107 > 79 characters)
./test/client/audio_consumer_test.py:54:80: E501 line too long (109 > 79 characters)
./test/client/audio_consumer_test.py:57:80: E501 line too long (80 > 79 characters)
./test/client/audio_consumer_test.py:69:80: E501 line too long (119 > 79 characters)
./test/client/audio_consumer_test.py:74:80: E501 line too long (119 > 79 characters)
./test/client/audio_consumer_test.py:79:80: E501 line too long (80 > 79 characters)
./test/client/audio_consumer_test.py:94:80: E501 line too long (109 > 79 characters)
./test/client/audio_consumer_test.py:110:54: E231 missing whitespace after ','
./test/client/audio_consumer_test.py:124:80: E501 line too long (80 > 79 characters)
./test/client/wakeword_recognizer_test.py:8:1: E402 module level import not at top of file
./test/client/wakeword_recognizer_test.py:10:9: E225 missing whitespace around operator
./test/client/wakeword_recognizer_test.py:12:1: E302 expected 2 blank lines, found 1
./test/client/dynamic_energy_test.py:53:80: E501 line too long (111 > 79 characters)
./test/client/dynamic_energy_test.py:54:32: E222 multiple spaces after operator
./test/client/dynamic_energy_test.py:54:80: E501 line too long (81 > 79 characters)
./test/client/dynamic_energy_test.py:56:58: W292 no newline at end of file
./test/skills/skill_tester.py:15:80: E501 line too long (87 > 79 characters)
./test/skills/skill_tester.py:30:36: E261 at least two spaces before inline comment
./test/skills/skill_tester.py:43:80: E501 line too long (95 > 79 characters)
./test/skills/skill_tester.py:54:80: E501 line too long (99 > 79 characters)
./test/skills/skill_tester.py:58:1: W391 blank line at end of file
./test/skills/discover_tests.py:13:80: E501 line too long (115 > 79 characters)
./test/skills/discover_tests.py:16:80: E501 line too long (100 > 79 characters)
./test/skills/discover_tests.py:34:80: E501 line too long (98 > 79 characters)
./test/skills/discover_tests.py:35:80: E501 line too long (87 > 79 characters)
./test/skills/discover_tests.py:42:1: W293 blank line contains whitespace
./test/skills/discover_tests.py:44:80: E501 line too long (102 > 79 characters)
./test/skills/discover_tests.py:51:1: W391 blank line at end of file
./test/test_runner.py:4:1: E402 module level import not at top of file
./test/test_runner.py:6:1: E402 module level import not at top of file
./test/test_runner.py:7:1: E402 module level import not at top of file
./test/test_runner.py:8:1: E402 module level import not at top of file
./test/test_runner.py:21:16: W292 no newline at end of file
./skills-sdk-setup.py:38:2: W292 no newline at end of file
./doc/generate_sdk_docs.py:53:11: W292 no newline at end of file
./mycroft/client/speech/listener.py:12:80: E501 line too long (83 > 79 characters)
./mycroft/client/speech/listener.py:29:80: E501 line too long (84 > 79 characters)
./mycroft/client/speech/listener.py:50:80: E501 line too long (106 > 79 characters)
./mycroft/client/speech/listener.py:51:80: E501 line too long (87 > 79 characters)
./mycroft/client/speech/listener.py:61:80: E501 line too long (116 > 79 characters)
./mycroft/client/speech/listener.py:62:80: E501 line too long (89 > 79 characters)
./mycroft/client/speech/listener.py:67:80: E501 line too long (132 > 79 characters)
./mycroft/client/speech/listener.py:104:80: E501 line too long (101 > 79 characters)
./mycroft/client/speech/listener.py:107:51: E203 whitespace before ':'
./mycroft/client/speech/listener.py:110:80: E501 line too long (111 > 79 characters)
./mycroft/client/speech/listener.py:112:80: E501 line too long (96 > 79 characters)
./mycroft/client/speech/listener.py:120:80: E501 line too long (102 > 79 characters)
./mycroft/client/speech/listener.py:123:80: E501 line too long (145 > 79 characters)
./mycroft/client/speech/listener.py:126:80: E501 line too long (99 > 79 characters)
./mycroft/client/speech/listener.py:127:80: E501 line too long (105 > 79 characters)
./mycroft/client/speech/listener.py:134:80: E501 line too long (83 > 79 characters)
./mycroft/client/speech/listener.py:135:64: E231 missing whitespace after ','
./mycroft/client/speech/listener.py:135:80: E501 line too long (93 > 79 characters)
./mycroft/client/speech/listener.py:138:80: E501 line too long (95 > 79 characters)
./mycroft/client/speech/listener.py:139:64: E231 missing whitespace after ','
./mycroft/client/speech/listener.py:139:80: E501 line too long (93 > 79 characters)
./mycroft/client/speech/listener.py:148:80: E501 line too long (87 > 79 characters)
./mycroft/client/speech/listener.py:150:80: E501 line too long (85 > 79 characters)
./mycroft/client/speech/listener.py:170:80: E501 line too long (82 > 79 characters)
./mycroft/client/speech/listener.py:176:80: E501 line too long (90 > 79 characters)
./mycroft/client/speech/listener.py:180:80: E501 line too long (95 > 79 characters)
./mycroft/client/speech/listener.py:190:80: E501 line too long (95 > 79 characters)
./mycroft/client/speech/listener.py:193:80: E501 line too long (86 > 79 characters)
./mycroft/client/speech/listener.py:196:80: E501 line too long (86 > 79 characters)
./mycroft/client/speech/listener.py:198:80: E501 line too long (115 > 79 characters)
./mycroft/client/speech/listener.py:200:80: E501 line too long (114 > 79 characters)
./mycroft/client/speech/listener.py:223:80: E501 line too long (80 > 79 characters)
./mycroft/client/speech/listener.py:233:80: E501 line too long (87 > 79 characters)
./mycroft/client/speech/listener.py:238:80: E501 line too long (89 > 79 characters)
./mycroft/client/speech/listener.py:239:80: E501 line too long (111 > 79 characters)
./mycroft/client/speech/listener.py:246:80: E501 line too long (101 > 79 characters)
./mycroft/client/speech/listener.py:250:80: E501 line too long (104 > 79 characters)
./mycroft/client/speech/listener.py:253:80: E501 line too long (113 > 79 characters)
./mycroft/client/speech/listener.py:300:80: E501 line too long (95 > 79 characters)
./mycroft/client/speech/listener.py:302:80: E501 line too long (99 > 79 characters)
./mycroft/client/speech/listener.py:303:80: E501 line too long (103 > 79 characters)
./mycroft/client/speech/listener.py:304:80: E501 line too long (122 > 79 characters)
./mycroft/client/speech/listener.py:307:80: E501 line too long (103 > 79 characters)
./mycroft/client/speech/listener.py:308:80: E501 line too long (108 > 79 characters)
./mycroft/client/speech/listener.py:324:80: E501 line too long (93 > 79 characters)
./mycroft/client/speech/wakeword_recognizer.py:4:1: E402 module level import not at top of file
./mycroft/client/speech/wakeword_recognizer.py:5:1: E402 module level import not at top of file
./mycroft/client/speech/wakeword_recognizer.py:7:1: E402 module level import not at top of file
./mycroft/client/speech/wakeword_recognizer.py:13:1: E402 module level import not at top of file
./mycroft/client/speech/wakeword_recognizer.py:15:1: E302 expected 2 blank lines, found 1
./mycroft/client/speech/wakeword_recognizer.py:17:80: E501 line too long (83 > 79 characters)
./mycroft/client/speech/wakeword_recognizer.py:22:14: E701 multiple statements on one line (colon)
./mycroft/client/speech/wakeword_recognizer.py:24:10: E222 multiple spaces after operator
./mycroft/client/speech/wakeword_recognizer.py:25:6: E225 missing whitespace around operator
./mycroft/client/speech/wakeword_recognizer.py:48:80: E501 line too long (81 > 79 characters)
./mycroft/client/speech/wakeword_recognizer.py:49:80: E501 line too long (97 > 79 characters)
./mycroft/client/speech/wakeword_recognizer.py:58:31: W292 no newline at end of file
./mycroft/client/speech/mic.py:7:80: E501 line too long (83 > 79 characters)
./mycroft/client/speech/mic.py:16:31: E711 comparison to None should be 'if cond is not None:'
./mycroft/client/speech/mic.py:60:36: E251 unexpected spaces around keyword / parameter equals
./mycroft/client/speech/mic.py:60:38: E251 unexpected spaces around keyword / parameter equals
./mycroft/client/speech/mic.py:60:56: E251 unexpected spaces around keyword / parameter equals
./mycroft/client/speech/mic.py:60:58: E251 unexpected spaces around keyword / parameter equals
./mycroft/client/speech/mic.py:60:76: E251 unexpected spaces around keyword / parameter equals
./mycroft/client/speech/mic.py:60:78: E251 unexpected spaces around keyword / parameter equals
./mycroft/client/speech/mic.py:60:80: E501 line too long (84 > 79 characters)
./mycroft/client/speech/mic.py:61:80: E501 line too long (108 > 79 characters)
./mycroft/client/speech/mic.py:65:80: E501 line too long (91 > 79 characters)
./mycroft/client/speech/mic.py:68:31: E251 unexpected spaces around keyword / parameter equals
./mycroft/client/speech/mic.py:68:33: E251 unexpected spaces around keyword / parameter equals
./mycroft/client/speech/mic.py:68:61: E251 unexpected spaces around keyword / parameter equals
./mycroft/client/speech/mic.py:68:63: E251 unexpected spaces around keyword / parameter equals
./mycroft/client/speech/mic.py:69:19: E251 unexpected spaces around keyword / parameter equals
./mycroft/client/speech/mic.py:69:21: E251 unexpected spaces around keyword / parameter equals
./mycroft/client/speech/mic.py:69:39: E251 unexpected spaces around keyword / parameter equals
./mycroft/client/speech/mic.py:69:41: E251 unexpected spaces around keyword / parameter equals
./mycroft/client/speech/mic.py:69:77: E251 unexpected spaces around keyword / parameter equals
./mycroft/client/speech/mic.py:69:79: E251 unexpected spaces around keyword / parameter equals
./mycroft/client/speech/mic.py:69:80: E501 line too long (90 > 79 characters)
./mycroft/client/speech/mic.py:70:18: E251 unexpected spaces around keyword / parameter equals
./mycroft/client/speech/mic.py:70:20: E251 unexpected spaces around keyword / parameter equals
./mycroft/client/speech/mic.py:70:26: E261 at least two spaces before inline comment
./mycroft/client/speech/mic.py:97:37: E251 unexpected spaces around keyword / parameter equals
./mycroft/client/speech/mic.py:97:39: E251 unexpected spaces around keyword / parameter equals
./mycroft/client/speech/mic.py:99:80: E501 line too long (127 > 79 characters)
./mycroft/client/speech/mic.py:101:80: E501 line too long (313 > 79 characters)
./mycroft/client/speech/mic.py:103:80: E501 line too long (245 > 79 characters)
./mycroft/client/speech/mic.py:105:80: E501 line too long (80 > 79 characters)
./mycroft/client/speech/mic.py:109:80: E501 line too long (158 > 79 characters)
./mycroft/client/speech/mic.py:109:87: E261 at least two spaces before inline comment
./mycroft/client/speech/mic.py:110:80: E501 line too long (181 > 79 characters)
./mycroft/client/speech/mic.py:110:89: E261 at least two spaces before inline comment
./mycroft/client/speech/mic.py:111:80: E501 line too long (176 > 79 characters)
./mycroft/client/speech/mic.py:111:100: E261 at least two spaces before inline comment
./mycroft/client/speech/mic.py:113:80: E501 line too long (82 > 79 characters)
./mycroft/client/speech/mic.py:114:25: E261 at least two spaces before inline comment
./mycroft/client/speech/mic.py:121:55: E261 at least two spaces before inline comment
./mycroft/client/speech/mic.py:121:80: E501 line too long (84 > 79 characters)
./mycroft/client/speech/mic.py:125:36: E701 multiple statements on one line (colon)
./mycroft/client/speech/mic.py:125:43: E261 at least two spaces before inline comment
./mycroft/client/speech/mic.py:127:60: E261 at least two spaces before inline comment
./mycroft/client/speech/mic.py:127:80: E501 line too long (123 > 79 characters)
./mycroft/client/speech/mic.py:131:66: E261 at least two spaces before inline comment
./mycroft/client/speech/mic.py:131:80: E501 line too long (94 > 79 characters)
./mycroft/client/speech/mic.py:132:50: E701 multiple statements on one line (colon)
./mycroft/client/speech/mic.py:134:80: E501 line too long (92 > 79 characters)
./mycroft/client/speech/mic.py:135:80: E501 line too long (103 > 79 characters)
./mycroft/client/speech/mic.py:143:36: E701 multiple statements on one line (colon)
./mycroft/client/speech/mic.py:143:43: E261 at least two spaces before inline comment
./mycroft/client/speech/mic.py:147:80: E501 line too long (102 > 79 characters)
./mycroft/client/speech/mic.py:148:66: E261 at least two spaces before inline comment
./mycroft/client/speech/mic.py:148:80: E501 line too long (94 > 79 characters)
./mycroft/client/speech/mic.py:153:53: E261 at least two spaces before inline comment
./mycroft/client/speech/mic.py:156:80: E501 line too long (81 > 79 characters)
./mycroft/client/speech/mic.py:157:80: E501 line too long (86 > 79 characters)
./mycroft/client/speech/mic.py:160:80: E501 line too long (80 > 79 characters)
./mycroft/client/speech/mic.py:163:80: E501 line too long (99 > 79 characters)
./mycroft/client/speech/mic.py:165:51: E701 multiple statements on one line (colon)
./mycroft/client/speech/mic.py:165:58: E261 at least two spaces before inline comment
./mycroft/client/speech/mic.py:165:80: E501 line too long (97 > 79 characters)
./mycroft/client/speech/mic.py:168:64: E701 multiple statements on one line (colon)
./mycroft/client/speech/mic.py:168:78: E261 at least two spaces before inline comment
./mycroft/client/speech/mic.py:168:80: E501 line too long (123 > 79 characters)
./mycroft/client/speech/mic.py:175:80: E501 line too long (129 > 79 characters)
./mycroft/client/speech/mic.py:177:80: E501 line too long (99 > 79 characters)
./mycroft/client/speech/mic.py:177:100: W292 no newline at end of file
./mycroft/client/speech/recognizer_wrapper.py:24:80: E501 line too long (80 > 79 characters)
./mycroft/client/speech/recognizer_wrapper.py:26:80: E501 line too long (101 > 79 characters)
./mycroft/client/speech/recognizer_wrapper.py:33:80: E501 line too long (80 > 79 characters)
./mycroft/client/speech/recognizer_wrapper.py:34:80: E501 line too long (97 > 79 characters)
./mycroft/client/speech/recognizer_wrapper.py:43:80: E501 line too long (80 > 79 characters)
./mycroft/client/speech/recognizer_wrapper.py:46:80: E501 line too long (109 > 79 characters)
./mycroft/client/speech/recognizer_wrapper.py:53:80: E501 line too long (80 > 79 characters)
./mycroft/client/speech/recognizer_wrapper.py:59:80: E501 line too long (92 > 79 characters)
./mycroft/client/speech/recognizer_wrapper.py:81:20: E701 multiple statements on one line (colon)
./mycroft/client/speech/recognizer_wrapper.py:84:46: E701 multiple statements on one line (colon)
./mycroft/client/speech/recognizer_wrapper.py:87:80: E501 line too long (85 > 79 characters)
./mycroft/client/speech/recognizer_wrapper.py:88:80: E501 line too long (83 > 79 characters)
./mycroft/client/speech/recognizer_wrapper.py:95:80: E501 line too long (90 > 79 characters)
./mycroft/client/speech/main.py:19:1: E302 expected 2 blank lines, found 1
./mycroft/client/speech/main.py:82:80: E501 line too long (86 > 79 characters)
./mycroft/client/enclosure/enclosure.py:24:80: E501 line too long (86 > 79 characters)
./mycroft/client/enclosure/enclosure.py:65:80: E501 line too long (80 > 79 characters)
./mycroft/client/enclosure/enclosure.py:112:80: E501 line too long (91 > 79 characters)
./mycroft/client/enclosure/enclosure.py:133:80: E501 line too long (104 > 79 characters)
./mycroft/client/enclosure/enclosure.py:134:80: E501 line too long (117 > 79 characters)
./mycroft/client/enclosure/enclosure.py:136:80: E501 line too long (86 > 79 characters)
./mycroft/client/enclosure/api.py:13:80: E501 line too long (81 > 79 characters)
./mycroft/client/enclosure/api.py:26:80: E501 line too long (86 > 79 characters)
./mycroft/client/enclosure/api.py:35:80: E501 line too long (82 > 79 characters)
./mycroft/client/enclosure/api.py:41:80: E501 line too long (81 > 79 characters)
./mycroft/client/enclosure/api.py:44:80: E501 line too long (92 > 79 characters)
./mycroft/client/enclosure/api.py:47:80: E501 line too long (84 > 79 characters)
./mycroft/client/enclosure/api.py:65:80: E501 line too long (82 > 79 characters)
./mycroft/client/text/cli.py:34:8: E713 test for membership should be 'not in'
./mycroft/client/text/cli.py:43:80: E501 line too long (102 > 79 characters)
./mycroft/messagebus/client/ws.py:35:80: E501 line too long (95 > 79 characters)
./mycroft/messagebus/client/ws.py:36:36: E127 continuation line over-indented for visual indent
./mycroft/messagebus/client/ws.py:37:36: E127 continuation line over-indented for visual indent
./mycroft/messagebus/client/ws.py:38:36: E127 continuation line over-indented for visual indent
./mycroft/messagebus/client/ws.py:39:36: E127 continuation line over-indented for visual indent
./mycroft/messagebus/client/ws.py:55:80: E501 line too long (87 > 79 characters)
./mycroft/messagebus/client/ws.py:64:80: E501 line too long (95 > 79 characters)
./mycroft/messagebus/client/ws.py:67:80: E501 line too long (85 > 79 characters)
./mycroft/messagebus/client/ws.py:89:5: E301 expected 1 blank line, found 0
./mycroft/messagebus/client/ws.py:100:11: W292 no newline at end of file
./mycroft/messagebus/message.py:2:1: E402 module level import not at top of file
./mycroft/messagebus/message.py:47:68: W292 no newline at end of file
./mycroft/messagebus/service/ws.py:21:80: E501 line too long (89 > 79 characters)
./mycroft/messagebus/service/ws.py:35:80: E501 line too long (86 > 79 characters)
./mycroft/messagebus/service/ws.py:51:80: E501 line too long (101 > 79 characters)
./mycroft/messagebus/service/main.py:16:1: E303 too many blank lines (4)
./mycroft/identity/__init__.py:29:80: E501 line too long (91 > 79 characters)
./mycroft/tts/google_tts.py:33:80: E501 line too long (109 > 79 characters)
./mycroft/tts/tts_factory.py:18:80: E501 line too long (127 > 79 characters)
./mycroft/tts/fa_tts.py:49:80: E501 line too long (115 > 79 characters)
./mycroft/tts/spdsay_tts.py:15:80: E501 line too long (81 > 79 characters)
./mycroft/tts/spdsay_tts.py:30:80: E501 line too long (111 > 79 characters)
./mycroft/tts/mary_tts.py:46:80: E501 line too long (116 > 79 characters)
./mycroft/tts/remote_tts.py:19:80: E501 line too long (108 > 79 characters)
./mycroft/tts/remote_tts.py:52:80: E501 line too long (120 > 79 characters)
./mycroft/tts/remote_tts.py:64:80: E501 line too long (101 > 79 characters)
./mycroft/tts/__init__.py:15:80: E501 line too long (93 > 79 characters)
./mycroft/tts/__init__.py:33:80: E501 line too long (99 > 79 characters)
./mycroft/tts/__init__.py:48:80: E501 line too long (80 > 79 characters)
./mycroft/tts/__init__.py:53:80: E501 line too long (83 > 79 characters)
./mycroft/tts/__init__.py:57:80: E501 line too long (88 > 79 characters)
./mycroft/tts/mimic_tts.py:13:80: E501 line too long (80 > 79 characters)
./mycroft/tts/mimic_tts.py:35:80: E501 line too long (95 > 79 characters)
./mycroft/tts/espeak_tts.py:15:80: E501 line too long (81 > 79 characters)
./mycroft/tts/espeak_tts.py:30:80: E501 line too long (100 > 79 characters)
./mycroft/session/__init__.py:56:80: E501 line too long (98 > 79 characters)
./mycroft/session/__init__.py:58:80: E501 line too long (117 > 79 characters)
./mycroft/session/__init__.py:59:80: E501 line too long (96 > 79 characters)
./mycroft/session/__init__.py:71:1: W391 blank line at end of file
./mycroft/pairing/client.py:29:80: E501 line too long (85 > 79 characters)
./mycroft/pairing/client.py:32:80: E501 line too long (82 > 79 characters)
./mycroft/pairing/client.py:61:1: E303 too many blank lines (3)
./mycroft/pairing/client.py:65:11: W292 no newline at end of file
./mycroft/skills/core.py:34:80: E501 line too long (98 > 79 characters)
./mycroft/skills/core.py:37:80: E501 line too long (116 > 79 characters)
./mycroft/skills/core.py:42:80: E501 line too long (89 > 79 characters)
./mycroft/skills/core.py:59:80: E501 line too long (104 > 79 characters)
./mycroft/skills/core.py:60:80: E501 line too long (112 > 79 characters)
./mycroft/skills/core.py:66:80: E501 line too long (93 > 79 characters)
./mycroft/skills/core.py:68:80: E501 line too long (88 > 79 characters)
./mycroft/skills/core.py:77:80: E501 line too long (81 > 79 characters)
./mycroft/skills/core.py:97:80: E501 line too long (91 > 79 characters)
./mycroft/skills/core.py:103:80: E501 line too long (100 > 79 characters)
./mycroft/skills/core.py:137:80: E501 line too long (87 > 79 characters)
./mycroft/skills/core.py:158:80: E501 line too long (90 > 79 characters)
./mycroft/skills/core.py:159:80: E501 line too long (107 > 79 characters)
./mycroft/skills/core.py:164:80: E501 line too long (100 > 79 characters)
./mycroft/skills/core.py:168:80: E501 line too long (83 > 79 characters)
./mycroft/skills/core.py:177:80: E501 line too long (93 > 79 characters)
./mycroft/skills/wiki/__init__.py:23:80: E501 line too long (121 > 79 characters)
./mycroft/skills/wiki/__init__.py:24:80: E501 line too long (121 > 79 characters)
./mycroft/skills/wiki/__init__.py:29:80: E501 line too long (110 > 79 characters)
./mycroft/skills/wiki/__init__.py:32:80: E501 line too long (109 > 79 characters)
./mycroft/skills/wiki/__init__.py:44:80: E501 line too long (98 > 79 characters)
./mycroft/skills/wiki/__init__.py:58:80: E501 line too long (81 > 79 characters)
./mycroft/skills/desktop_launcher/__init__.py:60:80: E501 line too long (99 > 79 characters)
./mycroft/skills/desktop_launcher/__init__.py:64:80: E501 line too long (120 > 79 characters)
./mycroft/skills/desktop_launcher/__init__.py:67:80: E501 line too long (114 > 79 characters)
./mycroft/skills/npr_news/__init__.py:25:80: E501 line too long (81 > 79 characters)
./mycroft/skills/alarm/__init__.py:26:80: E501 line too long (86 > 79 characters)
./mycroft/skills/intent/__init__.py:25:80: E501 line too long (92 > 79 characters)
./mycroft/skills/intent/__init__.py:26:80: E501 line too long (88 > 79 characters)
./mycroft/skills/intent/__init__.py:31:80: E501 line too long (87 > 79 characters)
./mycroft/skills/intent/__init__.py:34:80: E501 line too long (95 > 79 characters)
./mycroft/skills/intent/__init__.py:36:80: E501 line too long (109 > 79 characters)
./mycroft/skills/intent/__init__.py:46:80: E501 line too long (86 > 79 characters)
./mycroft/skills/intent/__init__.py:54:80: E501 line too long (86 > 79 characters)
./mycroft/skills/volume/__init__.py:15:80: E501 line too long (100 > 79 characters)
./mycroft/skills/volume/__init__.py:27:80: E501 line too long (106 > 79 characters)
./mycroft/skills/volume/__init__.py:30:80: E501 line too long (95 > 79 characters)
./mycroft/skills/volume/__init__.py:33:80: E501 line too long (95 > 79 characters)
./mycroft/skills/volume/__init__.py:36:80: E501 line too long (87 > 79 characters)
./mycroft/skills/volume/__init__.py:39:80: E501 line too long (89 > 79 characters)
./mycroft/skills/volume/__init__.py:63:80: E501 line too long (101 > 79 characters)
./mycroft/skills/reminder/__init__.py:16:80: E501 line too long (119 > 79 characters)
./mycroft/skills/reminder/__init__.py:19:80: E501 line too long (85 > 79 characters)
./mycroft/skills/reminder/__init__.py:27:80: E501 line too long (92 > 79 characters)
./mycroft/skills/reminder/__init__.py:60:80: E501 line too long (101 > 79 characters)
./mycroft/skills/reminder/__init__.py:81:80: E501 line too long (90 > 79 characters)
./mycroft/skills/dial_call/__init__.py:15:80: E501 line too long (93 > 79 characters)
./mycroft/skills/dial_call/__init__.py:16:80: E501 line too long (108 > 79 characters)
./mycroft/skills/dial_call/__init__.py:20:80: E501 line too long (106 > 79 characters)
./mycroft/skills/dial_call/__init__.py:28:80: E501 line too long (102 > 79 characters)
./mycroft/skills/dial_call/__init__.py:54:80: E501 line too long (96 > 79 characters)
./mycroft/skills/spelling/__init__.py:17:80: E501 line too long (85 > 79 characters)
./mycroft/skills/spelling/__init__.py:20:80: E501 line too long (99 > 79 characters)
./mycroft/skills/weather/owm_repackaged/configuration25_mycroft.py:66:5: E122 continuation line missing indentation or outdented
./mycroft/skills/weather/owm_repackaged/configuration25_mycroft.py:98:5: E122 continuation line missing indentation or outdented
./mycroft/skills/weather/owm_repackaged/configuration25_mycroft.py:106:5: E122 continuation line missing indentation or outdented
./mycroft/skills/weather/owm_repackaged/configuration25_mycroft.py:114:5: E122 continuation line missing indentation or outdented
./mycroft/skills/weather/owm_repackaged/owm25.py:35:80: E501 line too long (80 > 79 characters)
./mycroft/skills/weather/owm_repackaged/owm25.py:47:80: E501 line too long (80 > 79 characters)
./mycroft/skills/weather/owm_repackaged/owm25.py:54:80: E501 line too long (80 > 79 characters)
./mycroft/skills/weather/owm_repackaged/owm25.py:117:80: E501 line too long (80 > 79 characters)
./mycroft/skills/weather/owm_repackaged/owm25.py:153:43: E128 continuation line under-indented for visual indent
./mycroft/skills/weather/owm_repackaged/owm25.py:153:53: E231 missing whitespace after ','
./mycroft/skills/weather/owm_repackaged/owm25.py:243:80: E501 line too long (80 > 79 characters)
./mycroft/skills/weather/owm_repackaged/owm25.py:275:80: E501 line too long (80 > 79 characters)
./mycroft/skills/weather/owm_repackaged/owm25.py:294:17: E127 continuation line over-indented for visual indent
./mycroft/skills/weather/owm_repackaged/owm25.py:296:17: E127 continuation line over-indented for visual indent
./mycroft/skills/weather/owm_repackaged/owm25.py:298:17: E127 continuation line over-indented for visual indent
./mycroft/skills/weather/owm_repackaged/owm25.py:300:17: E127 continuation line over-indented for visual indent
./mycroft/skills/weather/owm_repackaged/owm25.py:303:17: E127 continuation line over-indented for visual indent
./mycroft/skills/weather/owm_repackaged/owm25.py:307:78: E502 the backslash is redundant between brackets
./mycroft/skills/weather/owm_repackaged/owm25.py:308:31: E225 missing whitespace around operator
./mycroft/skills/weather/owm_repackaged/owm25.py:310:77: E502 the backslash is redundant between brackets
./mycroft/skills/weather/owm_repackaged/owm25.py:311:31: E225 missing whitespace around operator
./mycroft/skills/weather/owm_repackaged/owm25.py:313:78: E502 the backslash is redundant between brackets
./mycroft/skills/weather/owm_repackaged/owm25.py:314:31: E225 missing whitespace around operator
./mycroft/skills/weather/owm_repackaged/owm25.py:321:56: E231 missing whitespace after ','
./mycroft/skills/weather/owm_repackaged/owm25.py:380:43: E128 continuation line under-indented for visual indent
./mycroft/skills/weather/owm_repackaged/owm25.py:490:80: E501 line too long (80 > 79 characters)
./mycroft/skills/weather/owm_repackaged/owm25.py:571:5: E303 too many blank lines (2)
./mycroft/skills/weather/owm_repackaged/owm25.py:605:73: E502 the backslash is redundant between brackets
./mycroft/skills/weather/owm_repackaged/owm25.py:609:73: E502 the backslash is redundant between brackets
./mycroft/skills/weather/owm_repackaged/owm25.py:614:76: E502 the backslash is redundant between brackets
./mycroft/skills/weather/owm_repackaged/owm25.py:656:73: E502 the backslash is redundant between brackets
./mycroft/skills/weather/owm_repackaged/owm25.py:660:73: E502 the backslash is redundant between brackets
./mycroft/skills/weather/owm_repackaged/owm25.py:665:76: E502 the backslash is redundant between brackets
./mycroft/skills/weather/owm_repackaged/owm25.py:828:39: E128 continuation line under-indented for visual indent
./mycroft/skills/weather/owm_repackaged/owm25.py:829:39: E128 continuation line under-indented for visual indent
./mycroft/skills/weather/owm_repackaged/owm25.py:830:39: E128 continuation line under-indented for visual indent
./mycroft/skills/weather/owm_repackaged/owm25.py:831:39: E128 continuation line under-indented for visual indent
./mycroft/skills/weather/owm_repackaged/__init__.py:35:80: E501 line too long (80 > 79 characters)
./mycroft/skills/weather/owm_repackaged/__init__.py:44:80: E501 line too long (91 > 79 characters)
./mycroft/skills/weather/owm_repackaged/owmhttpclient.py:60:80: E501 line too long (107 > 79 characters)
./mycroft/skills/weather/owm_repackaged/owmhttpclient.py:67:80: E501 line too long (84 > 79 characters)
./mycroft/skills/weather/owm_repackaged/owmhttpclient.py:72:80: E501 line too long (84 > 79 characters)
./mycroft/skills/weather/__init__.py:22:80: E501 line too long (92 > 79 characters)
./mycroft/skills/weather/__init__.py:33:80: E501 line too long (111 > 79 characters)
./mycroft/skills/weather/__init__.py:37:80: E501 line too long (107 > 79 characters)
./mycroft/skills/weather/__init__.py:42:80: E501 line too long (105 > 79 characters)
./mycroft/skills/weather/__init__.py:69:80: E501 line too long (94 > 79 characters)
./mycroft/skills/weather/__init__.py:80:80: E501 line too long (88 > 79 characters)
./mycroft/skills/weather/__init__.py:81:80: E501 line too long (86 > 79 characters)
./mycroft/skills/weather/__init__.py:88:80: E501 line too long (111 > 79 characters)
./mycroft/skills/cerberus_config/__init__.py:31:33: W292 no newline at end of file
./mycroft/skills/pairing/__init__.py:15:80: E501 line too long (86 > 79 characters)
./mycroft/skills/pairing/__init__.py:24:80: E501 line too long (98 > 79 characters)
./mycroft/skills/pairing/__init__.py:27:5: E303 too many blank lines (2)
./mycroft/skills/send_sms/__init__.py:15:80: E501 line too long (93 > 79 characters)
./mycroft/skills/send_sms/__init__.py:16:80: E501 line too long (110 > 79 characters)
./mycroft/skills/send_sms/__init__.py:20:80: E501 line too long (106 > 79 characters)
./mycroft/skills/send_sms/__init__.py:26:80: E501 line too long (84 > 79 characters)
./mycroft/skills/send_sms/__init__.py:28:80: E501 line too long (119 > 79 characters)
./mycroft/skills/send_sms/__init__.py:56:80: E501 line too long (111 > 79 characters)
./mycroft/skills/container.py:20:80: E501 line too long (87 > 79 characters)
./mycroft/skills/container.py:21:80: E501 line too long (97 > 79 characters)
./mycroft/skills/container.py:23:80: E501 line too long (88 > 79 characters)
./mycroft/skills/container.py:24:80: E501 line too long (81 > 79 characters)
./mycroft/skills/time_rules.py:30:80: E501 line too long (83 > 79 characters)
./mycroft/skills/time_rules.py:31:80: E501 line too long (93 > 79 characters)
./mycroft/skills/time_rules.py:37:80: E501 line too long (80 > 79 characters)
./mycroft/skills/time_rules.py:66:80: E501 line too long (84 > 79 characters)
./mycroft/skills/time_rules.py:67:80: E501 line too long (110 > 79 characters)
./mycroft/skills/time_rules.py:68:80: E501 line too long (98 > 79 characters)
./mycroft/skills/time_rules.py:71:80: E501 line too long (110 > 79 characters)
./mycroft/skills/time_rules.py:73:80: E501 line too long (85 > 79 characters)
./mycroft/skills/time_rules.py:74:80: E501 line too long (95 > 79 characters)
./mycroft/skills/time_rules.py:75:80: E501 line too long (104 > 79 characters)
./mycroft/skills/time_rules.py:77:80: E501 line too long (102 > 79 characters)
./mycroft/skills/time_rules.py:78:80: E501 line too long (114 > 79 characters)
./mycroft/skills/time_rules.py:86:80: E501 line too long (93 > 79 characters)
./mycroft/skills/scheduled_skills.py:17:80: E501 line too long (90 > 79 characters)
./mycroft/skills/scheduled_skills.py:19:80: E501 line too long (97 > 79 characters)
./mycroft/skills/scheduled_skills.py:56:80: E501 line too long (94 > 79 characters)
./mycroft/skills/scheduled_skills.py:69:80: E501 line too long (95 > 79 characters)
./mycroft/skills/scheduled_skills.py:71:80: E501 line too long (89 > 79 characters)
./mycroft/skills/scheduled_skills.py:73:80: E501 line too long (117 > 79 characters)
./mycroft/skills/scheduled_skills.py:99:80: E501 line too long (84 > 79 characters)
./mycroft/skills/scheduled_skills.py:100:80: E501 line too long (80 > 79 characters)
./mycroft/skills/scheduled_skills.py:101:80: E501 line too long (84 > 79 characters)
./mycroft/skills/scheduled_skills.py:113:80: E501 line too long (90 > 79 characters)
./mycroft/skills/scheduled_skills.py:116:80: E501 line too long (88 > 79 characters)
./mycroft/skills/scheduled_skills.py:120:80: E501 line too long (92 > 79 characters)
./mycroft/skills/scheduled_skills.py:139:80: E501 line too long (88 > 79 characters)
./mycroft/skills/scheduled_skills.py:196:80: E501 line too long (86 > 79 characters)
./mycroft/skills/scheduled_skills.py:225:80: E501 line too long (80 > 79 characters)
./mycroft/skills/naptime/__init__.py:16:80: E501 line too long (86 > 79 characters)
./mycroft/skills/ip_skill/__init__.py:24:80: E501 line too long (113 > 79 characters)
./mycroft/skills/ip_skill/__init__.py:26:80: E501 line too long (108 > 79 characters)
./mycroft/skills/wolfram_alpha/__init__.py:21:80: E501 line too long (118 > 79 characters)
./mycroft/skills/wolfram_alpha/__init__.py:27:80: E501 line too long (140 > 79 characters)
./mycroft/skills/wolfram_alpha/__init__.py:28:80: E501 line too long (111 > 79 characters)
./mycroft/skills/wolfram_alpha/__init__.py:38:80: E501 line too long (85 > 79 characters)
./mycroft/skills/wolfram_alpha/__init__.py:88:80: E501 line too long (87 > 79 characters)
./mycroft/skills/wolfram_alpha/__init__.py:99:80: E501 line too long (137 > 79 characters)
./mycroft/skills/wolfram_alpha/__init__.py:118:80: E501 line too long (80 > 79 characters)
./mycroft/skills/wolfram_alpha/__init__.py:128:80: E501 line too long (99 > 79 characters)
./mycroft/skills/date_time/__init__.py:26:80: E501 line too long (98 > 79 characters)
./mycroft/skills/date_time/__init__.py:46:80: E501 line too long (88 > 79 characters)
./mycroft/skills/audio_record/__init__.py:34:80: E501 line too long (99 > 79 characters)
./mycroft/skills/audio_record/__init__.py:37:80: E501 line too long (98 > 79 characters)
./mycroft/skills/audio_record/__init__.py:41:80: E501 line too long (98 > 79 characters)
./mycroft/skills/audio_record/__init__.py:45:80: E501 line too long (102 > 79 characters)
./mycroft/skills/audio_record/__init__.py:46:80: E501 line too long (91 > 79 characters)
./mycroft/skills/audio_record/__init__.py:58:80: E501 line too long (97 > 79 characters)
./mycroft/skills/audio_record/__init__.py:79:80: E501 line too long (89 > 79 characters)
./mycroft/metrics/__init__.py:15:1: E302 expected 2 blank lines, found 1
./mycroft/metrics/__init__.py:80:80: E501 line too long (90 > 79 characters)
./mycroft/metrics/__init__.py:83:13: E301 expected 1 blank line, found 0
./mycroft/metrics/__init__.py:100:80: E501 line too long (120 > 79 characters)
./mycroft/dialog/__init__.py:41:80: E501 line too long (87 > 79 characters)
./mycroft/dialog/__init__.py:47:80: E501 line too long (81 > 79 characters)
./mycroft/dialog/__init__.py:49:80: E501 line too long (92 > 79 characters)
./mycroft/dialog/__init__.py:56:18: E711 comparison to None should be 'if cond is None:'
./mycroft/dialog/__init__.py:82:80: E501 line too long (111 > 79 characters)
./mycroft/dialog/__init__.py:84:80: E501 line too long (94 > 79 characters)
./mycroft/dialog/__init__.py:88:1: W391 blank line at end of file
./mycroft/filesystem/__init__.py:9:80: E501 line too long (93 > 79 characters)
./mycroft/filesystem/__init__.py:27:80: E501 line too long (92 > 79 characters)
./mycroft/filesystem/__init__.py:29:80: E501 line too long (110 > 79 characters)
./mycroft/util/setup_base.py:11:1: E302 expected 2 blank lines, found 1
./mycroft/util/setup_base.py:14:1: E302 expected 2 blank lines, found 1
./mycroft/util/setup_base.py:21:80: E501 line too long (103 > 79 characters)
./mycroft/util/setup_base.py:36:80: E501 line too long (88 > 79 characters)
./mycroft/util/setup_base.py:36:89: W292 no newline at end of file
./mycroft/util/log.py:3:1: E402 module level import not at top of file
./mycroft/util/audio_test.py:9:80: E501 line too long (109 > 79 characters)
./mycroft/util/audio_test.py:25:80: E501 line too long (143 > 79 characters)
./mycroft/util/audio_test.py:26:80: E501 line too long (137 > 79 characters)
./mycroft/util/__init__.py:24:80: E501 line too long (114 > 79 characters)
./mycroft/util/__init__.py:26:80: E501 line too long (93 > 79 characters)
./mycroft/util/__init__.py:69:1: E302 expected 2 blank lines, found 1
./mycroft/util/__init__.py:70:9: W292 no newline at end of file
./mycroft/configuration/config.py:13:80: E501 line too long (83 > 79 characters)
./mycroft/configuration/config.py:15:80: E501 line too long (80 > 79 characters)
./mycroft/configuration/config.py:38:80: E501 line too long (90 > 79 characters)
./mycroft/configuration/config.py:48:80: E501 line too long (80 > 79 characters)
./mycroft/configuration/config.py:51:80: E501 line too long (80 > 79 characters)
./mycroft/configuration/config.py:73:80: E501 line too long (86 > 79 characters)
./mycroft/configuration/config.py:75:80: E501 line too long (89 > 79 characters)
./mycroft/configuration/config.py:77:80: E501 line too long (98 > 79 characters)
./mycroft/configuration/config.py:81:80: E501 line too long (85 > 79 characters)
./mycroft/configuration/config.py:83:80: E501 line too long (96 > 79 characters)
./mycroft/configuration/config.py:84:80: E501 line too long (136 > 79 characters)
./mycroft/configuration/config.py:86:80: E501 line too long (82 > 79 characters)
./mycroft/configuration/config.py:89:80: E501 line too long (84 > 79 characters)
./mycroft/configuration/config.py:104:80: E501 line too long (91 > 79 characters)

Komentar yang paling membantu

Kode juga membutuhkan komentar. Silakan, untuk semua kode baru (dan yang lama), beri komentar. Akan lebih mudah bagi pengembang baru untuk membantu Anda.

Semua 15 komentar

Jelas item 3 tidak dan tidak boleh menjadi tujuan langsung untuk Mycroft saat Anda menerapkan di Ubuntu sekarang, dan kontribusi komunitas harus menyelesaikannya. Namun masalah lainnya jelas merupakan masalah besar yang termasuk dalam domain pengembang Mycroft.

Hei Ikey, terima kasih telah membuka ini! Saya akan menjadi orang pertama yang mengakui bahwa Mycroft-core tidak mendapatkan pembersihan penuh kasih yang sama seperti yang didapat Adapt sebelum dirilis. Saya akan merekomendasikan untuk membuka masing-masing masalah github yang terpisah ini (dan jangan ragu untuk tetap membukanya sebagai tiket uber) untuk diserang secara independen.

Khususnya pada masalah pep8, setelah kami berada dalam kondisi yang baik, saya akan dengan senang hati menambahkan validasi pep8 ke pembuat travis kami untuk memastikan semuanya tetap bersih.

Terima kasih lagi!

Jangan khawatir - lakukan saja bagian saya saat saya melihatnya baru saja diluncurkan :)

Ya Ikey, terima kasih telah memunculkan ini di pelacak masalah! Kami sudah cukup kepala turun mencoba untuk mendapatkan ini keluar dari pintu! Kami dapat menggunakan umpan balik Anda dan bahkan beberapa komitmen jika Anda siap untuk membantu kami! Saya ingin memunculkan repo Mycroft-Solus-Desktop atau sesuatu, untuk mengaktifkannya sebagai plugin untuk desktop atau sesuatu (bahkan mungkin menampilkan jawaban di sidebar seksi yang kalian miliki!

@ryanleesipes Plugin Raven sebenarnya adalah konsep yang sangat menarik. Budgie menggunakan libpeas yang mendukung plugin Python, namun hanya Python 3, saya harus menyelesaikannya. Saya bingung mengapa Mycroft tidak menggunakan Python 3?

Kode juga membutuhkan komentar. Silakan, untuk semua kode baru (dan yang lama), beri komentar. Akan lebih mudah bagi pengembang baru untuk membantu Anda.

Saya sedang mengerjakan beberapa kemasan deb untuk Debian, Ubunutu, dan Raspian

Adakah yang mau mencoba paket build untuk Arch? Saya akan sangat tertarik dengan itu.

@ikeydoherty dapatkah Anda memberikan umpan balik tentang bagaimana kami dapat berkembang melampaui visi terowongan kami? Saya sedang melihat detail instalasi di distro lain (mis. Fedora, Arch). Di luar itu, apa yang berguna untuk mengatasi hal ini?

Sepertinya akan sangat mudah untuk menulis AUR yang akan menginstal dependensi Mycroft, memeriksa kode dari Github, membangunnya, dan membuat paket. Ini telah dilakukan dengan Mimic (https://aur.archlinux.org/packages/mimic-git).

Ya, saya pikir itu. Saya sudah lama tidak menjalankan arch, jadi saya tidak punya host untuk bekerja saat ini.

Akan mencoba beberapa rpm segera saya pikir, mungkin waktu luang. Oh ya, dan jepret. Biarkan build untuk setiap manajer paket;) Juga, ya, sistem build kami agak funky, tetapi ini sebagian besar disebabkan oleh fakta bahwa kami menargetkan perangkat terlebih dahulu. Saya benar-benar hampir memisahkan barang-barang itu, saya pikir, beberapa hari lagi mungkin. Saya juga sedang mengerjakan repo yang tepat, tetapi saya berencana untuk memasukkan beberapa sumber deb ke launchpad.net juga.

Saya tahu beberapa dari kalian di luar sana sangat pandai dalam hal ini, saya akan sangat menghargai tips apa pun!

Anda menargetkan perangkat terlebih dahulu, tetapi seperti yang saya pahami, Anda menargetkan perangkat yang menjalankan Raspbian, yaitu Debian (agak agak, Proyek Debian itu sendiri mungkin memperdebatkannya, tetapi apa pun) yang berjalan pada RPi. Membangun paket .deb pertama-tama sangat masuk akal (kemudian Anda bisa memasukkannya ke dalam repo terpisah) dan kemudian menggunakan teknik pembuatan otomatis yang dipelajari di sana untuk membangun paket .rpm, paket .tar.xz, dan seterusnya.

Adapun tips, ketika saya sedang mengerjakan distro beberapa tahun yang lalu kami memiliki skrip shell di repositori kode kami yang sadar distro, yaitu, kami dapat menjalankan makepackage debian control_panel dan itu akan membangun paket yang sesuai jika itu sedang berjalan pada sistem Debian atau apa pun.

@ethanaward dapatkah Anda menambahkan daftar paket yang Anda tambahkan ke situs dokumen ke README juga?

Paket-paket yang diperlukan yang dirinci dalam README, juga akan ada build_host_setup yang dibuat ulang yang menargetkan Arch, Debian, dan Fedora segera (oleh Anda benar-benar)!

Apakah halaman ini membantu?
0 / 5 - 0 peringkat

Masalah terkait

KathyReid picture KathyReid  ·  8Komentar

mghoffmann picture mghoffmann  ·  6Komentar

Zacki84 picture Zacki84  ·  10Komentar

tmajibon picture tmajibon  ·  9Komentar

damorosodaragona picture damorosodaragona  ·  5Komentar