Ipython: Deep reload throws a NonImplementedError

Hum, types and deeprelaod are pretty dark magic. We likely need to blacklist some modules.

Do you want to attempt a PR ?

Do you want to attempt a PR ?

Sorry, I have no idea what's going on there.

Sorry, I have no idea what's going on there.

No worries. We'll have a look ! Thanks.

@Carreau, I am still seeing this issue in 6.1.0 even though types should have been excluded explicitly as in your #10318. Any thoughts? My python version is 3.6.2.

I'm also seeing this still in 6.2.1

Hum, happy to reopen, but I can't reproduce on a fresh install, so I'll have issues to debug :

$ ipython
Python 3.6.3 | packaged by conda-forge | (default, Oct  5 2017, 19:18:17)
Type 'copyright', 'credits' or 'license' for more information
IPython 6.2.1 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import types

In [2]: from IPython.lib.deepreload import reload

In [3]: reload(types)
Out[3]: <module 'types' from '/Users/bussonniermatthias/anaconda/lib/python3.6/types.py'>

Do you both have the exact same traceback ?

The example you provide actually works fine for me. However, I can't reload other packages (e.g. json):

Python 3.6.2 (default, Jul 24 2017, 19:47:39) 
Type 'copyright', 'credits' or 'license' for more information
IPython 6.2.1 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import json

In [2]: from IPython.lib.deepreload import reload

In [3]: reload(json)
Reloading json.decoder
Reloading re
Reloading enum
Reloading types
Reloading functools
Reloading _functools
Reloading abc
Reloading _weakrefset
Reloading _weakref
Reloading collections
Reloading _collections_abc
Reloading operator
Reloading _operator
Reloading keyword
Reloading heapq
Reloading _heapq
Reloading importlib
Reloading _imp
Reloading _frozen_importlib
Reloading _frozen_importlib_external
Reloading warnings
---------------------------------------------------------------------------
NotImplementedError                       Traceback (most recent call last)
<ipython-input-3-9009d350791b> in <module>()
----> 1 reload(json)

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in reload(module, exclude)
    343     try:
    344         with replace_import_hook(deep_import_hook):
--> 345             return deep_reload_hook(module)
    346     finally:
    347         found_now = {}

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in deep_reload_hook(m)
    315 
    316     try:
--> 317         newm = imp.load_module(name, fp, filename, stuff)
    318     except:
    319          # load_module probably removed name from modules because of

/usr/local/lib/python3.6/imp.py in load_module(name, file, filename, details)
    242             return load_dynamic(name, filename, file)
    243     elif type_ == PKG_DIRECTORY:
--> 244         return load_package(name, filename)
    245     elif type_ == C_BUILTIN:
    246         return init_builtin(name)

/usr/local/lib/python3.6/imp.py in load_package(name, path)
    212                                         submodule_search_locations=[])
    213     if name in sys.modules:
--> 214         return _exec(spec, sys.modules[name])
    215     else:
    216         return _load(spec)

/usr/local/lib/python3.6/importlib/_bootstrap.py in _exec(spec, module)

/usr/local/lib/python3.6/importlib/_bootstrap_external.py in exec_module(self, module)

/usr/local/lib/python3.6/importlib/_bootstrap.py in _call_with_frames_removed(f, *args, **kwds)

/usr/local/lib/python3.6/json/__init__.py in <module>()
    104 __author__ = 'Bob Ippolito <[email protected]>'
    105 
--> 106 from .decoder import JSONDecoder, JSONDecodeError
    107 from .encoder import JSONEncoder
    108 import codecs

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in deep_import_hook(name, globals, locals, fromlist, level)
    250     parent, buf = get_parent(globals, level)
    251 
--> 252     head, name, buf = load_next(parent, None if level < 0 else parent, name, buf)
    253 
    254     tail = head

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in load_next(mod, altmod, name, buf)
    153     buf += subname
    154 
--> 155     result = import_submodule(mod, subname, buf)
    156     if result is None and mod != altmod:
    157         result = import_submodule(altmod, subname, subname)

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in import_submodule(mod, subname, fullname)
    199 
    200         try:
--> 201             m = imp.load_module(fullname, fp, filename, stuff)
    202         except:
    203             # load_module probably removed name from modules because of

/usr/local/lib/python3.6/imp.py in load_module(name, file, filename, details)
    232         raise ValueError(msg)
    233     elif type_ == PY_SOURCE:
--> 234         return load_source(name, filename, file)
    235     elif type_ == PY_COMPILED:
    236         return load_compiled(name, filename, file)

/usr/local/lib/python3.6/imp.py in load_source(name, pathname, file)
    168     spec = util.spec_from_file_location(name, pathname, loader=loader)
    169     if name in sys.modules:
--> 170         module = _exec(spec, sys.modules[name])
    171     else:
    172         module = _load(spec)

/usr/local/lib/python3.6/importlib/_bootstrap.py in _exec(spec, module)

/usr/local/lib/python3.6/importlib/_bootstrap_external.py in exec_module(self, module)

/usr/local/lib/python3.6/importlib/_bootstrap.py in _call_with_frames_removed(f, *args, **kwds)

/usr/local/lib/python3.6/json/decoder.py in <module>()
      1 """Implementation of JSONDecoder
      2 """
----> 3 import re
      4 
      5 from json import scanner

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in deep_import_hook(name, globals, locals, fromlist, level)
    250     parent, buf = get_parent(globals, level)
    251 
--> 252     head, name, buf = load_next(parent, None if level < 0 else parent, name, buf)
    253 
    254     tail = head

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in load_next(mod, altmod, name, buf)
    153     buf += subname
    154 
--> 155     result = import_submodule(mod, subname, buf)
    156     if result is None and mod != altmod:
    157         result = import_submodule(altmod, subname, subname)

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in import_submodule(mod, subname, fullname)
    199 
    200         try:
--> 201             m = imp.load_module(fullname, fp, filename, stuff)
    202         except:
    203             # load_module probably removed name from modules because of

/usr/local/lib/python3.6/imp.py in load_module(name, file, filename, details)
    232         raise ValueError(msg)
    233     elif type_ == PY_SOURCE:
--> 234         return load_source(name, filename, file)
    235     elif type_ == PY_COMPILED:
    236         return load_compiled(name, filename, file)

/usr/local/lib/python3.6/imp.py in load_source(name, pathname, file)
    168     spec = util.spec_from_file_location(name, pathname, loader=loader)
    169     if name in sys.modules:
--> 170         module = _exec(spec, sys.modules[name])
    171     else:
    172         module = _load(spec)

/usr/local/lib/python3.6/importlib/_bootstrap.py in _exec(spec, module)

/usr/local/lib/python3.6/importlib/_bootstrap_external.py in exec_module(self, module)

/usr/local/lib/python3.6/importlib/_bootstrap.py in _call_with_frames_removed(f, *args, **kwds)

/usr/local/lib/python3.6/re.py in <module>()
    120 """
    121 
--> 122 import enum
    123 import sre_compile
    124 import sre_parse

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in deep_import_hook(name, globals, locals, fromlist, level)
    250     parent, buf = get_parent(globals, level)
    251 
--> 252     head, name, buf = load_next(parent, None if level < 0 else parent, name, buf)
    253 
    254     tail = head

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in load_next(mod, altmod, name, buf)
    153     buf += subname
    154 
--> 155     result = import_submodule(mod, subname, buf)
    156     if result is None and mod != altmod:
    157         result = import_submodule(altmod, subname, subname)

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in import_submodule(mod, subname, fullname)
    199 
    200         try:
--> 201             m = imp.load_module(fullname, fp, filename, stuff)
    202         except:
    203             # load_module probably removed name from modules because of

/usr/local/lib/python3.6/imp.py in load_module(name, file, filename, details)
    232         raise ValueError(msg)
    233     elif type_ == PY_SOURCE:
--> 234         return load_source(name, filename, file)
    235     elif type_ == PY_COMPILED:
    236         return load_compiled(name, filename, file)

/usr/local/lib/python3.6/imp.py in load_source(name, pathname, file)
    168     spec = util.spec_from_file_location(name, pathname, loader=loader)
    169     if name in sys.modules:
--> 170         module = _exec(spec, sys.modules[name])
    171     else:
    172         module = _load(spec)

/usr/local/lib/python3.6/importlib/_bootstrap.py in _exec(spec, module)

/usr/local/lib/python3.6/importlib/_bootstrap_external.py in exec_module(self, module)

/usr/local/lib/python3.6/importlib/_bootstrap.py in _call_with_frames_removed(f, *args, **kwds)

/usr/local/lib/python3.6/enum.py in <module>()
      1 import sys
----> 2 from types import MappingProxyType, DynamicClassAttribute
      3 from functools import reduce
      4 from operator import or_ as _or_
      5 

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in deep_import_hook(name, globals, locals, fromlist, level)
    250     parent, buf = get_parent(globals, level)
    251 
--> 252     head, name, buf = load_next(parent, None if level < 0 else parent, name, buf)
    253 
    254     tail = head

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in load_next(mod, altmod, name, buf)
    153     buf += subname
    154 
--> 155     result = import_submodule(mod, subname, buf)
    156     if result is None and mod != altmod:
    157         result = import_submodule(altmod, subname, subname)

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in import_submodule(mod, subname, fullname)
    199 
    200         try:
--> 201             m = imp.load_module(fullname, fp, filename, stuff)
    202         except:
    203             # load_module probably removed name from modules because of

/usr/local/lib/python3.6/imp.py in load_module(name, file, filename, details)
    232         raise ValueError(msg)
    233     elif type_ == PY_SOURCE:
--> 234         return load_source(name, filename, file)
    235     elif type_ == PY_COMPILED:
    236         return load_compiled(name, filename, file)

/usr/local/lib/python3.6/imp.py in load_source(name, pathname, file)
    168     spec = util.spec_from_file_location(name, pathname, loader=loader)
    169     if name in sys.modules:
--> 170         module = _exec(spec, sys.modules[name])
    171     else:
    172         module = _load(spec)

/usr/local/lib/python3.6/importlib/_bootstrap.py in _exec(spec, module)

/usr/local/lib/python3.6/importlib/_bootstrap_external.py in exec_module(self, module)

/usr/local/lib/python3.6/importlib/_bootstrap.py in _call_with_frames_removed(f, *args, **kwds)

/usr/local/lib/python3.6/types.py in <module>()
    169 
    170 
--> 171 import functools as _functools
    172 import collections.abc as _collections_abc
    173 

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in deep_import_hook(name, globals, locals, fromlist, level)
    250     parent, buf = get_parent(globals, level)
    251 
--> 252     head, name, buf = load_next(parent, None if level < 0 else parent, name, buf)
    253 
    254     tail = head

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in load_next(mod, altmod, name, buf)
    153     buf += subname
    154 
--> 155     result = import_submodule(mod, subname, buf)
    156     if result is None and mod != altmod:
    157         result = import_submodule(altmod, subname, subname)

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in import_submodule(mod, subname, fullname)
    199 
    200         try:
--> 201             m = imp.load_module(fullname, fp, filename, stuff)
    202         except:
    203             # load_module probably removed name from modules because of

/usr/local/lib/python3.6/imp.py in load_module(name, file, filename, details)
    232         raise ValueError(msg)
    233     elif type_ == PY_SOURCE:
--> 234         return load_source(name, filename, file)
    235     elif type_ == PY_COMPILED:
    236         return load_compiled(name, filename, file)

/usr/local/lib/python3.6/imp.py in load_source(name, pathname, file)
    168     spec = util.spec_from_file_location(name, pathname, loader=loader)
    169     if name in sys.modules:
--> 170         module = _exec(spec, sys.modules[name])
    171     else:
    172         module = _load(spec)

/usr/local/lib/python3.6/importlib/_bootstrap.py in _exec(spec, module)

/usr/local/lib/python3.6/importlib/_bootstrap_external.py in exec_module(self, module)

/usr/local/lib/python3.6/importlib/_bootstrap.py in _call_with_frames_removed(f, *args, **kwds)

/usr/local/lib/python3.6/functools.py in <module>()
     19     pass
     20 from abc import get_cache_token
---> 21 from collections import namedtuple
     22 from types import MappingProxyType
     23 from weakref import WeakKeyDictionary

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in deep_import_hook(name, globals, locals, fromlist, level)
    250     parent, buf = get_parent(globals, level)
    251 
--> 252     head, name, buf = load_next(parent, None if level < 0 else parent, name, buf)
    253 
    254     tail = head

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in load_next(mod, altmod, name, buf)
    153     buf += subname
    154 
--> 155     result = import_submodule(mod, subname, buf)
    156     if result is None and mod != altmod:
    157         result = import_submodule(altmod, subname, subname)

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in import_submodule(mod, subname, fullname)
    199 
    200         try:
--> 201             m = imp.load_module(fullname, fp, filename, stuff)
    202         except:
    203             # load_module probably removed name from modules because of

/usr/local/lib/python3.6/imp.py in load_module(name, file, filename, details)
    242             return load_dynamic(name, filename, file)
    243     elif type_ == PKG_DIRECTORY:
--> 244         return load_package(name, filename)
    245     elif type_ == C_BUILTIN:
    246         return init_builtin(name)

/usr/local/lib/python3.6/imp.py in load_package(name, path)
    212                                         submodule_search_locations=[])
    213     if name in sys.modules:
--> 214         return _exec(spec, sys.modules[name])
    215     else:
    216         return _load(spec)

/usr/local/lib/python3.6/importlib/_bootstrap.py in _exec(spec, module)

/usr/local/lib/python3.6/importlib/_bootstrap_external.py in exec_module(self, module)

/usr/local/lib/python3.6/importlib/_bootstrap.py in _call_with_frames_removed(f, *args, **kwds)

/usr/local/lib/python3.6/collections/__init__.py in <module>()
     27 from keyword import iskeyword as _iskeyword
     28 import sys as _sys
---> 29 import heapq as _heapq
     30 from _weakref import proxy as _proxy
     31 from itertools import repeat as _repeat, chain as _chain, starmap as _starmap

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in deep_import_hook(name, globals, locals, fromlist, level)
    250     parent, buf = get_parent(globals, level)
    251 
--> 252     head, name, buf = load_next(parent, None if level < 0 else parent, name, buf)
    253 
    254     tail = head

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in load_next(mod, altmod, name, buf)
    153     buf += subname
    154 
--> 155     result = import_submodule(mod, subname, buf)
    156     if result is None and mod != altmod:
    157         result = import_submodule(altmod, subname, subname)

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in import_submodule(mod, subname, fullname)
    199 
    200         try:
--> 201             m = imp.load_module(fullname, fp, filename, stuff)
    202         except:
    203             # load_module probably removed name from modules because of

/usr/local/lib/python3.6/imp.py in load_module(name, file, filename, details)
    232         raise ValueError(msg)
    233     elif type_ == PY_SOURCE:
--> 234         return load_source(name, filename, file)
    235     elif type_ == PY_COMPILED:
    236         return load_compiled(name, filename, file)

/usr/local/lib/python3.6/imp.py in load_source(name, pathname, file)
    168     spec = util.spec_from_file_location(name, pathname, loader=loader)
    169     if name in sys.modules:
--> 170         module = _exec(spec, sys.modules[name])
    171     else:
    172         module = _load(spec)

/usr/local/lib/python3.6/importlib/_bootstrap.py in _exec(spec, module)

/usr/local/lib/python3.6/importlib/_bootstrap_external.py in exec_module(self, module)

/usr/local/lib/python3.6/importlib/_bootstrap.py in _call_with_frames_removed(f, *args, **kwds)

/usr/local/lib/python3.6/heapq.py in <module>()
    585 # If available, use C implementation
    586 try:
--> 587     from _heapq import *
    588 except ImportError:
    589     pass

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in deep_import_hook(name, globals, locals, fromlist, level)
    250     parent, buf = get_parent(globals, level)
    251 
--> 252     head, name, buf = load_next(parent, None if level < 0 else parent, name, buf)
    253 
    254     tail = head

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in load_next(mod, altmod, name, buf)
    153     buf += subname
    154 
--> 155     result = import_submodule(mod, subname, buf)
    156     if result is None and mod != altmod:
    157         result = import_submodule(altmod, subname, subname)

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in import_submodule(mod, subname, fullname)
    199 
    200         try:
--> 201             m = imp.load_module(fullname, fp, filename, stuff)
    202         except:
    203             # load_module probably removed name from modules because of

/usr/local/lib/python3.6/imp.py in load_module(name, file, filename, details)
    240                 return load_dynamic(name, filename, opened_file)
    241         else:
--> 242             return load_dynamic(name, filename, file)
    243     elif type_ == PKG_DIRECTORY:
    244         return load_package(name, filename)

/usr/local/lib/python3.6/imp.py in load_dynamic(name, path, file)
    333         Load an extension module.
    334         """
--> 335         import importlib.machinery
    336         loader = importlib.machinery.ExtensionFileLoader(name, path)
    337 

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in deep_import_hook(name, globals, locals, fromlist, level)
    250     parent, buf = get_parent(globals, level)
    251 
--> 252     head, name, buf = load_next(parent, None if level < 0 else parent, name, buf)
    253 
    254     tail = head

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in load_next(mod, altmod, name, buf)
    153     buf += subname
    154 
--> 155     result = import_submodule(mod, subname, buf)
    156     if result is None and mod != altmod:
    157         result = import_submodule(altmod, subname, subname)

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in import_submodule(mod, subname, fullname)
    199 
    200         try:
--> 201             m = imp.load_module(fullname, fp, filename, stuff)
    202         except:
    203             # load_module probably removed name from modules because of

/usr/local/lib/python3.6/imp.py in load_module(name, file, filename, details)
    242             return load_dynamic(name, filename, file)
    243     elif type_ == PKG_DIRECTORY:
--> 244         return load_package(name, filename)
    245     elif type_ == C_BUILTIN:
    246         return init_builtin(name)

/usr/local/lib/python3.6/imp.py in load_package(name, path)
    212                                         submodule_search_locations=[])
    213     if name in sys.modules:
--> 214         return _exec(spec, sys.modules[name])
    215     else:
    216         return _load(spec)

/usr/local/lib/python3.6/importlib/_bootstrap.py in _exec(spec, module)

/usr/local/lib/python3.6/importlib/_bootstrap_external.py in exec_module(self, module)

/usr/local/lib/python3.6/importlib/_bootstrap.py in _call_with_frames_removed(f, *args, **kwds)

/usr/local/lib/python3.6/importlib/__init__.py in <module>()
     56 
     57 import types
---> 58 import warnings
     59 
     60 

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in deep_import_hook(name, globals, locals, fromlist, level)
    250     parent, buf = get_parent(globals, level)
    251 
--> 252     head, name, buf = load_next(parent, None if level < 0 else parent, name, buf)
    253 
    254     tail = head

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in load_next(mod, altmod, name, buf)
    153     buf += subname
    154 
--> 155     result = import_submodule(mod, subname, buf)
    156     if result is None and mod != altmod:
    157         result = import_submodule(altmod, subname, subname)

/usr/local/lib/python3.6/site-packages/IPython/lib/deepreload.py in import_submodule(mod, subname, fullname)
    199 
    200         try:
--> 201             m = imp.load_module(fullname, fp, filename, stuff)
    202         except:
    203             # load_module probably removed name from modules because of

/usr/local/lib/python3.6/imp.py in load_module(name, file, filename, details)
    232         raise ValueError(msg)
    233     elif type_ == PY_SOURCE:
--> 234         return load_source(name, filename, file)
    235     elif type_ == PY_COMPILED:
    236         return load_compiled(name, filename, file)

/usr/local/lib/python3.6/imp.py in load_source(name, pathname, file)
    168     spec = util.spec_from_file_location(name, pathname, loader=loader)
    169     if name in sys.modules:
--> 170         module = _exec(spec, sys.modules[name])
    171     else:
    172         module = _load(spec)

/usr/local/lib/python3.6/importlib/_bootstrap.py in _exec(spec, module)

/usr/local/lib/python3.6/importlib/_bootstrap.py in _init_module_attrs(spec, module, override)

/usr/local/lib/python3.6/importlib/_bootstrap.py in cached(self)

NotImplementedError: 

I think we'll have to be smarter and auto exclude modules we can't deep reload and warn users they were not deep reloaded.

temporary solution: add deep level control to recursion. Use this code in startup folder, on linux is: ~/.ipython/profile_default/startup/
```from types import ModuleType
from autoreload import reload as r

def reload(module,level=0):
"""Recursively reload modules."""
r(module)
if level>0:
for attribute_name in dir(module):
attribute = getattr(module, attribute_name)
if type(attribute) is ModuleType:
reload(attribute,level-1)

I just ran into this issue as well while trying to use deepreload.reload

Same here (NotImplementedError on reloading types)

Python 3.6.4
IPython 6.4.0
macOS 10.13.2

I cannot reproduce this with types, but I can reproduce this by reloading deepreload itself.
Ubuntu 18.04.1 LTS
CPython 3.6.5
IPython 6.5.0