Ipython: test_embed_svg_url needs internet connection

Created on 4 May 2020  ·  3Comments  ·  Source: ipython/ipython

Hello.

This part of the test_embed_svg_url needs internet connection to download the SVG image from Wiki. But some build systems have internet connection disabled on purpose so this will fail.

It would be nice to have some decorator to skip tests like this when no internet connection is available. What do you think about it?

good first issue help wanted

All 3 comments

Oh.... thanks.

Yes we can do that, or my guess is SVG url= might also accept file:// url and we can point to a local one.

Hi, can I help with this question?

Yes, feel free to send a PR. I even see that the test is also mocked, so we can just remove the external test.

That would be deleting lines 109 to 112 of linked file.

Was this page helpful?
0 / 5 - 0 ratings