Godot: core/hq2x.cpp๋Š” ์ˆ˜๋งŽ์€ ๊ฒฝ๊ณ ๋ฅผ ์ƒ์„ฑํ•ฉ๋‹ˆ๋‹ค.

์— ๋งŒ๋“  2016๋…„ 06์›” 30์ผ  ยท  1๋…ผํ‰  ยท  ์ถœ์ฒ˜: godotengine/godot

Godot๋ฅผ ์ฒ˜์Œ๋ถ€ํ„ฐ ์ปดํŒŒ์ผํ•  ๋•Œ, ๋นŒ๋“œ ๋กœ๊ทธ์˜ ์ ˆ๋ฐ˜์ด core/hq2x.cpp ์—์„œ ์ƒ์„ฑ๋œ ๊ฒฝ๊ณ  ๋•Œ๋ฌธ์ด๋ผ๋Š” ๊ฒƒ์„ ์•Œ์•˜์Šต๋‹ˆ๋‹ค. ํ˜„์žฌ ๋งˆ์Šคํ„ฐ ๋ธŒ๋žœ์น˜์˜ ๋ชจ๋“  ๊ฒฝ๊ณ ์— ๋Œ€ํ•ด์„œ๋Š” ์ฒจ๋ถ€ ํŒŒ์ผ์„ ์ฐธ์กฐํ•˜์‹ญ์‹œ์˜ค: godot_hq2x_warnings.txt

๋ฐœ์ทŒ:

g++ -o core/hq2x.x11.tools.64.o -c -g2 -Wall -DDEBUG_ENABLED -DDEBUG_MEMORY_ENABLED -DFREETYPE_ENABLED -DOC_X86_ASM -DDEBUG_MEMORY_ALLOC -DSCI_NAMESPACE -DENABLE_DEPRECATED -DOPENGL_ENABLED -DALSA_ENABLED -DJOYDEV_ENABLED -DPULSEAUDIO_ENABLED -DX11_ENABLED -DUNIX_ENABLED -DGLES2_ENABLED -DGLES_OVER_GL -DMUSEPACK_ENABLED -DSQUISH_ENABLED -DVORBIS_ENABLED -DOPUS_ENABLED -DTHEORA_ENABLED -DTHEORALIB_ENABLED -DPNG_ENABLED -DDDS_ENABLED -DPVR_ENABLED -DJPG_ENABLED -DWEBP_ENABLED -DSPEEX_ENABLED -DTOOLS_ENABLED -DGDSCRIPT_ENABLED -DMINIZIP_ENABLED -DXML_ENABLED -DETC1_ENABLED -DGLEW_ENABLED -DGLEW_STATIC -D_REENTRANT -Icore -Icore/math -Itools -Idrivers -I. -Iplatform/x11 -I/usr/include/freetype2 -I/usr/include/libpng16 -Icore core/hq2x.cpp
core/hq2x.cpp: In function 'uint32_t* hq2x_resize(const uint32_t*, uint32_t, uint32_t, uint32_t*, uint32_t, uint32_t, uint32_t, uint32_t, bool, bool)':
core/hq2x.cpp:102:112: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
  (((((C0 & MASK_A) >> 8) * W0 + ((C1 & MASK_A) >> 8) * W1 + ((C2 & MASK_A) >> 8) * W2) / (W0 + W1 + W2)) << 8) & MASK_A
                                                                                                                ^
core/hq2x.cpp:110:39: note: in expansion of macro 'HQX_MIX_3'
 #define MIX_00_4_3_1_2_1_1  *output = HQX_MIX_3(w[4],w[3],w[1],2U,1U,1U);
                                       ^
core/hq2x.cpp:340:6: note: in expansion of macro 'MIX_00_4_3_1_2_1_1'
      MIX_00_4_3_1_2_1_1
      ^
core/hq2x.cpp:102:112: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
  (((((C0 & MASK_A) >> 8) * W0 + ((C1 & MASK_A) >> 8) * W1 + ((C2 & MASK_A) >> 8) * W2) / (W0 + W1 + W2)) << 8) & MASK_A
                                                                                                                ^
core/hq2x.cpp:126:44: note: in expansion of macro 'HQX_MIX_3'
 #define MIX_01_4_1_5_2_1_1 *(output + 1) = HQX_MIX_3(w[4],w[1],w[5],2U,1U,1U);
                                            ^
core/hq2x.cpp:341:6: note: in expansion of macro 'MIX_01_4_1_5_2_1_1'
      MIX_01_4_1_5_2_1_1
      ^
core/hq2x.cpp:102:112: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
  (((((C0 & MASK_A) >> 8) * W0 + ((C1 & MASK_A) >> 8) * W1 + ((C2 & MASK_A) >> 8) * W2) / (W0 + W1 + W2)) << 8) & MASK_A
                                                                                                                ^
core/hq2x.cpp:147:51: note: in expansion of macro 'HQX_MIX_3'
 #define MIX_10_4_7_3_2_1_1 *(output + lineSize) = HQX_MIX_3(w[4],w[7],w[3],2U,1U,1U);
                                                   ^
core/hq2x.cpp:342:6: note: in expansion of macro 'MIX_10_4_7_3_2_1_1'
      MIX_10_4_7_3_2_1_1
      ^

์ด ํŒŒ์ผ์€ https://github.com/brunexgeek/hqx/blob/master/source/HQ2x.cc ๋ฅผ ๊ธฐ๋ฐ˜์œผ๋กœ ํ•˜๋ฏ€๋กœ ์ด์ƒ์ ์œผ๋กœ๋Š” ์ด๋Ÿฌํ•œ ๊ฒฝ๊ณ  ์—…์ŠคํŠธ๋ฆผ์„ ์ˆ˜์ •ํ•˜๊ณ  ๋‚˜์ค‘์— ์ž์ฒด ๋ณต์‚ฌ๋ณธ์„ ์—…๋ฐ์ดํŠธํ•˜๋Š” ๋ฐ ๋„์›€์ด ๋˜์–ด์•ผ ํ•ฉ๋‹ˆ๋‹ค. ์ด ์ž‘์—…์„ ์ˆ˜ํ–‰ํ•  ์ˆ˜ ์—†๋Š” ๊ฒฝ์šฐ ๋ฒ„์ „์„ ์ง์ ‘ ํŒจ์น˜ํ•  ์ˆ˜ ์žˆ์ง€๋งŒ ๋ณ€๊ฒฝ ์‚ฌํ•ญ์„ ์—…์ŠคํŠธ๋ฆผ๊ณผ ๋™๊ธฐํ™”ํ•˜๊ธฐ๊ฐ€ ๋” ์–ด๋ ค์›Œ์ง‘๋‹ˆ๋‹ค.

bug core

๊ฐ€์žฅ ์œ ์šฉํ•œ ๋Œ“๊ธ€

PR ์—…์ŠคํŠธ๋ฆผ์„ ํ–ˆ์Šต๋‹ˆ๊นŒ? ๋ณ‘ํ•ฉ๋  ๋•Œ ์—…๋ฐ์ดํŠธ๋œ hq2x.cpp ๋กœ PR์„ ์ˆ˜ํ–‰ํ•ฉ๋‹ˆ๋‹ค. ๊ทธ๋ ‡์ง€ ์•Š์€ ๊ฒฝ์šฐ ์ˆ˜์ •์ด ๋ฌธ์ž ๊ทธ๋Œ€๋กœ ๋‘ ์ค„์— ์žˆ๋Š” 2์Œ์˜ ๊ด„ํ˜ธ์ด๊ธฐ ๋•Œ๋ฌธ์— ์–ด์จŒ๋“  PR์„ ์ˆ˜ํ–‰ํ•ฉ๋‹ˆ๋‹ค.

>๋ชจ๋“  ๋Œ“๊ธ€

PR ์—…์ŠคํŠธ๋ฆผ์„ ํ–ˆ์Šต๋‹ˆ๊นŒ? ๋ณ‘ํ•ฉ๋  ๋•Œ ์—…๋ฐ์ดํŠธ๋œ hq2x.cpp ๋กœ PR์„ ์ˆ˜ํ–‰ํ•ฉ๋‹ˆ๋‹ค. ๊ทธ๋ ‡์ง€ ์•Š์€ ๊ฒฝ์šฐ ์ˆ˜์ •์ด ๋ฌธ์ž ๊ทธ๋Œ€๋กœ ๋‘ ์ค„์— ์žˆ๋Š” 2์Œ์˜ ๊ด„ํ˜ธ์ด๊ธฐ ๋•Œ๋ฌธ์— ์–ด์จŒ๋“  PR์„ ์ˆ˜ํ–‰ํ•ฉ๋‹ˆ๋‹ค.

์ด ํŽ˜์ด์ง€๊ฐ€ ๋„์›€์ด ๋˜์—ˆ๋‚˜์š”?
0 / 5 - 0 ๋“ฑ๊ธ‰