Libelektra: ํ™ˆํŽ˜์ด์ง€: ๋นŒ๋“œ ์‹คํŒจ

์— ๋งŒ๋“  2019๋…„ 05์›” 01์ผ  ยท  4์ฝ”๋ฉ˜ํŠธ  ยท  ์ถœ์ฒ˜: ElektraInitiative/libelektra

https://build.libelektra.org/jenkins/job/elektra-homepage/656/console ๋ถ€ํ„ฐ ํ™ˆํŽ˜์ด์ง€ ๋นŒ๋“œ๊ฐ€ ๋‹ค์Œ ์˜ค๋ฅ˜์™€ ํ•จ๊ป˜ ์‹คํŒจํ•ฉ๋‹ˆ๋‹ค.

        Start  42: test_service_storageengine
 39/119 Test  #40: test_service_convertengine .......***Failed    7.44 sec
[==========] Running 12 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 12 tests from kdbrestServicesConvertengineTest
[ RUN      ] kdbrestServicesConvertengineTest.FindSuitablePluginCheck
[       OK ] kdbrestServicesConvertengineTest.FindSuitablePluginCheck (4223 ms)
[ RUN      ] kdbrestServicesConvertengineTest.ExportToFormatCheck
[       OK ] kdbrestServicesConvertengineTest.ExportToFormatCheck (80 ms)
[ RUN      ] kdbrestServicesConvertengineTest.ExportToFormatWithConfigCheck
[       OK ] kdbrestServicesConvertengineTest.ExportToFormatWithConfigCheck (54 ms)
[ RUN      ] kdbrestServicesConvertengineTest.ExportToFormatCheck2
/home/jenkins/workspace/elektra-homepage/src/tools/rest-backend/tests/test_service_convertengine.cpp:154: Failure
Value of: cf.isValidated ()
  Actual: true
Expected: false
[  FAILED  ] kdbrestServicesConvertengineTest.ExportToFormatCheck2 (106 ms)

@Namoshek ์ด ์˜ค๋ฅ˜๊ฐ€ ๋ฌด์—‡์„ ์˜๋ฏธํ•˜๋Š”์ง€ ์•„์‹ญ๋‹ˆ๊นŒ? ๋” ๊ตฌ์ฒด์ ์ธ ์œ ํšจ์„ฑ ๊ฒ€์‚ฌ ์˜ค๋ฅ˜๋ฅผ ์–ป์œผ๋ ค๋ฉด ์–ด๋–ป๊ฒŒ ํ•ด์•ผ ํ•ฉ๋‹ˆ๊นŒ?

bug build good first issue help wanted

๊ฐ€์žฅ ์œ ์šฉํ•œ ๋Œ“๊ธ€

@sanssecours ์•„์ด๋””์–ด๊ฐ€ ์žˆ์Šต๋‹ˆ๊นŒ?

๋‚ด๊ฐ€ ๋งํ•  ์ˆ˜์žˆ๋Š” ํ•œ ์ฝ”๋“œ์—์„œ :

https://github.com/ElektraInitiative/libelektra/blob/3d3c7eb52923cf4329197a9912c9439d9b33b920/src/tools/rest-backend/model_configformat.hpp#L84 -L92

๊ทธ๋ฆฌ๊ณ 

https://github.com/ElektraInitiative/libelektra/blob/3d3c7eb52923cf4329197a9912c9439d9b33b920/src/tools/rest-backend/model_configformat.hpp#L47 -L62

YAJL ์€ PR #2580์ด master ๋ถ„๊ธฐ์— ๋ณ‘ํ•ฉ๋œ ํ›„ ์™•๋ณต ์œ ํšจ์„ฑ ๊ฒ€์‚ฌ๋ฅผ ํ†ต๊ณผ ํ•ฉ๋‹ˆ๋‹ค. ์ด ์ œํ•œ๋œ ์ง€์‹ ์—์„œ ASSERT_FALSE ๋ฅผ

https://github.com/ElektraInitiative/libelektra/blob/3d3c7eb52923cf4329197a9912c9439d9b33b920/src/tools/rest-backend/tests/test_service_convertengine.cpp#L154

ASSERT_TRUE ๋ฅผ ์‚ฌ์šฉํ•˜๋Š” ๊ฒƒ์ด ๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ•˜๋Š” ์˜ฌ๋ฐ”๋ฅธ ๋ฐฉ๋ฒ•์ด์–ด์•ผ ํ•ฉ๋‹ˆ๋‹ค.

๋ชจ๋“  4 ๋Œ“๊ธ€

์†”์งํžˆ ๋งํ•ด์„œ, ๋‚˜๋Š” ์•ฝ๊ฐ„์˜ ์•„์ด๋””์–ด๊ฐ€ ์—†์Šต๋‹ˆ๋‹ค. ํ…Œ์ŠคํŠธ ์ค‘์ธ ํ”Œ๋Ÿฌ๊ทธ์ธ ๋ณ€๊ฒฝ์œผ๋กœ ์ธํ•ด ๋ฐœ์ƒํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค. ๋‚˜๋Š” ๊ทธ ์ดํ›„๋กœ C++๋ฅผ ์ „ํ˜€ ์ž‘์„ฑํ•˜์ง€ ์•Š์•˜๊ธฐ ๋•Œ๋ฌธ์— ๊ทธ๋•Œ ๋‚ด๊ฐ€ ํ•œ ์ผ์„ ์ดํ•ดํ•˜๋Š” ๋ฐ ๊ฝค ์–ด๋ ค์›€์„ ๊ฒช๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค. ๐Ÿ˜„

๊ทธ๋ž˜๋„ ๋น ๋ฅธ ๋‹ต๋ณ€ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค.

์ด์ œ JSON์„ ์‚ฌ์šฉํ•œ ์™•๋ณต ์œ ํšจ์„ฑ ๊ฒ€์‚ฌ๊ฐ€ ์‹คํŒจํ•œ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค. @sanssecours ์•„์ด๋””์–ด๊ฐ€ ์žˆ์Šต๋‹ˆ๊นŒ?

@sanssecours ์•„์ด๋””์–ด๊ฐ€ ์žˆ์Šต๋‹ˆ๊นŒ?

๋‚ด๊ฐ€ ๋งํ•  ์ˆ˜์žˆ๋Š” ํ•œ ์ฝ”๋“œ์—์„œ :

https://github.com/ElektraInitiative/libelektra/blob/3d3c7eb52923cf4329197a9912c9439d9b33b920/src/tools/rest-backend/model_configformat.hpp#L84 -L92

๊ทธ๋ฆฌ๊ณ 

https://github.com/ElektraInitiative/libelektra/blob/3d3c7eb52923cf4329197a9912c9439d9b33b920/src/tools/rest-backend/model_configformat.hpp#L47 -L62

YAJL ์€ PR #2580์ด master ๋ถ„๊ธฐ์— ๋ณ‘ํ•ฉ๋œ ํ›„ ์™•๋ณต ์œ ํšจ์„ฑ ๊ฒ€์‚ฌ๋ฅผ ํ†ต๊ณผ ํ•ฉ๋‹ˆ๋‹ค. ์ด ์ œํ•œ๋œ ์ง€์‹ ์—์„œ ASSERT_FALSE ๋ฅผ

https://github.com/ElektraInitiative/libelektra/blob/3d3c7eb52923cf4329197a9912c9439d9b33b920/src/tools/rest-backend/tests/test_service_convertengine.cpp#L154

ASSERT_TRUE ๋ฅผ ์‚ฌ์šฉํ•˜๋Š” ๊ฒƒ์ด ๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ•˜๋Š” ์˜ฌ๋ฐ”๋ฅธ ๋ฐฉ๋ฒ•์ด์–ด์•ผ ํ•ฉ๋‹ˆ๋‹ค.

๊ทธ๊ฒƒ์€ ์‰ฌ์šด ์ˆ˜์ •์ฒ˜๋Ÿผ ๋“ค๋ฆฝ๋‹ˆ๋‹ค! ์ž์„ธํ•œ ์„ค๋ช… ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค!

์ด ํŽ˜์ด์ง€๊ฐ€ ๋„์›€์ด ๋˜์—ˆ๋‚˜์š”?
0 / 5 - 0 ๋“ฑ๊ธ‰