Phpunit: 7.2.5 BC ํœด์‹ !

์— ๋งŒ๋“  2018๋…„ 06์›” 21์ผ  ยท  4์ฝ”๋ฉ˜ํŠธ  ยท  ์ถœ์ฒ˜: sebastianbergmann/phpunit

| ์งˆ๋ฌธ | NS
| --------------------| ---------------
| PHPUnit ๋ฒ„์ „ | 7.2.5
| PHP ๋ฒ„์ „ | ์˜ˆ๋ฅผ ๋“ค์–ด 7.1
| ์„ค์น˜ ๋ฐฉ๋ฒ• | ์ž‘๊ณก๊ฐ€, ํ•˜์ง€๋งŒ ์ƒ๊ด€์—†์–ด

์ƒˆ๋กœ ๋ฆด๋ฆฌ์Šค๋œ 7.2.5 ์ค‘๋‹จ BC:
https://github.com/sebastianbergmann/phpunit/commit/bcb4c788c7872cd2f885ccf50285f6feb7cfff1a#diff -9ae7a972d07df5f73629d5d315bf405aR521

๋ฉ”์„œ๋“œ์˜ ๊ณต์‹ ์„ ์–ธ์ด ๋ณ€๊ฒฝ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

-    public static function assertNotEquals($expected, $actual, string $message = '', $delta = 0.0, $maxDepth = 10, $canonicalize = false, $ignoreCase = false): void
+    public static function assertNotEquals($expected, $actual, string $message = '', float $delta = 0.0, int $maxDepth = 10, bool $canonicalize = false, bool $ignoreCase = false): void

์ด๋ฅผ ์œ„ํ•ด ํ˜ธํ™˜๋˜์ง€ ์•Š๋Š” ๋ฉ”์†Œ๋“œ ํ—ค๋”์—์„œ ํ†ตํ•ฉ์ด ์ถฉ๋Œํ•ฉ๋‹ˆ๋‹ค.
https://travis-ci.org/FriendsOfPHP/PHP-CS-Fixer/jobs/394945074#L655

PHP Fatal error:  Uncaught Declaration of
PHPUnitGoodPractices\Traits\IdentityOverEqualityTrait::assertNotEquals($expected, $actual, string $message = '', $delta = 0, $maxDepth = 10, $canonicalize = false, $ignoreCase = false): void
should be compatible with
PHPUnit\Framework\Assert::assertNotEquals($expected, $actual, string $message = '', float $delta = 0, int $maxDepth = 10, bool $canonicalize = false, bool $ignoreCase = false): void

๊ฐ€์žฅ ์œ ์šฉํ•œ ๋Œ“๊ธ€

๊ทธ๋Ÿฐ ๋‹ค์Œ PHPUnit 8์—์„œ final ๋กœ ๋งŒ๋“ค ๊ฒƒ์ž…๋‹ˆ๋‹ค :-)

๋ชจ๋“  4 ๋Œ“๊ธ€

์‚ฌ๋žŒ๋“ค์ด PHPUnit์˜ ์ฃผ์žฅ์„ ๋ฎ์–ด์“ฐ๋Š” ์ด์œ ๋Š” ๋ฌด์—‡์ž…๋‹ˆ๊นŒ? ํ•œ์ˆจ์„ ์‰ฌ๋‹ค

๋‹จํŽธ? ์ตœ์ข…์œผ๋กœ ํ‘œ์‹œ๋˜์ง€ ์•Š๊ธฐ ๋•Œ๋ฌธ์—

๊ธด ์ด์•ผ๊ธฐ? ๋‚ด ๊ตฌ์ฒด์ ์ธ ์‚ฌ๋ก€์— ๋Œ€ํ•ด https://github.com/PHPUnitGoodPractices/Traits/blob/master/src/IdentityOverEqualityTrait.php#L46 -L56 ๋น„๋””์˜ค๋ฅผ

๊ทธ๋Ÿฐ ๋‹ค์Œ PHPUnit 8์—์„œ final ๋กœ ๋งŒ๋“ค ๊ฒƒ์ž…๋‹ˆ๋‹ค :-)

๊ทธ๋ ‡๋‹ค๋ฉด ๋จผ์ € ์ฃผ์žฅ/๊ธฐ๋Œ€๋ฅผ ๋“ฑ๋กํ•˜๋Š” ์ฃฝ์€ ์ฃผ์ œ์—์„œ ๊ฐ€์ ธ์˜ฌ ์ˆ˜ ์žˆ์Šต๋‹ˆ๊นŒ? ๊ทธ๋ž˜์„œ (๋ชจ๋“  ๋‹จ์ผ ํ…Œ์ŠคํŠธ์—์„œ ์ˆ˜๋™ ๊ฐ€์ ธ์˜ค๊ธฐ ์—†์ด) ์ „์—ญ์ ์œผ๋กœ ์‚ฌ์šฉํ•  ์ˆ˜ ์žˆ๋Š” ๋ช‡ ๊ฐ€์ง€ ์ถ”๊ฐ€ ์–ด์„ค์…˜์„ ๊ฐ–๊ฑฐ๋‚˜ ๋‚ด์žฅ๋œ ๋ชจ๋“  ์–ด์„ค์…˜์„ ๋“ฑ๋กํ•˜์ง€ ์•Š๊ธฐ๋กœ ๊ฒฐ์ •ํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๊นŒ?
๊ทธ๋Ÿฌ๋‚˜ ์ผ๋ฐ˜์ ์œผ๋กœ :+1: ์ตœ์ข… ๋ฉ”์†Œ๋“œ/ํด๋ž˜์Šค/๊ตฌ์ฒด ๊ตฌํ˜„์— ๋Œ€ํ•œ ์ธํ„ฐํŽ˜์ด์Šค ๋…ธ์ถœ

๋˜ํ•œ, ๋‹ค์‹œ ํ•œ ๋ฒˆ ์š”์ฒญํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค. ;) ์ด ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ์—์„œ ์‚ฌ์šฉ๋˜์ง€ ์•Š๋Š” BC ์•ฝ์† ๋ฐ–์˜ ํ•ญ๋ชฉ์— ๋Œ€ํ•ด @internal ํƒœ๊ทธ๋ฅผ ์‚ฌ์šฉํ•˜๋„๋ก ํ•ฉ์‹œ๋‹ค.
(์˜ˆ: ๋ชจ๋“  ๊ฒƒ์„ ๋‚ด๋ถ€๋กœ ํ‘œ์‹œํ•˜๋Š” PR์„ ์ค€๋น„ํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค. ๊ทธ๋Ÿฐ ๋‹ค์Œ ๊ณต๊ฐœํ•  ํ•ญ๋ชฉ์„ ์—ฝ๋‹ˆ๋‹ค.)

์ด ํŽ˜์ด์ง€๊ฐ€ ๋„์›€์ด ๋˜์—ˆ๋‚˜์š”?
0 / 5 - 0 ๋“ฑ๊ธ‰