Learn-json-web-tokens: Issue with default expiry time

Created on 3 Aug 2015  ·  6Comments  ·  Source: dwyl/learn-json-web-tokens

The intention is to expire in 7 days, but the code doesn't provide a number thats 7 days ahead of now...far from it!
https://github.com/dwyl/learn-json-web-tokens/blob/master/example/lib/helpers.js#L39

$ node
> var x = Math.floor(new Date().getTime()/1000) + 7*24*60*60
undefined
> new Date(x)
Sat Jan 17 1970 15:46:41 GMT+0000 (BST)
> 

I used this instead:

Date.now() + (1000 * 60 * 60 * 24 * 7)
bug help wanted

Most helpful comment

PR #79 out for test fix. green build this time :)

https://travis-ci.org/dwyl/learn-json-web-tokens

image

All 6 comments

@alanshaw much betterer! :+1:
Do you have time to submit as PR?

PR out #78

Gents, my reading of this SO Question/Answer:
https://stackoverflow.com/questions/28738168/how-to-create-jwt-exp-style-date-in-javascript
is that we need to _divide_ by 1000 to convert to _seconds_ for exp ...

I think we solved it from an expiration point of view by adding the '7d' option.

What I see now is that we have travis-ci not happy about that change and I'm not sure how to debug it.

PR #79 out for test fix. green build this time :)

https://travis-ci.org/dwyl/learn-json-web-tokens

image

@emersonmellado thanks again for making time to fix this! 👍

Was this page helpful?
0 / 5 - 0 ratings

Related issues

rjmk picture rjmk  ·  9Comments

KumarS-Naveen picture KumarS-Naveen  ·  3Comments

nelsonic picture nelsonic  ·  5Comments

joepie91 picture joepie91  ·  18Comments

NE-SmallTown picture NE-SmallTown  ·  5Comments