Plots2: Call for reviewers and co-reviewing workflow ⚡️
Building on the process we developed in https://github.com/publiclab/image-sequencer/issues/656, I'd like to propose an improved collaborative workflow for co-reviewing new code in the plots2 project. We've had some great success trying this out at image-sequencer, and although we already do a lot of co-reviewing here in the plots2 project, I also think we could share the responsibility even more!
Community growth
This is especially important as our community has grown so much in the past few months!
Check out some of these pages to see how many people have helped build plots2, since we really started doing welcoming and outreach ~2 years ago:
- Community Toolbox: https://code.publiclab.org/#r=plots2
- GitHub Pulse: https://github.com/publiclab/plots2/pulse/monthly
- Contributors graphs: https://github.com/publiclab/plots2/graphs/contributors
What's next: co-review workflow
To build on this community strength 🤝, we'd like to ask for people to sign up as reviewers, to help get pull requests ready for merging. In the new workflow, we'd like each PR to have:
- ✅ 2 reviews by people from the @publiclab/plots2-reviewers group
- ✅ a
readylabel, once ready for final review by someone with merge permissions (currently @SidharthBansal, @gauravano, and I, although we are interested in expanding this group soon) - ✅ tests if possible (not mandatory but preferred) with each PR - although for first-timers this is less critical.
This doesn't mean that we should stop helping each other solve problems even if we're not in the reviewers group -- i've seen a lot of great welcoming and cooperation! But at least we'll be able to get things ready and merged faster. 👍 🙌
Reviewers team
So, this new @publiclab/plots2-reviewers team -- we'd like to ask folks to join it if you're interested! Many of you already play this role -- THANK YOU! 🎉 We'd like folks to consider, as a prerequisite to joining:
- ✅ having 2 PRs merged
- ✅ having helped someone else troubleshoot a PR or issue
- ✅ having made a first-timers-only issue and welcomed in a new person to make their own first contribution (this is how our community grows!)
If you've completed these, please ask here and we'll be sure to add you the new reviewers group. You'll get notifications when people request a review from you, or mention @publiclab/plots2-reviewers.
Also, we should welcome reviews by folks not in the reviewers group, of course! This will be a group to help coordinate co-reviews, but it's not meant to be exclusive. And we should encourage people to join!
Managing too many emails!
Just a note - your inbox can become quite a mess as the community grows! Consider turning off notifications for /every event/ and just listening to if you're mentioned! 📬
THANK YOU for making this part of the Public Lab coding community a warm, welcoming, and wonderful place!!! ⚡️ 🙌 👍 🎉 🎉 🎉
jywarren
All 35 comments
Also, @publiclab/reviewers (our older group we are revising!) please check this out!
jywarren
on 24 Jan 2019
Count me in :) !
sagarpreet-chadha
on 24 Jan 2019
I'm in... :))
I've completed the prerequisites..
oorjitchowdhary
on 25 Jan 2019
@sashadev-sky - maybe you'd be interested? I know @paarmita has been really helpful on this kind of activity as well although haven't seen you in a little while, but do tell us if you're interested! Thanks all! 🎉
jywarren
on 28 Jan 2019
@jywarren Thank you for mentioning me, I would love to join the group 👍
sashadev-sky
on 29 Jan 2019
Great! I'll add you shortly. Also I was wondering if @cesswairimu had any interest? And to be clear this reviewing responsibility is one we plan to share so there's no need to be worried about having to do lots of reviews if you don't have time. Each person can participate to the extent of their willingness and time available and we're grateful for your teamwork!
jywarren
on 29 Jan 2019
Count me in as well :)
On Wed, Jan 30, 2019 at 12:17 AM Jeffrey Warren notifications@github.com
wrote:
Great! I'll add you shortly. Also I was wondering if @cesswairimu
https://github.com/cesswairimu had any interest? And to be clear this
reviewing responsibility is one we plan to share so there's no need to be
worried about having to do lots of reviews if you don't have time. Each
person can participate to the extent of their willingness and time
available and we're grateful for your teamwork!—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4707#issuecomment-458659173,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATwCYQMe6QFTNLB5OU4SghdOZycPq-OFks5vIJclgaJpZM4aQ4E5
.
namangupta01
on 29 Jan 2019
I am also interested.
On Wed, Jan 30, 2019, 1:41 AM Naman Gupta <[email protected] wrote:
Count me in as well :)
On Wed, Jan 30, 2019 at 12:17 AM Jeffrey Warren notifications@github.com
wrote:Great! I'll add you shortly. Also I was wondering if @cesswairimu
https://github.com/cesswairimu had any interest? And to be clear this
reviewing responsibility is one we plan to share so there's no need to be
worried about having to do lots of reviews if you don't have time. Each
person can participate to the extent of their willingness and time
available and we're grateful for your teamwork!—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/publiclab/plots2/issues/4707#issuecomment-458659173
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ATwCYQMe6QFTNLB5OU4SghdOZycPq-OFks5vIJclgaJpZM4aQ4E5.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4707#issuecomment-458689262,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ7XrGHZALK3oxyRClZA5qoXfNySuks5vIKrTgaJpZM4aQ4E5
.
SidharthBansal
on 30 Jan 2019
Sidharth, you were already in the group when it formed :smile:
grvsachdeva
on 30 Jan 2019
Yeah I forget sorry
On Wed, Jan 30, 2019, 11:41 PM Gaurav Sachdeva <[email protected]
wrote:
Sidharth, you were already in the group when it formed 😄
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4707#issuecomment-459049119,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQwSoAk0EbhSFWPj9SdA_h1lPY5wYks5vIeBigaJpZM4aQ4E5
.
SidharthBansal
on 31 Jan 2019
@aSquare14 did you want to join in as a reviewer? Thanks for all your help as a mentor!
jywarren
on 5 Feb 2019
Hi, folks, just wanted to say that I've also been trying to close out older more urgent issues by breaking some of these out and recruiting into them from the weekly check-ins; esp with some people shifting over to MapKnitter, i'm interested in doing a good job to wrap up long-open projects at PublicLab so we feel more confident starting new projects. Sometimes it's hard to really check something totally off the list!
jywarren
on 5 Feb 2019
@jywarren Can I be a part of reviewers team..
harshithpabbati
on 18 Feb 2019
Hey @Harshithpabbati, can you paste the links to the PRs, issues here as I can't find your PRs on plots2? Thanks!
grvsachdeva
on 18 Feb 2019
https://github.com/publiclab/image-sequencer/pull/782#issuecomment-464532477
https://github.com/publiclab/community-toolbox/pull/140#issuecomment-464178629
@gauravano
harshithpabbati
on 18 Feb 2019
These are pre-requisite to join the @publiclab/plots2-reviewers group:
grvsachdeva
on 18 Feb 2019
So do i need to create a first timers issue??
@gauravano
harshithpabbati
on 18 Feb 2019
you need to do all the three tasks for the plots2 repo.
grvsachdeva
on 18 Feb 2019
Count me in! :tada:
IshaGupta18
on 23 Mar 2019
Me 🙋♀️. It's Lekhika here.
I guess I have completed the prerequisites given in issue required to be a reviewer. 🤔
Is there anything else which is required?
CleverFool77
on 23 Mar 2019
@IshaGupta18 added you
grvsachdeva
on 23 Mar 2019
Thank you @gauravano :tada:
IshaGupta18
on 23 Mar 2019
@CleverFool77 added you too.
grvsachdeva
on 23 Mar 2019
Can i be a part of this team ?
Guess I have completed the prerequisites :)
ananyaarun
on 23 Mar 2019
Added you @ananyaarun!
grvsachdeva
on 23 Mar 2019
wow, amazing, thank you all!
On Sat, Mar 23, 2019 at 2:11 PM Gaurav Sachdeva notifications@github.com
wrote:
Added you @ananyaarun https://github.com/ananyaarun!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4707#issuecomment-475892101,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ2EEyTOkSHs_vNxKEFsUECtHbQ5Mks5vZm4mgaJpZM4aQ4E5
.
jywarren
on 25 Mar 2019
Hey!!
I have completed all the prerequisites. Can I be added to this group?
Thanks!
divyabaid16
on 21 Apr 2019
I have completed the prerequisites. Please add me to the group.
jainaman224
on 21 Apr 2019
@jywarren @gauravano I guess I have completed all the prerequisites required to be a part of this group. I would love to help new contributors in their issues and PRs and also reviewing them.
Kindly add me to this group.
Thanks!
gautamig54
on 22 Apr 2019
Hi @divyabaid16 @jainaman224 @gautamig54 added you all to the @publiclab/plots2-reviewers :tada: :+1:
Thanks!
grvsachdeva
on 22 Apr 2019
@gauravano , @jywarren I have completed all the steps. I would love to help beginners in their PRs by reviewing them. Please add me in the group too.
pydevsg
on 21 Nov 2019
Done! Thank you!!!
jywarren
on 22 Nov 2019
@VladimirMikulic @Uzay-G are interested I guess
SidharthBansal
on 27 Jan 2020
@cesswairimu @jywarren can you please add these folks
SidharthBansal
on 27 Jan 2020
:+1:
VladimirMikulic
on 27 Jan 2020
Related issues
keshavsethi
·
3Comments
keshavsethi
·
3Comments
jywarren
·
3Comments
milaaraujo
·
3Comments
grvsachdeva
·
3Comments
Most helpful comment
Hi @divyabaid16 @jainaman224 @gautamig54 added you all to the @publiclab/plots2-reviewers :tada: :+1:
Thanks!