React-pdf: Add pdfjs to @types/react-pdf
Before you start - checklist
- [*] I understand that React-PDF does not aim to be a fully-fledged PDF viewer and is only a tool to make one
- [*] I have checked if this feature request is not already reported
Is your feature request related to a problem? Please describe.
When importing pdfjs from the package (to define the remote worker) typescript can't compile because the definition doesn't exist on DefinitelyTyped
Describe the solution you'd like
Add the definition to the package
jazzdragon
All 6 comments
Maybe @CodeDaraW who created the types could be of any help?
wojtekmaj
on 26 Jun 2019
You can import pdfjs from pdfjs-dist directly, that's the same thing.
I didn't import the type definition of pdfjs-dist, you may create a Pull Request for it.
CodeDaraW
on 26 Jun 2019
I added basic support for this by exporting version and GlobalWorkerOptions from @types/pdfjs-dist, and then exporting pdfjs-dist as pdfjs from @types/react-pdf.
import { Document, Page, pdfjs } from 'react-pdf';
pdfjs.GlobalWorkerOptions.workerSrc =
`//cdnjs.cloudflare.com/ajax/libs/pdf.js/${pdfjs.version}/pdf.worker.js`;
Example above now works in TypeScript.
@wojtekmaj @CodeDaraW
nikuda
on 4 Sep 2019
This has been merged as is now available in @types/react-pdf@^4.0.3. Make sure to delete your yarn.lock file to get @types/pdfjs-dist@^2.1.1 type changes as well.
Thanks @CodeDaraW for review.
nikuda
on 10 Sep 2019
Maybe @wojtekmaj can close the issue now.
CodeDaraW
on 11 Sep 2019
Wow! Thanks so much to everyone involved.
wojtekmaj
on 15 Sep 2019
Related issues
GManzato
·
4Comments
nnnikolay
·
4Comments
Vanals
·
4Comments
saadq
·
3Comments
mapoulos
·
4Comments
Most helpful comment
This has been merged as is now available in
@types/react-pdf@^4.0.3. Make sure to delete youryarn.lockfile to get@types/pdfjs-dist@^2.1.1type changes as well.Thanks @CodeDaraW for review.