React: "rowspan" attribute does not appear in DOM
<th rowspan="2"></th> does not set rowspan in the DOM.
Component:
render: function() {
return (
<thead>
<tr>
{this.props.columns.map(this.renderColumnLabel)}
<th rowspan="2"></th>
</tr>
<tr>
{this.props.columns.map(this.renderColumnControl)}
</tr>
</thead>
);
}
Output:
...
<th data-reactid=".r[5je1f].[0].[1].[1].[6].[0].[0].[1].[0].[0].[0].[1]"></th>
...
Can this be my first PR? :)
ericclemmons
All 9 comments
If you do rowSpan it'll work -- we use the camelcase version for attributes for consistency with the DOM interface where you'd do el.rowSpan = 2;. I've already opened #255 to warn when using the wrong case since lots of people get confused by this.
sophiebits
on 14 Aug 2013
Oh, that's it. Thanks :) I'll await #255's resolution for long term, but adjust my code in the short term...
ericclemmons
on 14 Aug 2013
Sorry @ericclemmons, it could have been :) I tried to do a pass for missing attributes pre-0.4 but if you notice anything missing from https://github.com/facebook/react/blob/master/src/dom/DefaultDOMPropertyConfig.js, feel free to open an issue or PR
zpao
on 14 Aug 2013
Oh, it totally looks like rowSpan (camelCased!) is missing. I'll submit a PR...
ericclemmons
on 14 Aug 2013
Oops! I saw colSpan and naively assumed that rowSpan would be there too… :)
sophiebits
on 14 Aug 2013
@ericclemmons Still interested in fixing this?
zpao
on 23 Aug 2013
Closing for #291...
ericclemmons
on 25 Aug 2013
Given that this trips people up, instead of being consistent with the DOM, why not be consistent with HTML and support all-lowercase attributes?
I just had to go back to the docs for this issue about the "autocomplete" attribute.
I'm writing something that looks like HTML, it should work like HTML... otherwise it's an inconsistency, not consistency.
inimino
on 4 May 2014
I agree. It would be preferable (to me) if attributes were all mapped .toLowerCase().
ericclemmons
on 5 May 2014
Related issues
DimitarChristoff
·
3Comments
bloodyowl
·
3Comments
jimfb
·
3Comments
trusktr
·
3Comments
varghesep
·
3Comments
Most helpful comment
If you do
rowSpanit'll work -- we use the camelcase version for attributes for consistency with the DOM interface where you'd doel.rowSpan = 2;. I've already opened #255 to warn when using the wrong case since lots of people get confused by this.