Ace: New JSON mode with autocompletion, etc.

Created on 8 Feb 2016 · 4Comments · Source: ajaxorg/ace

I have nearly completed my reimplementation of JSON mode with:

Support for multiple errors in code (instead of failing after first error)
JSON Schema validation support
Auto-completion support according to a provided JSON Schema
Contributions support: allowing insertion of code based on complex scenarios - for example downloading values from external data source
Custom validation - allowing to provide second level of logical validation of JSON document
All operations are properly executed in web worker.

I would be happy to share my code, but there are two problems:

Major one: I am utilizing some JSON parsers from a different large project coming with an MIT license. This might be a dealbreaker.
Minor one: I am far too lazy to write tests for trivial code :-(
Would you like to accept such a PR (should I create one)?
How should I handle license headers for such a PR?

BTW. Great job implementing the ACE editor! :)

Source

mkosieradzki

All 4 comments

That sounds interesting. Please submit a pr or give a link to the repository with the code, and we can decide how to proceed. If it's not possible to include in ace, we can still maintain json tooling in a separate repository. I actually want to move other workers into their own repositories too.

nightwing on 9 Feb 2016

It is currently in my private repository so the action plan:
I will

complete my code (excluding contributions (4) and custom validation (5) mechanism - I will explain below why)
fork ace repo on GH
Move and cleanup code to this forker repo
Create a PR

I am going to

keep all third pirty code in modes/json subdir after removing legacy parser. I am going to keep all the original MIT headers in this dir and also add LICENSE to this dir.
push only the javascript files with proper simplified common js module stylings (I will not push the original typescript files). I will provide links to the original typescript files for reference in some documentation file.
Apply my own modifications to the existing modes/json_worker, modes/json keeping BSD header

Regarding contributions and custom schema validation - I would need to create yet another extensibility kinds (like for modes, themes, etc) for plugable contributions and custom schema validation: this is something requiring more discussion - as for my own private fork I planned hardcoding of those mechanisms. Such plugins should be loadable into worker using standard ACE mechanisms.

Does this all sound reasonable?

mkosieradzki on 9 Feb 2016

Any update on this?Is this feature supported now?