Astropy: SkyCoord Constructs frames with distance=1*u.one rather than UnitSphericalRepresentation

Created on 28 Feb 2018  ·  3Comments  ·  Source: astropy/astropy

doing:

SkyCoord(UnitSphericalRepresentation(1*u.deg, 1*u.deg))

passes a distance=1*u.one to the frame constructor, where as it should not pass distance at all to the frame so it constructs UnitSphericalRepresentation.

This causes a lot of problems in sunpy since this commit.

coordinates
Source
picture Cadair

Most helpful comment

sssshhhhhh :p

picture Cadair on 28 Feb 2018
😄2

All 3 comments

Wait a minute, you wrote that commit... :wink:

pllim picture pllim on 28 Feb 2018
😄2

sssshhhhhh :p

Cadair picture Cadair on 28 Feb 2018
😄2

An alternative discussed with @adrn at pyastro18 is to change what "unit" means so that SunPy could default to RSun rather than 1*u.one.

Cadair picture Cadair on 2 May 2018
Was this page helpful?
0 / 5 - 0 ratings

Related issues

JWDobken picture JWDobken  ·  3Comments
Amarchuk picture Amarchuk  ·  3Comments
larrybradley picture larrybradley  ·  3Comments
pllim picture pllim  ·  3Comments
funbaker picture funbaker  ·  3Comments