Auto: Auto using email rather than github login?
Describe the bug
For some reason, Auto is using my github email address rather than my login. See for example:
https://github.com/storybookjs/design-system/releases/tag/v0.0.43
To Reproduce
Here are my settings:
$ git config --list | grep user
user.name=Michael Shilman
user.email=[what's in changelog]
The email matches my primary email address on Github. I checked with @domyen and @kylesuss, whose logins are showing up properly, and their settings are equivalent. I'm using Github Desktop with SSH auth.
To repro, run yarn auto changelog in the Storybook Design System: https://github.com/storybookjs/design-system
Expected behavior
Expect it to use my github login @shilman in the changelog entries.
Desktop (please complete the following information):
- OS: MacOS 10.14.5
- Version 4.15.5
shilman
All 7 comments
Thanks for the report! I'll try to take a look this week
hipstersmoothie
on 7 Aug 2019
@hipstersmoothie Any luck? I'd like to write an article about using Auto in Storybook Design System but it's hard for me to recommend in the current state. If it's not obvious from the symptoms or you can't repro I'll try to debug it myself. Please let me know either way. Thanks!
shilman
on 26 Aug 2019
I’ll take a look tomorrow!
On Sun, Aug 25, 2019 at 10:36 PM Michael Shilman notifications@github.com
wrote:
@hipstersmoothie https://github.com/hipstersmoothie Any luck? I'd like
to write an article about using Auto in Storybook Design System but it's
hard for me to recommend in the current state. If it's not obvious from the
symptoms or you can't repro I'll try to debug it myself. Thanks!—
You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub
https://github.com/intuit/auto/issues/509?email_source=notifications&email_token=AAJDEBDQSSU3JR63QFHWOOTQGNTWPA5CNFSM4IJQQXPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5DKB6Y#issuecomment-524722427,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJDEBHDNDOQFSPCYJTZHMDQGNTWPANCNFSM4IJQQXPA
.
hipstersmoothie
on 26 Aug 2019
The commit that doesn't have your username was a push to master.
When a commit is pushed to master there is not easy way to connect it to a github user. All we have in this case is the email that the commit was made with. When a commit is attached to a PR we can find the user, but in a push to master it is not there.
https://github.com/intuit/auto/blob/master/packages/core/src/release.ts#L649
In the case we can't find the PR we do a search for that email on github (there is not octokit approved way of connecting a user's email to an account)
https://github.com/intuit/auto/blob/master/packages/core/src/release.ts#L675
The search looks like this:
https://github.com/search?q=in%3Aemail+in%3Ausers+dom%40hichroma.com&type=Users
As you can see dom comes up, but when i try searching your email nothing comes up:
https://github.com/search?q=in%3Aemail+in%3Ausers+michael%40lab80.co&type=Users
This i because you haven't made the [email protected] email address public on your GitHub account. I have tried the changelog on PRs where you didn't do a push to master and it seems to pickup your account fine.
I have a PR that will address some of the bugs in the author section, but your particular bug can only be fixed by making the email public. Otherwise we don't actually have a way to to connect your account. Although if a changelog has commits from you from a pr and from master it will now favor the author with a login.
hipstersmoothie
on 26 Aug 2019
Thanks for looking into this @hipstersmoothie, it makes sense! Guess I need to stop cutting corners on the commits. 😭 Sorry for the fuss!
shilman
on 27 Aug 2019
@shilman No fuss here! Because of this issue I tracked down a few other changelog bugs that I had been meaning to squash, thanks for the issue!
hipstersmoothie
on 27 Aug 2019
:rocket: Issue was released in v7.3.3 :rocket:
adierkens
on 27 Aug 2019
Related issues
hipstersmoothie
·
11Comments
aleclarson
·
14Comments
zephraph
·
11Comments
aleclarson
·
14Comments
hipstersmoothie
·
13Comments
Most helpful comment
I’ll take a look tomorrow!
On Sun, Aug 25, 2019 at 10:36 PM Michael Shilman notifications@github.com
wrote: