Botframework-solutions: Botskills connect does not always pass correct values to az bot authsetting list/deploy.ps1 naming inconsistency

What project is affected?

botskills and/or deploy.ps1

What language is this in?

Powershell

What happens?

When connecting a bot to a skill, botskill connect uses the name provided as both the bot name and resource group. The deploy.ps1 sometimes applies a suffex to the bot name and not the resource group.

What are the steps to reproduce this issue?

Not sure how to trigger the inconsistent naming in deploy.ps1. I named my bot "BBVA" during deployment. The resource group was called "BBVA," the bot was called "BBVA-n24mm34." Later, when connecting a skill, neither BBVA or BBVA-n24mm34 worked for the bot name arguement, both fail on az bot authsettings command. Running az bot authsetting list -n BBVA-n24mm34 -g BBVA returned the desired result.

What were you expecting to happen?

I'd expect the name I entered in deploy.ps1 to work as the bots name, but if we must use suffixes we could apply them consistently. botskills does not fail gracefully from this state, so it's unclear to the user if manual set up of oauth connections and a redeployment is all that is needed to continue deployment

Can you share any logs, error output, etc.?

From botskills connect:

Configuring bot auth settings
Checking for authentication settings ...
Configuring Azure AD connection ...
Checking for existing aad connections
Could not configure authentication connection automatically.
There was an error while executing the following command:
az bot authsetting list -n bbva-n24mm34 -g bbva-n24mm34
undefined
You must configure one of the following connection types MANUALLY in the Azure Portal:
Azure Active Directory v2, Google
For more information on setting up the authentication configuration manually go to:
https://aka.ms/vamanualauthsteps
(node:21160) UnhandledPromiseRejectionWarning: WARNING: You have 55 updates available. Consider updating your CLI installation.

(node:21160) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:21160) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Suggested Changes

If suffixes are applied in deploy.ps1, apply them globally.
Handle exceptions in promises and provide users with a clean exit
Add an optional bot resource group parameter to botskills connect

Workaround?

I think manually configuring oAuth connections and running deploy.ps1 again will finish the process, but I have not tested it/won't have a chance to test it for several days. In my case I was testing out issues I faced, and have deleted the projects.