Botframework-solutions: [Typescript] Add GA SDK Skill support to VA/Skill Generator

hi Darrenj,
Is there any ETA on the issue to be fixed?
thanks,
Kumar

Hoping to have end to end working for testing this week all being well.

Thank you @darrenj for the update.

is there any update on this issue @darrenj

Hi Darren,

@darrenj could you please provide an update on this work item. we need this critical feature to be developed for our use case.

appreciate your help.

thanks,
Kumar

Hi @darrenj ,

Sorry to bother you again, there are any update on this?
I saw that the library has been released for the version 4.6.0 (https://botbuilder.myget.org/feed/botbuilder-v4-js-daily/package/npm/botframework-streaming), is this compatible with the Botframework 4.5.0 and the Virtual Assistant?

There are a few things in flight here, one is the streaming extension availability which you've spotted and the other is the typescript availability of the new GA version of the Skills library. I am expecting the first packaged build of the Skills library next week at which point we can start updates of both the C# and Typescript templates to test and provide the (simple) migration steps.

We are targeting having this work ready for use in January and will keep this issue updated with progress including when daily builds are available.

In the meantime a Javascript/Typescript VA Bot can call a Skill created in JavaScript/Typescript as this uses HTTP due to the lack of the streaming extension dependency. The issue comes in when you wish to call a C# Skill like Calendar which the above changes will align across all languages.

@darrenj is this fixed and can I connect C# Skill from typescript VA? I am confused about your last comment.

Hello @darrenj ,

Once this resolved, would it be possible to invoke cSharp skills like ToDo from a TypeScript version on VA ?

Currently, I am getting an error related to WebSocketTransport used on C# skill. But my VA is typescript.

Yes, migration to the GA version of Skills removes the dependency on Websockets and thus will enable seamless mix/match of skills across platforms. We have the latest bits for C# and JS and working on initial integration, goal is to get changes into a daily build within the next couple of weeks to unblock scenarios.

Hi @darrenj,

I have another use case which is Typescript VA and Typescript Skill.

My problem is that the updateActivity is not available across the VA to the Skill and I need the streaming library for this (as far as I understood). Now I actually noticed that the WebSocket dependencies have been removed from the latest skills library (4.4.9).
Don't understand why :) Are going to be moved somewhere else? Or?

OK, I have an update on progress with regard to the GA of the Skill capabilities within the Bot Framework SDK. This has transitioned the work incubated by Virtual Assistant into a formal GA version.

A sample is available that shows how a Bot can invoke another Bot (Skill). Key change is we now have a unified adapter meaning there is no need to utilise a different adapter or Streaming extensions. C# and JS.

We are working on updates to the Virtual Assistant / Skill template to provide the (small) changes out of the box and provide documentation on the few steps required to update existing Skills. Targeting end of January, with builds on our daily builds soon.

If you are keen to make progress ahead of this the above samples should give you everything you need. I'll update this issue with pointers to daily builds/changes as soon as they are ready.

@darrenj thank you for the this awesome update. I am just curious to know about unified adapter before we start leveraging that in our production Virtual assistant.

Does this mean we can use unified adapter in Typescript VA and can still invoke c# skill ?

A long awaited update!

We posted our 0.8 release yesterday which include an update to all of our sample Skills to support the new GA Skills capability and no longer preview. Websockets has been retired in favour of Web-Service communication between skills, Skills communicate back to the Bot asynchronously using a "callback" HTTP connection.

As a result there are some straight forward updates to existing Virtual Assistant and Skills to be made. C# VA updates are documented here and C# Skill updates are documented here.

The equivalent JS/Typescript generator changes are being finalised as we speak and targeting publishing of a new Generator and docs for existing VA/Skills by 14th February. For background reference, the high level steps to support invoking skills can be found here

Once these changes are complete it means a JS/typescript VA can invoke C# Skills, vice versa and indeed Python too.

@darrenj, any thoughts on above comment about typescript project ?

As per the above, yes there will be some migration steps to follow which we are finalising

Thank you.

Hey @darrenj , any news on when the JS/TS generator changes and doc updates will be released?

hey @darrenj, could you please let us know if the communication from VA (C#) to typescript skill work is done in the new framework (SDK) you menationed above. you have said it would be done by 14th Feb.
appreciate your help

@darrenj any update on this ticket?

@darrenj Today I tried to migrate or make a fix to call C# skill from the VA/RootBot (Typescript). I found the guide to implement skill consumer which does not have typescript rootbot/VA example. Is there any plan to support typescript based migration guide? Do let me know the ETA or anyother guide which can help to achieve the same..

We have a set of Pull Requests in flight for the changes enabling new typescript VA/Skills to use the new GA Skills. I'll update the ticket once we have them merged and daily builds available.

In the meantime here is a draft document on the steps to migrate an existing VA, feedback welcome.

https://github.com/microsoft/botframework-solutions/pull/3123

Hi @darrenj, thanks for the update, the only question I have at the moment is about the 'botbuilder-solutions'. Do we have to use a local version? From where? I found this branch here that looks like the future release (https://github.com/microsoft/botframework-solutions/tree/feature/southworks/0.7/parity-botbuilder-solutions/sdk/typescript/libraries/botbuilder-solutions), is that right?

Thanks in advance.

@Batta32 Can you quickly confirm which branch of code people can use to test the instructions (ahead of the new library being published)

@tommyJimmy87 - you can check the PR #3122 which contains all the needed changes of BotBuilder-Solutions for GA Skills SDK in TypeScript.
Branch: feature/southworks/ga-skills-sdk/botbuilder-solutions

To use the library locally, please follow these steps (using the branch mentioned):

1. Open the library in Visual Studio Code
2. Execute npm install in order to install the dependencies
3. Execute npm run build in order to compile the solution
4. Execute npm pack to create the library .tgz file
5. Open the Virtual Assistant's package.json file in Visual Studio Code
6. Update the botbuilder-solutions' reference pointing to the tgz's path created
7. Execute npm install in order to install the dependencies which will install the local package

We are currently validating these changes, don't hesitate to give any feedback in that PR and we will review them ASAP.

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@darrenj - could you please let us know if the changes mentioned in the below can be done for the connection from VA(C#) to Skill which is node js .

https://microsoft.github.io/botframework-solutions/overview/whats-new/0.8-beta/migrate-existing-va-to-0.8/

Yes - the documentation is in PR and team are wrapping up this work as we speak! (@Batta32). You can see work in progress here: https://github.com/microsoft/botframework-solutions/pull/3123

Along with the associated changes to the SDK: https://github.com/microsoft/botframework-solutions/pull/3122

As promised and thanks for your patience as we worked through a set of changes across the SDKs.

• Steps to update your existing typescript VA to GA BF Skills are here
• Steps to update your existing typescript Skill to GA BF Skills are here

In addition, the next daily builds of the VA generator will have these changes included out of the box. I'll update this issue with the exact version once processed and validated.

This will then be published to npm when we process the 1.0 release which is currently held awaiting an Azure change window. We are hoping by end of month.

Any questions/issues with the above please raise a fresh issue and we're here to help.

@Batta32 for the migration we can start using the botbuilder-solutions 4.5.0-preview ? I guess is the new release for the migration right ?

@Batta32 When will the new SDK be released for use? I am building a VA with 13 skills and one of the requirements is that it be built in TypeScript. I am using the SDK from the Next branch currently to get the project started.

Hi @tommyJimmy87 & @tomSauret847, before they are published you can use the packages published in MyGet as daily builds:

• [email protected]
• [email protected]

To integrate botbuilder-solutions daily build you have two different options, we recommend the first option as it's the easiest one (take into account to remove the package-lock and node_modules of your bots):

• Option 1: Add a .npmrc file pointing to the registry https://botbuilder.myget.org/F/aitemplates/npm, and updating the package.json to point the botbuilder-solutions version to 4.5.0-preview223
• Option 2: Download the tgz of botbuilder-solutions referencing it directly in the package.json with an absolute path

npm pack [email protected] --registry https://botbuilder.myget.org/F/aitemplates/npm

If you want to use the generator-botbuilder-assistant, you should uninstall it if you already have one and then install the one of MyGet:

npm uninstall -g generator-botbuilder-assistant

npm install -g [email protected] --registry https://botbuilder.myget.org/F/aitemplates/npm

@Batta32 Where will we need to report issues we find with the preview builds? I have generated a new VA using the preview generator and used the preview SDK and receiving an error that a invalid dialog is being added when trying to run the VA without any customization.
Error: DialogSet.add(): Invalid dialog being added.

@darrenj - what's the best approach to report the issues of the daily builds?

@tomSauret847 - meanwhile, you can share your issue in this thread with your environment and the repro steps 😊!

The environment is running locally on windows 10 computer
Steps: run preview generator to build blank VA
update appsettings.json and cognitivemodels.json
add .npmrc file pointing to https://botbuilder.myget.org/F/aitemplates/npm
delete node_modules and package-lock.json
run npm install [email protected]
run npm install to install all other packages
run NPM build
run npm run start
then I receive the following error
C:UsersuserDesktopBlankVAtestassistantnode_modulesapplicationinsightsoutAutoCollectionExceptions.js:34
throw THIS_IS_APPLICATION_INSIGHTS_RETHROWING_YOUR_EXCEPTION; // Error originated somewhere else in your app
^

Error: DialogSet.add(): Invalid dialog being added.
at DialogSet.add (C:UsersuserDesktopBlankVAtestassistantnode_modulesbotbuilder-dialogslibdialogSet.js:87:19)
at MainDialog.addDialog (C:UsersuserDesktopBlankVAtestassistantnode_modulesbotbuilder-dialogslibcomponentDialog.js:148:22)
at new MainDialog (C:UsersuserDesktopBlankVAtestassistantlibdialogsmainDialog.js:34:14)
at Object. (C:UsersuserDesktopBlankVAtestassistantlibindex.js:159:24)
at Module._compile (internal/modules/cjs/loader.js:778:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
at Module.load (internal/modules/cjs/loader.js:653:32)
at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
at Function.Module._load (internal/modules/cjs/loader.js:585:3)
at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)

Thanks! We reproduced the issue following your steps, however it's an error in the order how the dependencies are installed causing a conflict when botbuilder-solutions is installed separated the rest.

Try following these steps: (removing the node_modules and package-lock)

1. Update the package.json with the 4.5.0-preview223 version in botbuilder-solutions

1. Install all the dependencies executing npm install
2. Build the solution executing npm run build
3. Start the Virtual Assistant executing npm run start

@tomSauret847 let me know if you see any other issues. We are completing final validation and will push new builds to npm once complete.

Hi @darrenj , I got an error when trying to resolve the lg files with the new template manager, basically what happens is that I'm receiving the locale en-US from MS Teams but I set only en-us ( lower case ) and is not going to be recognized. Maybe adding a lower case here if (this.templateEnginesPerLocale.has(locale))would resolve the problem (LocaleTemplateEngineManager.ts line 61) . To circumvent this problem for the moment I had to add this in my index.ts :

const supportedLocales: string[] = ['en-us', 'en-US','de-de'];

supportedLocales.forEach((locale: string) => {
    const localeTemplateFiles: string[] = [];
    templateFiles.forEach(template => {
        // LG template for en-us does not include locale in file extension.
        if (locale === 'en-us' || locale === 'en-US') {
            localeTemplateFiles.push(path.join(__dirname, 'responses', `${ template }.lg`));
        }
        else {
            localeTemplateFiles.push(path.join(__dirname, 'responses', `${ template }.${ locale }.lg`));
        }
    });

    localizedTemplates.set(locale, localeTemplateFiles);
});

This works well but I don't know if can be done in a better way.

Thanks. @Batta32 - can you check to see if you have the change to LocaleTemplateEngine in the solutions Lib which uses the SDK provided MultiLanguageLG ? I would hope this would elegantly handle mixed case but some tests would be good to validate.

@lzc850612 Can we run a quick validation with the csharp GA RC to double check it works as expected with mixed case locales coming into the Bot on an Activity?

Sure @darrenj, we will be checking that change!

@darrenj thank you for the update on the progress! I had the same locale issue that tommyJimmy pointed but got past it by add locale.toLowerCase in the localeTemplateManager. I am currently attaching a custom skill to the VA but still receiving an error I am trying to track down. The skill is returning a 501 error to the VA but it is processing the message in the onMessage function in the defaultActitivityHandler.ts, it is just not passing the activity over to the main dialog for the skill to process. I added the skill by updating the appSettings.json file, and the skill is receiving the activity.

@Batta32 I was wanting to check if the path forward still includes the localTemplateEngineManager. I noticed it is missing from the preview builds and only responseManager is present. Moving forward are we going to need to use the Response manager or is the Locale template going to be added back?

@Batta32 I was able to track down the error that I was receiving on communicating with a skill from the VA. In the dialogEx module there is a send trace that is sending the trace back to the VA that the skill was started. This sendActivity is throwing the following error when called:
Error: /api/messages/v3/conversations/5659a380-841b-11ea-bed3-831b5a6aa1eb%7Clivechat-dlpskill-emulator-skillconvo/activities/5b61c920-841b-11ea-b148-8581dc55a9bb does not exist
When the conversation ID is appended in SkillConversationIdFactory the skill cannot post back to the new conversation ID.

Update:
I had a typo in the skillHostEndpoint that was causing this issue. Once I corrected that I am now able to attach skills and have them interact with the VA.

@Batta32 @darrenj I'm facing an unexpected behavior when trying to use the chitchat with the VA: basically every time the user asks something to the Bot the introstep will reprompt the initial message, which in the case of chitchat is not great as UX. Is this an expected or I'm missing something?

(the please hold on message is a custom message don't worry about that
)

@Batta32 I was able to track down the error that I was receiving on communicating with a skill from the VA. In the dialogEx module there is a send trace that is sending the trace back to the VA that the skill was started. This sendActivity is throwing the following error when called:
Error: /api/messages/v3/conversations/5659a380-841b-11ea-bed3-831b5a6aa1eb%7Clivechat-dlpskill-emulator-skillconvo/activities/5b61c920-841b-11ea-b148-8581dc55a9bb does not exist
When the conversation ID is appended in SkillConversationIdFactory the skill cannot post back to the new conversation ID.

Update:
I had a typo in the skillHostEndpoint that was causing this issue. Once I corrected that I am now able to attach skills and have them interact with the VA.

@tomSauret847 What was your problem? because I'm having the same error and don't understand what is it. In my Virtual Assistant I have this :
"skillHostEndpoint": "https://1c34e472.ngrok.io/api/skills"
Which is the endpoint of the VA.

Error: /api/skills/v3/conversations/a%3A1QIRXOg6VwVn2aGC-eTj9sj3YYd6YUVrRKf8J7wLrjH1fPYcpn2dYpMyQpr_aHLHSp9Z2SHVzu8lKbdj_ArEh06kvjyF48IG1tgE1ctKTWdIASDloNgy51_eBFoGzwwIN-waSearchSkill-msteams-skillconvo/activities/1588679971133 does not exist at new RestError (/Users/em.tomaselli/Desktop/repository/BMW/wa-search-skill/node_modules/@azure/ms-rest-js/dist/msRest.node.js:1397:28) at /Users/em.tomaselli/Desktop/repository/BMW/wa-search-skill/node_modules/@azure/ms-rest-js/dist/msRest.node.js:1849:37 at process._tickCallback (internal/process/next_tick.js:68:7)

@Batta32 I was able to deploy my VA and 1 skill to Azure. When I use the web chat everything works as expected. When I try to use the teams channel I receive the below error. This seems to be isolated to the Teams channel since the web chat is routing correctly.
Error: Error invoking the skill id: "dlpskill" at "https://{app name}.azurewebsites.net/api/skill/messages" (status is 500).
Error: /api/skills/v3/conversations/a:1lFWWXG9CVtdrkA76VLFeS9CbYWzsHVr9mQ4S7BqDpL4K5WNIc0ND6mqaaj_QsSqH-qUU-Gb2vLX3HQ4CpG3ZDPCbR0XKLtJGOqW0kwKUbe2HKv5C9fs1sjLSO4EvoE5h-dlpskill-msteams-skillconvo/activities/1588712064379 does not exist
at SkillDialog. (D:homesitewwwrootnode_modulesbotbuilder-dialogslibskillDialog.js:164:23)
at Generator.next ()
at fulfilled (D:homesitewwwrootnode_modulesbotbuilder-dialogslibskillDialog.js:11:58)
at process._tickCallback (internal/process/next_tick.js:68:7)

@tommyJimmy87 I was not using ngrok to communicate from VA to skill locally so I was able to use the localhost:3979/api/skills for the skillHostEndpoint and was able to reach the skill. Since you are using the Teams channel as well I will say this is a issue with the Teams channel. You can try reaching the skill using the web chat and see if you can communicate with the skill from the VA in azure.

Hi @Batta32, I agree with @tomSauret847 that most likely there's some kind of problem whit the Teams Channel.

After a bit of debugging I might try to explain what I have found out:

1) In the ChannelServiceHandlerall the methods are not implemented, meaning that when one of the /api/skills is called will everytime return an error code;

i.e. File : ChannelServiceHandler.ts (botbuilder) , line : 219

    protected async onGetActivityMembers(claimsIdentity: ClaimsIdentity, conversationId: string, activityId: string): Promise<ChannelAccount[]> {
        throw new StatusCodeError(StatusCodes.NOT_IMPLEMENTED, `ChannelServiceHandler.onGetActivityMembers(): ${StatusCodes.NOT_IMPLEMENTED}: ${STATUS_CODES[StatusCodes.NOT_IMPLEMENTED]}`);
    }

2) /api/skills/v3/conversations/a%3A1QIRXOg6VwVn2aGC-eTj9sj3YYd6YUVrRKf8J7wLrjH1fPYcpn2dYpMyQpr_aHLHSp9Z2SHVzu8lKbdj_ArEh06kvjyF48IG1tgE1ctKTWdIASDloNgy51_eBFoGzwwIN-waSearchSkill-msteams-skillconvo/activities/1588761991793 In this case instead there's some problem in parsing the conversation ID and the error result is always that the resource doesn't exists, but if you try to call the same URL changing the conversationId with a simpler string it will work ( but the result will be still that the method is not implemented because of the previous point).

Hi @tommyJimmy87, @tomSauret847 - sorry for the delay. We will be reviewing the Teams Channel's scenario using the GA Skills SDK changes and we will back to this thread later 😊.

@tommyJimmy87 - we successfully reproduced the issue using Microsoft Teams Channel. We will back to this thread as soon as we fix the problem.

Thanks!

Hi @tommyJimmy87, @tomSauret847, we successfully found the reason of the problem.

The problem is that the _':'_ character is being replaced to _'%3A'_ when the activities are sent back to the Virtual Assistant from the Skill, generating the mismatching of _conversationId_ between both bots.
Apparently, this behavior is executed in axios dependency replacing the characters as mentioned.

Last but not least, there is an issue in microsoft/botbuilder-js#2182 which replaces axios in botbuilder and it's tagged to be ready for _R10_.

We are going to update the Known Issues document explaining the problem

Finally, we will be back to this thread as soon as we have new updates for you guys 😊

_Mismatching of conversationIds_

_axios dependency replaces ':' to '%3A'_

@Batta32 Do you think will be fixed soon or will take a bit of time?

@tommyJimmy87, @tomSauret847 - we noticed that the problem is in ms-rest-js instead of axios.

The problem is a mismatch of conversationId between the Skill and the Virtual Assistant. This issue is raised because the _':'_ character of the _conversationId_ from Teams is being replaced to _'%3A'_ which should be replaced back to _':'_. The last conversion is not implemented in sendOperationRequest as _axios_ does.

Sorry for the mistake 😊.

_encodeURIComponent doesn't replace the '%3A' back to ':'_

_Differences of encoding between axios and ms-rest-js_

@Batta32 the default agent for ms-rest-js versions < 2.0 is axios https://github.com/Azure/ms-rest-js/blob/1.x/lib/axiosHttpClient.ts

I think one way to resolve this issue would be to use encodeURI within the SkillConversationIdFactory implementation. This way, the underlying agent will not alter the conversation.id from what is stored within the factory.

Thanks @EricDahlvang, we will be reviewing the alternative of use encodeURI within SkillConversationIdFactory!

@EricDahlvang - adding the encodeURI in the SkillConversationIdFactory doesn't fix the issue as the Skill is already encoding the conversationId before sending the activities back to the Virtual Assistant.

We realized that the issue might be related to the conversationId's length when it's received from Microsoft Teams. We noticed that using the original conversationId the VA's endpoint is not hitted, however, trimming some characters from the conversationId is correctly hitted.

Last but not least, this issue is not present in C#.

_The endpoint is not hitted with the original conversationId_

_The endpoint is hitted with the trimmed conversationId_

_The issue is not present in C#_

@Batta32 If the SkillConversationIdFactory uses encodeURI, then the skill will receive that conversation.id and respond to it accordingly. I'm pretty sure this is required.

Also yes, there is an issue with long conversation ids while using restify. We make mention of how to resolve the issue in this sample: https://github.com/microsoft/BotBuilder-Samples/blob/master/samples/javascript_nodejs/80.skills-simple-bot-to-bot/simple-root-bot/skillConversationIdFactory.js#L21

// This key has a 100 character limit by default. Increase with restify.createServer({ maxParamLength: 1000 }); in index.js.

@EricDahlvang Thank you for this information. I added the update to both my VA and skill. I am now able to get the VA to communicate with the skill in the Teams channel without error.

Thanks @EricDahlvang for the provided information! We created the PR #3359 improving the maxParamLength and also updating the version of @types/restify@^8.4.2.

Thanks guys @tommyJimmy87, @tomSauret847, as soon as these changes are merged, you will be able to test it 😊.

@Batta32 sorry to bother you again, first of all, I applied the changes and now it is working. Now I have a problem with the update activity of skill through the VA, within the SkillHandler there's no implementation for that, could you provide one? Thx

Hi @tommyJimmy87, we noticed that the SkillHandler in C# and JS doesn't contain the onUpdateActivity() as you mentioned, meanwhile you can add your own handler extending from SkillHandler or ChannelServiceHandler.

@darrenj - can you confirm that the absence of onUpdateActivity() method in the SkillHandler is correct or is there any plan to implement it?

@Batta32 I actually tried this, the implementation looks like this :

    protected async onUpdateActivity(claimsIdentity: ClaimsIdentity, conversationId: string, activityId: string, activity: Activity): Promise<ResourceResponse> {
        return await this.updateActivity(claimsIdentity, conversationId, activityId, activity);
    }

And the updateActivity function is the following:

private async updateActivity(claimsIdentity: ClaimsIdentity, conversationId: string, replyToActivityId: string, activity: Activity): Promise<ResourceResponse> {

        let skillConversationReference: SkillConversationReference;
        try {
            skillConversationReference = await this.conversationIdFactory.getSkillConversationReference(conversationId);
        } catch (err) {
            // If the factory has overridden getSkillConversationReference, call the deprecated getConversationReference().
            // In this scenario, the oAuthScope paired with the ConversationReference can only be used for talking with
            // an official channel, not another bot.
            if (err.message === 'Not Implemented') {
                const conversationReference = await this.conversationIdFactory.getConversationReference(conversationId);
                skillConversationReference = {
                    conversationReference,
                    oAuthScope: JwtTokenValidation.isGovernment(this.channelService) ?
                        GovernmentConstants.ToChannelFromBotOAuthScope :
                        AuthenticationConstants.ToChannelFromBotOAuthScope
                };
            } else {
                // Re-throw all other errors. 
                throw err;
            }
        }

        if (!skillConversationReference) {
            throw new Error('skillConversationReference not found');
        }
        if (!skillConversationReference.conversationReference) {
            throw new Error('conversationReference not found.');
        }

        const activityConversationReference = TurnContext.getConversationReference(activity);

        /**
         * Callback passed to the BotFrameworkAdapter.createConversation() call.
         * This function does the following:
         *  - Caches the ClaimsIdentity on the TurnContext.turnState
         *  - Applies the correct ConversationReference to the Activity for sending to the user-router conversation.
         *  - For EndOfConversation Activities received from the Skill, removes the ConversationReference from the
         *    ConversationIdFactory
         */
        const callback = async (context: TurnContext): Promise<void> => {
            const adapter: BotFrameworkAdapter = (context.adapter as BotFrameworkAdapter);
            // Cache the ClaimsIdentity and ConnectorClient on the context so that it's available inside of the bot's logic.
            context.turnState.set(adapter.BotIdentityKey, claimsIdentity);
            context.turnState.set(this.SkillConversationReferenceKey, activityConversationReference);
            activity = TurnContext.applyConversationReference(activity, skillConversationReference.conversationReference) as Activity;
            const client = adapter.createConnectorClient(activity.serviceUrl);
            context.turnState.set(adapter.ConnectorClientKey, client);

            context.activity.id = replyToActivityId;
            await context.updateActivity(context.activity);
            return;
        };

        // Add the channel service URL to the trusted services list so we can send messages back.
        // the service URL for skills is trusted because it is applied based on the original request
        // received by the root bot.
        AppCredentials.trustServiceUrl(skillConversationReference.conversationReference.serviceUrl);

        await (this.adapter as BotFrameworkAdapter).continueConversation(skillConversationReference.conversationReference, skillConversationReference.oAuthScope, callback);
        return { id: uuid() };
    }

It's basically a copy of the processActivity function that is already implemented in the SkillHandler but calling the context.updateActivity(context.activity) at the end.

Said that I'm getting this error :

(node:68325) UnhandledPromiseRejectionWarning: Error: Failed to decrypt conversation id 

Probably there's something that I'm missing or I'm doing wrong.

@tommyJimmy87 - we will try to reproduce your scenario and we will back to you later 😊.

@Batta32 I noticed on the "Help card" with the Virtual assistant that it is not displaying the help card for the active skill. When you hit the "help" interrupt while in the skill dialog it is still presenting the help card for the VA and not the skill. I have updated to the last release that included setting the activeSkillProperty state with the skill that is active. Any ideas on how to fix this issue? Logging out the state the active dialog is still registered as a dialog I have in the VA and not the active skill.

Hi @tommyJimmy87, @tomSauret847, thanks for reporting these issues.

As [email protected], [email protected] and [email protected] are published in npmjs and merged in branch master, you can create the issues in the repository in order to explain better the problem and we will follow up them 😊.