Celery: Python 3.7 syntax error: async is a reserved keyword

Created on 26 Jun 2018 · 17Comments · Source: celery/celery

Checklist

Happens on master and previously released versions as well.

Steps to reproduce

See https://github.com/celery/celery/blob/b2668607c909c61becd151905b4525190c19ff4a/celery/backends/redis.py#L22 and https://github.com/celery/celery/blob/b2668607c909c61becd151905b4525190c19ff4a/celery/backends/rpc.py#L20 and https://github.com/celery/celery/blob/master/celery/backends/async.py

Expected behavior

Module should not be named async.

Actual behavior

Module is named async.

More info

I fail to run 3.7 test easily, but this leads to:

  File "celery/backends/redis.py", line 22
    from . import async, base
                      ^
SyntaxError: invalid syntax

Source

hroncok

👍16 ❤1

Most helpful comment

If anyone needs the changes right now then you can do pip install --upgrade https://github.com/celery/celery/tarball/master to get the fixes temporarily directly from development branch. Maybe it saves people finding this issue from Google some effort.

Avamander on 11 Jul 2018

👍19 🎉7 ❤3

All 17 comments

Nice catch. This is already handled in #4500. The module will be renamed to asynchronous soon. @auvipy should we close as duplicate?

georgepsarakis on 26 Jun 2018

Sure. Sorry I haven't noticed that one.

hroncok on 26 Jun 2018

i will take care of this today

auvipy on 27 Jun 2018

Since #4500 is closed, I'm reopening this one.

hroncok on 29 Jun 2018

yeah ok I have already started working

auvipy on 29 Jun 2018

work in progress https://github.com/celery/celery/pull/4852

auvipy on 5 Jul 2018

work is merged in master

auvipy on 9 Jul 2018

❤4 👍3 🎉2

Can we anticipate a quick release or not? Just want to make sure whether we need to patch the Fedora package or wait.

hroncok on 9 Jul 2018

we have a plan to release a minor on before the end of this month

auvipy on 9 Jul 2018

Thanks.

hroncok on 9 Jul 2018

Avamander on 11 Jul 2018

👍19 🎉7 ❤3

I'm still getting this error when trying to run celery 4.2.1, will this fix be available in an upcoming release?

sklarsa on 28 Aug 2018

yes, try master branch if you are in hurry for python 3.7

auvipy on 29 Aug 2018

👎4

Yup, would be nice to have this fix released soon, since Python 3.7 is the default you get on python.org / homebrew etc.

For anyone looking for a way to install Celery from master using Pipenv:

pipenv install -e git+https://github.com/celery/celery.git@master#egg=celery

metakermit on 5 Sep 2018

👍1

OK, correction – the above doesn't work in pipenv (at least not as part of a Docker build with a step RUN pipenv install --system --dev). I'm getting ImportErrors for celery not being there (I think it's because it gets placed in some local src folder that doesn't remain there for some reason).

I've also tried the following:

pipenv install https://github.com/celery/celery/tarball/master

in which case celery does get installed and can get imported, but it seems that this command doesn't install the dependencies… (might be related to this issue)

web_1     |   File "/usr/local/lib/python3.7/site-packages/celery/five.py", line 7, in <module>
web_1     |     import vine.five
web_1     | ModuleNotFoundError: No module named 'vine'

So, Celery is now broken if you want to use latest stable Python, Pipenv + Docker 😢.

metakermit on 20 Sep 2018

Regarding installation of Celery from GitHub as editable which seems to be a Pipenv issue, I've opened a bug there.

metakermit on 20 Sep 2018

better stick with python 3.6 for celery 4.2, there are some other small issues regarding python 3.7 in the dependencies.

auvipy on 20 Sep 2018

Was this page helpful?

0 / 5 - 0 ratings