Distributor: Bulk Skip function erroneously pulls posts

Created on 9 Jul 2020  ·  5Comments  ·  Source: 10up/distributor

Describe the bug
In working to update the screenshots for the Distributor microsite today I ran into and issue when pulling content across External Connections and using bulk skip it instead pulls the content. Individual row links for skip work correctly though. A workaround for now would be to delete the mistakenly pulled post.

Steps to Reproduce

  1. Go to Distributor > Pull Content
  2. Select multiple posts
  3. Change bulk dropdown to "Skip"
  4. Click "Apply"
  5. See that posts now appear in "Pulled" section as well as locally referenced posts in the All Posts list table.

Expected behavior

  1. See that posts now appear in "Skipped" section.

Screenshots

Environment information

  • Device: Mac mini (2018)
  • OS: macOS 10.15.5
  • Browser and version: Firefox 78.0.1
  • WordPress version: 5.4.2
  • Site Health Info:
### wp-core ###

version: 5.4.2
site_language: en_US
user_language: en_US
timezone: +00:00
permalink: /%postname%/
https_status: false
user_registration: 0
default_comment_status: open
multisite: false
user_count: 3
dotorg_communication: true

### wp-paths-sizes ###

wordpress_path: /Users/jeffpaul/Local Sites/distributor-wpe/app/public
wordpress_size: 39.45 MB (41366248 bytes)
uploads_path: /Users/jeffpaul/Local Sites/distributor-wpe/app/public/wp-content/uploads
uploads_size: 56.27 KB (57625 bytes)
themes_path: /Users/jeffpaul/Local Sites/distributor-wpe/app/public/wp-content/themes
themes_size: 3.96 MB (4153984 bytes)
plugins_path: /Users/jeffpaul/Local Sites/distributor-wpe/app/public/wp-content/plugins
plugins_size: 6.35 MB (6660681 bytes)
database_size: 2.19 MB (2293760 bytes)
total_size: 52.01 MB (54532298 bytes)

### wp-active-theme ###

name: Twenty Twenty (twentytwenty)
version: 1.4
author: the WordPress team
author_website: https://wordpress.org/
parent_theme: none
theme_features: automatic-feed-links, custom-background, post-thumbnails, custom-logo, title-tag, html5, align-wide, responsive-embeds, customize-selective-refresh-widgets, editor-color-palette, editor-font-sizes, editor-styles, widgets, menus, editor-style
theme_path: /Users/jeffpaul/Local Sites/distributor-wpe/app/public/wp-content/themes/twentytwenty

### wp-themes-inactive (2) ###

Twenty Nineteen: version: 1.6, author: the WordPress team
Twenty Seventeen: version: 2.3, author: the WordPress team

### wp-plugins-active (2) ###

Distributor: version: 1.6.0, author: 10up Inc.
Simple Local Avatars: version: 2.1.1, author: Jake Goldman, 10up

### wp-plugins-inactive (2) ###

Classic Editor: version: 1.5, author: WordPress Contributors
Gutenberg: version: 8.5.0, author: Gutenberg Team

### wp-media ###

image_editor: WP_Image_Editor_GD
imagick_module_version: Not available
imagemagick_version: Not available
gd_version: bundled (2.1.0 compatible)
ghostscript_version: not available

### wp-server ###

server_architecture: Darwin 19.5.0 x86_64
httpd_software: nginx/1.16.0
php_version: 7.3.5 64bit
php_sapi: fpm-fcgi
max_input_variables: 4000
time_limit: 1200
memory_limit: 256M
max_input_time: 600
upload_max_size: 300M
php_post_max_size: 1000M
curl_version: 7.54.0 LibreSSL/2.6.5
suhosin: false
imagick_availability: false
htaccess_extra_rules: false

### wp-database ###

extension: mysqli
server_version: 8.0.16
client_version: mysqlnd 5.0.12-dev - 20150407 - $Id: 7cc7cc96e675f6d72e5cf0f267f48e167c2abb23 $

### wp-constants ###

WP_HOME: undefined
WP_SITEURL: undefined
WP_CONTENT_DIR: /Users/jeffpaul/Local Sites/distributor-wpe/app/public/wp-content
WP_PLUGIN_DIR: /Users/jeffpaul/Local Sites/distributor-wpe/app/public/wp-content/plugins
WP_MAX_MEMORY_LIMIT: 256M
WP_DEBUG: false
WP_DEBUG_DISPLAY: true
WP_DEBUG_LOG: false
SCRIPT_DEBUG: false
WP_CACHE: false
CONCATENATE_SCRIPTS: undefined
COMPRESS_SCRIPTS: undefined
COMPRESS_CSS: undefined
WP_LOCAL_DEV: undefined
DB_CHARSET: utf8
DB_COLLATE: undefined

### wp-filesystem ###

wordpress: writable
wp-content: writable
uploads: writable
plugins: writable
themes: writable

### distributor ###

0: 1.6.0
1: Yes
2: [email protected]
3: 
    Override Author Byline: No
    Media Handling: Featured image only
4: N/A
5: 
    YosemiteParkExplorer.com: 
- URL: http://distributor-ype.local/wp-json/
- Version: 1.6.0
- Status: valid
- Auth method: Username / Password
- Username: jeffpaul
- Roles Allowed to Push: administrator, editor
- Additional data: {"errors":[], "can_post":["post", "page", "attachment", "wp_block"], "can_get":["post", "page", "attachment", "wp_block"], "endpoint_suggestion":false}

Additional context

Let's ensure we add tests to cover the bulk pull/skip options as well as the row link pull/skip options to avoid this regression in the future.

bug help wanted tests needed

All 5 comments

@jeffpaul I can work on this issue.

@jeffpaul I tried to reproduce this issue in my local but I couldn't able to reproduce this.

https://user-images.githubusercontent.com/6737105/107647301-025b3b80-6ca1-11eb-8042-faf19b059b4a.mp4

@dhanendran I just tested and it looks like this occurs, but ONLY for the bulk action at the bottom of the list table. Mind re-testing on your local using the bottom bulk action dropdown?

@jeffpaul that's right, the bottom one isn't working as expected. I will get on to the fix now.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jeffpaul picture jeffpaul  ·  4Comments

mikelking picture mikelking  ·  5Comments

hreimer picture hreimer  ·  5Comments

dleeward picture dleeward  ·  7Comments

avag-novembit picture avag-novembit  ·  3Comments