Django-debug-toolbar: Incompatibility of django-toolbar 1.8 and django-extensions 2.2.1 caused by get_version method

Created on 20 Aug 2019  ·  4Comments  ·  Source: jazzband/django-debug-toolbar

Django-toolbar version : 1.8
Django-extensions version : 2.2.1

When using this 2 apps in conjunction, it breaks with message : TypeError at / get_version() missing 1 required positional argument: 'version'

Indeed django-toolbar uses the get_version attribute of django-extensions (ref code) but this function expects an positional argument (ref code)

A potential fix could be to wrap the call to app.get_version in a try..catch block but I am not sure it is the nicest way to go.

Many thanks for the great work on djtoolbar,

Most helpful comment

Actually it is fixed in djangodebug-toolbar 2.0 (ref), so not a problem anymore !

Closing, feel free to reopen if needed.

All 4 comments

By randomly trying various combos, I found that debug toolbar v1.6 and dj extensions 2.0.8 work together.

It's not my itch to scratch but I'd certainly review (& merge) a pull request fixing this.

OK @matthiask I will give it a try.

@liavkoren yes indeed for these versions there is no get_version function in django_extensions (ref)

Actually it is fixed in djangodebug-toolbar 2.0 (ref), so not a problem anymore !

Closing, feel free to reopen if needed.

Was this page helpful?
0 / 5 - 0 ratings