Django-grappelli: Support Django 2.0
Slated to be released in December, adding support for Django 2.0 would be amazing. Last release RC1 happened 2 weeks ago, here is the announcement.
First and foremost because of the mobile-friendly contrib.admin. I haven't had a chance to play around with it, but I bet they added responsive styles for inlines as well. This may be a lot of work, but I think the community would be happy to help out, I know I would myself!
Let's use this issue to discuss the roadmap (Target 3.X ?) and list the individual parts that need to be changed, to assist contributors with short concise PRs where possible.
asfaltboy
All 11 comments
Thanks for the heads up. We'll do another release (2.10.2) before dealing with Django 2.0. Besides, I don´t think we´ll support mobile devices with Grappelli.
sehmaschine
on 4 Dec 2017
Before talking UI refinements, the first step should be too make the current code compatible with Django 2.0.
The following imports need to be replaced: from django.core.urlresolvers import reverse
tdruez
on 6 Dec 2017
I have a fork that I changed the imports with here: https://github.com/dstrohl/django-grappelli do you want me to do a pull request? (which branch?)
dstrohl
on 8 Dec 2017
@dstrohl I'm not sure about @sehmaschine , but if you ask me, GO FOR IT. Does your fork pass tests under 2.0?
mpasternak
on 11 Dec 2017
@dstrohl Sounds good. But please note that we´ll do another release before actually dealing with django 2.0. IMO, the best option is to wait for our upcoming release (which should happen this or next week). Otherwise, there are probably conflicts with your PR.
sehmaschine
on 11 Dec 2017
There´s now a branch stable/2.11.x – please refer to this branch for any PR.
sehmaschine
on 18 Dec 2017
it didn't, but the tests seemed to be mostly solved by fixing a couple of
imports. However, I dropped Django 2.0 for now due to some pretty serious
problems with migrations and many to many fields so I didnt' finish it.
but it looks like it should not be very hard to get it working with 2.0.
On Mon, Dec 11, 2017 at 1:46 AM, Michał Pasternak notifications@github.com
wrote:
@dstrohl https://github.com/dstrohl I'm not sure about @sehmaschine
https://github.com/sehmaschine , but if you ask me, GO FOR IT. Does
your fork pass tests under 2.0?—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sehmaschine/django-grappelli/issues/825#issuecomment-350672915,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJVOPBhuEjuet83-IeXeYoMDRDu95UAXks5s_PnlgaJpZM4QutSe
.
dstrohl
on 21 Jan 2018
@sehmaschine stable/2.11.x is running along Django 2.0.1 in my codebase. Everything works fine.
Any plans for an official Grappelli 2.11 release?
tdruez
on 22 Jan 2018
@tdruez I just waited for some styling issues to be resolved with 2.10.2 and we´ll release 2.10.2 and 2.11.1 later this week.
sehmaschine
on 23 Jan 2018
Sounds great, thanks!
tdruez
on 23 Jan 2018
done
sehmaschine
on 27 Jan 2018
Related issues
karansag
·
55Comments
adamchainz
·
24Comments
ndrsn
·
31Comments
johncpang
·
4Comments
FrozenAlex
·
15Comments
Most helpful comment
Before talking UI refinements, the first step should be too make the current code compatible with Django 2.0.
The following imports need to be replaced:
from django.core.urlresolvers import reverse