Edge-home-orchestration-go: [MNEDC] Refactoring in terms of Architecture

Created on 16 Nov 2020  ·  5Comments  ·  Source: lf-edge/edge-home-orchestration-go

I think that the mnedcmgr function should be under the discoverymgr since they are similar with respect to functionality.
How about moving the mnedcmgr code under the discoverymgr?
Below should be changed.

  • [x] Change package name from mnedcmgr to mnedc or something.
  • [ ] The discoverymgr should call StartMNEDCServer() and StartMNEDCClient().

Any comments are welcome!

question refactoring

Most helpful comment

@t25kim @MoonkiHong : We checked this modification. Seem to involve cyclical importing which Go doesn't support. So we are checking on changing the same and testing.

All 5 comments

@ayush-kr @suresh-lc What about your opinion (from the contributors' perspective)?

I think that the mnedcmgr function should be under the discoverymgr since they are similar with respect to functionality.
How about moving the mnedcmgr code under the discoverymgr?
Below should be changed.

  • [ ] Change package name from mnedcmgr to mnedc or something.
  • [ ] The discoverymgr should call StartMNEDCServer() and StartMNEDCClient().

Any comments are welcome!

@t25kim Thank you for a great suggestion. We will estimate its feasibility to migrate the functions of the mnedcmgr into discoverymgr with regarding contributors of mnedc.

@t25kim @MoonkiHong : We checked this modification. Seem to involve cyclical importing which Go doesn't support. So we are checking on changing the same and testing.

@t25kim @MoonkiHong : We checked this modification. Seem to involve cyclical importing which Go doesn't support. So we are checking on changing the same and testing.

@suresh-lc Thank you for your prompt analysis. As you suggested, let us discuss further about the best approach once you completed the check-up on changing the same and testing stuff, especially about the _cyclical importing which GoLang does not support_. We will wait for your updates. ^^

This issue is still valid since the latest merged PR #178 resolved Change package name from mnedcmgr to mnedc or something..

Was this page helpful?
0 / 5 - 0 ratings

Related issues

DoomsdayT picture DoomsdayT  ·  3Comments

t25kim picture t25kim  ·  3Comments

MoonkiHong picture MoonkiHong  ·  4Comments

t25kim picture t25kim  ·  4Comments

t25kim picture t25kim  ·  3Comments