Fresco: placeholder roundCorner to do work

Created on 15 Mar 2018  ·  4Comments  ·  Source: facebook/fresco

app:placeholderImage="@drawable/smart_video_default_cover" app:placeholderImageScaleType="fitXY" app:roundBottomLeft="false" app:roundBottomRight="false" app:roundTopLeft="true" app:roundTopRight="true" app:roundedCornerRadius="10dp"

Here is my source code , the placeholderImage is a nine-patch drawable, then the roundedCorner to not work when show placeholder. If set a normal drawable to placeholderImage, the roundedCorner works well.

enhancement help wanted

Most helpful comment

@zhangxu1005 if you're able to share the nine-patch image you're using, I'll take a look at reproducing this and have a go at implementing a fix.

All 4 comments

I think we might not properly handle 9patch images with rounded corners. You can manually create a rounded corner version in code and set it.

We'd appreciate help with implementing this if you or somebody else wants to add this feature.

@zhangxu1005 if you're able to share the nine-patch image you're using, I'll take a look at reproducing this and have a go at implementing a fix.

oscar_default_image 9

@jnawaz Thanks~

Fixed in e1aa81f797583c244817fc334395a13d0e33b3bc

Was this page helpful?
0 / 5 - 0 ratings