Gin: GET and POST together, the same handler.
I'm trying to use gqlgen (https://github.com/99designs/gqlgen) with gin.
I'm using the code below but I have doubts.
package server
import (
"myProject/graphql"
"github.com/99designs/gqlgen/handler"
"github.com/gin-gonic/gin"
)
func Start() {
r := gin.Default()
r.GET("/query", gin.WrapH(handler.Playground("GraphQL playground", "/api")))
r.GET("/api", gin.WrapH(handler.GraphQL(graphql.NewExecutableSchema(graphql.Config{Resolvers: &graphql.Resolver{}}))))
r.POST("/api", gin.WrapH(handler.GraphQL(graphql.NewExecutableSchema(graphql.Config{Resolvers: &graphql.Resolver{}}))))
r.Run()
}
As you can see I need to repeat the lines:
r.GET("/api", gin.WrapH(handler.GraphQL(graphql.NewExecutableSchema(graphql.Config{Resolvers: &graphql.Resolver{}}))))
r.POST("/api", gin.WrapH(handler.GraphQL(graphql.NewExecutableSchema(graphql.Config{Resolvers: &graphql.Resolver{}}))))
Is this correct?
Can I just have GET and POST both with the same handler function?
(I opened https://github.com/99designs/gqlgen/issues/418 for this problem).
frederikhors
All 3 comments
Gin uses httprouter router and according to source code from THIS STRING it is impossible.
BTW
I can't even imagine what are you going to do with GET and POST on the same action
olegsobchuk
on 8 Nov 2018
Why don't you just
graphHandler := gin.WrapH(handler.GraphQL(graphql.NewExecutableSchema(graphql.Config{Resolvers: &graphql.Resolver{}})))
r.GET("/api", graphHandler)
r.POST("/api", graphHandler)
yes, this still repeats the line, but makes modifiying it easier.
I have to agree with @olegsobchuk , in a normal WebAPI GET and POST would do different things, and therefor have different handlers - but people do what they do
Kirides
on 7 Dec 2018
👍2
router.GET("/a/b", h)
router.POST("/a/b", h)
it's ok!
thinkerou
on 14 Jan 2019
👍1
Was this page helpful?
0 / 5 - 0 ratings
Related issues
kekemuyu
·
3Comments
cxk280
·
3Comments
ccaza
·
3Comments
ghost
·
3Comments
gplume
·
3Comments
Most helpful comment
Why don't you just
yes, this still repeats the line, but makes modifiying it easier.
I have to agree with @olegsobchuk , in a normal WebAPI GET and POST would do different things, and therefor have different handlers - but people do what they do