Githawk: Bookmark test failing

Created on 5 Nov 2017  ·  3Comments  ·  Source: GitHawkApp/GitHawk

https://dashboard.buddybuild.com/apps/59d904ff8588d60001729c4e/build/59ff60e1a8cf4d0001a7e4c2#logs

    Failing tests:
        BookmarkStoreTests.test_duplicateBookmarks()
    ** TEST FAILED **
🐛 bug
Source
picture rnystrom

All 3 comments

First local test run, all green. After another run test_bookmarksFromDifferentUser fails.

Seems like there is some state sticking around between test runs or something.

rnystrom picture rnystrom on 5 Nov 2017

Yup, these tests are initializing new stores and then never clearing state, so they just needlessly accumulate stuff and disk and fail after the first run. cc @rizwankce

rnystrom picture rnystrom on 5 Nov 2017
👍1

Also hashValue is for Hashable, NSObject subclasses w/ custom hash+equality need to override hash and isEqual. Lastly, updating the equality method to actually check all values.

rnystrom picture rnystrom on 5 Nov 2017
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

BasThomas picture BasThomas  ·  3Comments
rnystrom picture rnystrom  ·  3Comments
BasThomas picture BasThomas  ·  3Comments
rnystrom picture rnystrom  ·  3Comments
rnystrom picture rnystrom  ·  3Comments