Haml: Ruby 2.4.0 bug 12782

Created on 23 Mar 2017 · 4Comments · Source: haml/haml

Cross posting Tilt issue #311 as it's relevant here too (unless you say otherwise)

Hi,

I've just upgraded to Ruby v2.4.0 and appear to have been bitten by the bug described on the Ruby bug tracker.

myproj/vendor/ruby/2.4.0/gems/tilt-2.0.6/lib/tilt/haml.rb:50:in `block in precompiled_postamble': Haml::Engine#precompiled_method_return_value at /opt/rubies/ruby-2.4.0/lib/ruby/2.4.0/forwardable.rb:156 forwarding to private method Haml::TempleEngine#precompiled_method_return_value

They appear to have decided to revert the change that caused it, but to add warnings, probably to nudge people to stop forwarding to private methods. I thought I'd be helpful and open this issue ahead of time. Or for it to be fixed immediately (no pressure;)

Regards,
iain

ruby 2.4.0p0 (2016-12-24 revision 57164) [x86_64-darwin13]
Tilt v2.0.6
Haml v4.0.7 and 5.0.0.beta.2

Source

yb66

Most helpful comment

Fixed this in stable branch https://github.com/haml/haml/commit/ac290b53d00158ebf031166459e20fa305c1113d. Please wait for new 4.0.x release.

And for Haml 5, I opened https://github.com/rtomayko/tilt/pull/312. Since there's nothing to do in Haml side, closing this issue.

k0kubun on 28 Mar 2017

👍2 😕1

All 4 comments

We have API exactly for this problem https://github.com/haml/haml/pull/896.

I'll use it for Haml 5 and fix it in another way in Haml 4, considering Haml 4 is already in stable branch.

k0kubun on 23 Mar 2017

Fixed this in stable branch https://github.com/haml/haml/commit/ac290b53d00158ebf031166459e20fa305c1113d. Please wait for new 4.0.x release.

And for Haml 5, I opened https://github.com/rtomayko/tilt/pull/312. Since there's nothing to do in Haml side, closing this issue.

k0kubun on 28 Mar 2017

👍2 😕1

Thanks, much appreciated.

yb66 on 28 Mar 2017

Fixed this in stable branch ac290b5. Please wait for new 4.0.x release.

It seems like there has never been another 4.0.x release? Or am I missing something? (I would like to move to 5 but have not been able to yet because it breaks my app #770 )

Edited to add: Just noticed the addition of options.escape_filter_interpolations ... That'll work.