Jekyll: Include default theme as a dependency
If a new Jekyll user follows the instructions on the homepage of http://jekyllrb.com/, it fails :/
❯ jekyll -v
jekyll 3.2.0
❯ jekyll new website && cd website
New jekyll site installed in /Users/frank/code/website.
❯ jekyll serve
Could not find gem 'minima' in any of the gem sources listed in your Gemfile or available on this machine.
Run `bundle install` to install missing gems.
From now on you can install gem-based themes but as the default theme shouldn't minima be included to jekyll dependencies?
DirtyF
All 4 comments
Ran into this via https://travis-ci.org/github/pages-gem/jobs/148042719#L320 when bumping the Pages Gem as well. I'd be in favor of including this (and only this) theme as a dependency, because adding it to the resulting site's Gemfile and then asking the user to run bundle a second time feels like a lot of work for your first site, especially since the dependency is small. Also to note, I'd suggest it be a very loose dependency, so we can bump Minima without needing to bump Jekyll.
benbalter
on 28 Jul 2016
@DirtyF assuming others agree, any interest in starting a quick PR to add it to the Gemspec?
benbalter
on 28 Jul 2016
@benbalter done, I simply expect a minor version bump from default theme when https://github.com/jekyll/minima/pull/6 gets merged.
DirtyF
on 28 Jul 2016
Chatted with @benbalter and came to a consensus that we should encourage the following flow:
gem install jekylljekyll new my-new-sitecd my-new-sitebundle install<--bundle exec jekyll serve
Bundler is one of the few tools that I use constantly when working with Ruby projects. While it is "just an implementation detail" that Jekyll uses Ruby, Jekyll uses Ruby and should therefore follow its best practices wherever applicable.
We may need to update documentation and/or update the installation message, but we should be promoting bundler everywhere for the Greatest Good of Our People.
parkr
on 28 Jul 2016
Related issues
PJOssenbruggen
·
3Comments
mgiuffrida
·
4Comments
weilinzung
·
3Comments
JohnStarich
·
4Comments
jekyllbot
·
3Comments
Most helpful comment
Chatted with @benbalter and came to a consensus that we should encourage the following flow:
gem install jekylljekyll new my-new-sitecd my-new-sitebundle install<--bundle exec jekyll serveBundler is one of the few tools that I use constantly when working with Ruby projects. While it is "just an implementation detail" that Jekyll uses Ruby, Jekyll uses Ruby and should therefore follow its best practices wherever applicable.
We may need to update documentation and/or update the installation message, but we should be promoting bundler everywhere for the Greatest Good of Our People.