Jshint: JSHint marks "javascript:void(0);" as a JS URL
If I assign an element's href to javascript:void(0); (as opposed to #), like so:
$('#foobar').attr("href", "javascript:void(0);");
JSHint picks up the javascript:void(0); construct as a Script URL:
PS C:\Users\hal9000\Development\strugee.github.com> grunt lint
Running "jshint:all" (jshint) task
js\main.js
30 | $('#lightbulb-icon').attr("href", "javascript:void(0);");
^ Script URL.
>> 1 error in 4 files
when in fact it isn't doing anything and is semantically valid. There should be an exception for these types of Script URLs.
strugee
All 8 comments
Perhaps this should be a specialized warning? I can't be the only one to have been confused by this.
strugee
on 23 Jun 2014
You're not.
weeger
on 13 Aug 2014
Just put this line at the top of your file to disable the warning:
/*jshint scripturl:true*/
But the best way is to use "#" into the href and to return "false" for all javascript events:
<a href="#" onclick="doSomething();return false;">my link</a>
kcampion
on 9 Sep 2014
No, the best way is to keep your JavaScript out of your markup and attributes :P
rwaldron
on 9 Sep 2014
@rwaldron: rectification, indeed
$('#foobar').attr("href", "#").click(function() {
// do it
});
Passes jslint:
$('#foobar').attr('href','javascript'+String.fromCharCode(58)+'void(0);');
MikeGodin
on 4 Aug 2016
@MikeGodin looks like a separate bug.
strugee
on 4 Aug 2016
@kcampion putting # and return false is not always desirebale
in my case i dont want hash to appear
englishextra
on 31 Oct 2016
Related issues
helmus
·
48Comments
cowwoc
·
12Comments
jugglinmike
·
23Comments
xtianus79
·
12Comments
3rd-Eden
·
41Comments
Most helpful comment
Just put this line at the top of your file to disable the warning:
But the best way is to use "#" into the href and to return "false" for all javascript events: