Rust: Revisit "must camel case identifiers" lint warning on by default
I like camel casing types that came from #3060, but sometimes I feel the warning is a little too strict. I'm porting erickt/rust-crypto to 0.4, and it has complicated enum variants like AES_256_ECB, which don't read nicely as Aes256Ecb. I ran into the same thing updating rust-elasticsearch, where I converted DFS_QUERY_THEN_FETCH to DfsQueryThenFetch, which made me sad.
I heard @graydon has some reservations with this lint checker on by default, so I figure maybe we should talk this through if it's not a settled issue. What does the community think about turning this into an opt-in lint? Or if that ship has already sailed, what about allowing types, traits, and variants to have _ in them?
erickt
All 4 comments
Putting this on 0.4 to make sure we discuss it before releasing a potentially annoying feature to the wild.
brson
on 29 Sep 2012
There is #[allow(non_camel_case_types)]. If the problem types are truly the 'uncommon' case, then we should have to use that for them.
bblum
on 29 Sep 2012
This warning is disabled by default again. Can revisit later.
brson
on 2 Oct 2012
Not sure if there's a 'modern' issue tracking this, but, they seem to be enabled by default in 1.35.0.
sci4me
on 4 Jun 2019
Related issues
modsec
·
3Comments
zhendongsu
·
3Comments
lambda-fairy
·
3Comments
behnam
·
3Comments
dnsl48
·
3Comments
Most helpful comment
Not sure if there's a 'modern' issue tracking this, but, they seem to be enabled by default in 1.35.0.