Faraday: 0.16.2์˜ fastlane์— ๋Œ€ํ•œ ์ฃผ์š” ๋ณ€๊ฒฝ ์‚ฌํ•ญ

์— ๋งŒ๋“  2019๋…„ 09์›” 29์ผ  ยท  15์ฝ”๋ฉ˜ํŠธ  ยท  ์ถœ์ฒ˜: lostisland/faraday

๊ธฐ๋ณธ ์ •๋ณด

  • ํŒจ๋Ÿฌ๋ฐ์ด ๋ฒ„์ „: 0.16.2
  • ๋ฃจ๋น„ ๋ฒ„์ „:

    • Windows: ๋ฃจ๋น„ 2.4.6p354(2019-04-01 ๊ฐœ์ •ํŒ 67394) [x64-mingw32]

    • ๋งฅ: ๋ฃจ๋น„ 2.5

๋ฌธ์ œ ์„ค๋ช…

ํŒจ๋Ÿฌ๋ฐ์ด 0.16.2 ๋ฐ @BobbyMcWho ์ˆ˜์ •์—๋„ fastlane ์— ๋Œ€ํ•œ ํ…Œ์ŠคํŠธ ์‹คํŒจ๊ฐ€ ์žˆ์Šต๋‹ˆ๋‹ค.

Failures:
  1) Spaceship::Portal::Persons should change role
     Failure/Error: expect { person.change_role("member") }.to_not(raise_error)
       expected no Exception, got #<RuntimeError: can't modify frozen String> with backtrace:
         # ./spaceship/lib/spaceship/client.rb:811:in `force_encoding'
         # ./spaceship/lib/spaceship/client.rb:811:in `log_response'
         # ./spaceship/lib/spaceship/client.rb:846:in `block in send_request'
         # ./spaceship/lib/spaceship/client.rb:620:in `with_retry'
         # ./spaceship/lib/spaceship/client.rb:844:in `send_request'
         # ./spaceship/lib/spaceship/client.rb:688:in `request'
         # ./spaceship/lib/spaceship/portal/portal_client.rb:449:in `team_set_role'
         # ./spaceship/lib/spaceship/portal/person.rb:45:in `change_role'
         # ./spaceship/spec/portal/person_spec.rb:58:in `block (3 levels) in <top (required)>'
         # ./spaceship/spec/portal/person_spec.rb:58:in `block (2 levels) in <top (required)>'
     # ./spaceship/spec/portal/person_spec.rb:58:in `block (2 levels) in <top (required)>'
  2) Spaceship::Tunes::IAPList IAPList can delete
     Failure/Error: deleted = app.in_app_purchases.find("go.find.me").delete!
     RuntimeError:
       can't modify frozen String
     # ./spaceship/lib/spaceship/client.rb:811:in `force_encoding'
     # ./spaceship/lib/spaceship/client.rb:811:in `log_response'
     # ./spaceship/lib/spaceship/client.rb:846:in `block in send_request'
     # ./spaceship/lib/spaceship/client.rb:620:in `with_retry'
     # ./spaceship/lib/spaceship/client.rb:844:in `send_request'
     # ./spaceship/lib/spaceship/client.rb:688:in `request'
     # ./spaceship/lib/spaceship/tunes/tunes_client.rb:1235:in `delete_iap!'
     # ./spaceship/lib/spaceship/tunes/iap_list.rb:72:in `delete!'
     # ./spaceship/spec/tunes/iap_list_spec.rb:28:in `block (3 levels) in <top (required)>'
  3) Spaceship::Tunes::Members members creates a new member role: admin, apps: all
     Failure/Error: Spaceship::Members.create!(firstname: "Helmut", lastname: "Januschka", email_address: "[email protected]")
     RuntimeError:
       can't modify frozen String
     # ./spaceship/lib/spaceship/client.rb:811:in `force_encoding'
     # ./spaceship/lib/spaceship/client.rb:811:in `log_response'
     # ./spaceship/lib/spaceship/client.rb:846:in `block in send_request'
     # ./spaceship/lib/spaceship/client.rb:620:in `with_retry'
     # ./spaceship/lib/spaceship/client.rb:844:in `send_request'
     # ./spaceship/lib/spaceship/client.rb:688:in `request'
     # ./spaceship/lib/spaceship/tunes/tunes_client.rb:502:in `create_member!'
     # ./spaceship/lib/spaceship/tunes/members.rb:26:in `create!'
     # ./spaceship/spec/tunes/members_spec.rb:19:in `block (4 levels) in <top (required)>'

...

์ฐธ๊ณ ์šฉ ํ™๋ณด: https://github.com/fastlane/fastlane/pull/15407

์šฐ๋ฆฌ์˜ ํ…Œ์ŠคํŠธ๋Š” macOS ๋ฐ Ubuntu์˜ ruby โ€‹โ€‹2.3์—์„œ ์‹คํŒจํ•˜์ง€ ์•Š์Šต๋‹ˆ๋‹ค.

๊ฐ€์žฅ ์œ ์šฉํ•œ ๋Œ“๊ธ€

@janpio #1039๋Š” ๋ณธ๋ฌธ์—์„œ ๊ณ ์ •๋œ ๋ฌธ์ž์—ด ๋ฆฌํ„ฐ๋Ÿด ๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ•ด์•ผ ํ•œ๋‹ค๊ณ  ์ƒ๊ฐํ•ฉ๋‹ˆ๋‹ค.

๋ชจ๋“  15 ๋Œ“๊ธ€

์ด๊ฒƒ์€ fastlane/fastlane#15403์—์„œ ์ด ์ค„๋กœ ์ˆ˜์ •๋˜์–ด์•ผ ํ•ฉ๋‹ˆ๋‹ค. ์–ด๋”˜๊ฐ€์— ๊ณ ์ •๋œ ๋ฌธ์ž์—ด ๋ฆฌํ„ฐ๋Ÿด ๋งค์ง ์ฃผ์„์˜ ๋ถ€์ž‘์šฉ์ด๋ผ๊ณ  ์ƒ๊ฐํ•ฉ๋‹ˆ๋‹ค.

ํŽธ์ง‘: ~ ๊ทธ๊ฒƒ์€ lostisland/faraday_middleware#196์ด ์Šน์ธ๋˜๊ณ  ๋ฆด๋ฆฌ์Šค๋  ๋•Œ๊นŒ์ง€ ๋ฆด๋ฆฌ์Šค๋  ์ˆ˜ ์—†์Šต๋‹ˆ๋‹ค~ Edit2: ์ด์ „ ๋ฒ„์ „๊ณผ ํ˜ธํ™˜๋ฉ๋‹ˆ๋‹ค.

์˜ˆ, ์•ž์œผ๋กœ ๋‚˜์•„๊ฐˆ ๊ธธ์€ ์—ฌ๊ธฐ์—์„œ ๋งค์šฐ ๋ช…ํ™•ํ•ฉ๋‹ˆ๋‹ค. ๊ทธ๋ฆฌ๊ณ  ์šฐ๋ฆฌ๋Š” ๊ฐ€๋Šฅํ•œ ํ•œ ๋นจ๋ฆฌ ์ƒˆ๋กœ์šด ๋ฆด๋ฆฌ์Šค๋ฅผ ์ค‘๋‹จํ•  ๊ฒƒ์ž…๋‹ˆ๋‹ค.

๊ทธ๋Ÿฌ๋‚˜ ํ˜„์žฌ ์ˆ˜์ฒœ ๊ฐœ์˜ Fastlane ์„ค์น˜(๋ฐ ๊ธฐํƒ€ ์†Œํ”„ํŠธ์›จ์–ด)๊ฐ€ ์ค‘๋‹จ๋˜์–ด ์žˆ์œผ๋ฏ€๋กœ ์ด๋ฅผ ๋‹ค์‹œ ๋ช…์‹œ์ ์œผ๋กœ ๋ณด๊ณ ํ•˜๋Š” ๊ฒƒ์ด ์ค‘์š”ํ•˜๋‹ค๊ณ  ์ƒ๊ฐํ–ˆ์Šต๋‹ˆ๋‹ค.

0.16.3์—์„œ ์ด ์ž‘์—…์„ ๋‹ค์‹œ ์ˆ˜ํ–‰ํ•  ์ˆ˜ ์žˆ๋Š” ๋ฐฉ๋ฒ•์ด ์žˆ์Šต๋‹ˆ๊นŒ?

๋‚˜๋Š” ์ปดํ“จํ„ฐ์— ์ ‘๊ทผํ•  ์ˆ˜ ์žˆ๋Š” ์žฅ์†Œ์— ์žˆ์ง€๋Š” ์•Š์ง€๋งŒ ๋‚ด ํœด๋Œ€์ „ํ™”์—์„œ ํŒŒ์ผ์„ ๊ฒ€์ƒ‰ํ•˜๋Š” ํ”ผ์ƒ์ ์œผ๋กœ๋Š” ํŒจ๋Ÿฌ๋ฐ์ด์˜ ์–ด๋”˜๊ฐ€์—์„œ ์š”์ฒญ ๋ณธ๋ฌธ์„ ๊ณ ์ •๋œ ๋ฌธ์ž์—ด๋กœ ์„ค์ •ํ•˜๊ณ  ์žˆ๋Š” ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค. ์š”์ฒญ ๋ณธ๋ฌธ์ด ๊ณ ์ •๋œ ๋ฌธ์ž์—ด๋กœ ์„ค์ •๋˜๋Š” ์œ„์น˜๋ฅผ ์ฐพ์„ ์ˆ˜ ์žˆ์œผ๋ฉด ๋น ๋ฅธ ์ฐจ์„ ์—์„œ ๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ•ด์•ผ ํ•ฉ๋‹ˆ๋‹ค.

@janpio #1039๋Š” ๋ณธ๋ฌธ์—์„œ ๊ณ ์ •๋œ ๋ฌธ์ž์—ด ๋ฆฌํ„ฐ๋Ÿด ๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ•ด์•ผ ํ•œ๋‹ค๊ณ  ์ƒ๊ฐํ•ฉ๋‹ˆ๋‹ค.

์ˆ˜์ • ์‚ฌํ•ญ์ด ๋‚˜ํƒ€๋‚˜๋Š” ๋™์•ˆ ๊ธฐ๋‹ค๋ ค ์ฃผ์…”์„œ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค. ๊ตฌํ˜„ํ•ด ์ฃผ์‹  BobbyMcWho์—๊ฒŒ ๊ฐ์‚ฌ๋“œ๋ฆฝ๋‹ˆ๋‹ค!

๋‹ค๋ฅธ ์–ด๋Œ‘ํ„ฐ์— ํ•„์š”ํ•œ _more_ ๋ณ€๊ฒฝ ๊ฐ€๋Šฅํ•œ ๋ณธ๋ฌธ ๋ฌธ์ž์—ด์ด ์žˆ๋Š”์ง€ ๊ถ๊ธˆํ•ฉ๋‹ˆ๋‹ค.

๋‚˜๋Š” ํ”„๋กœ์ ํŠธ๋ฅผ ์‚ดํŽด๋ณด์•˜๊ณ , ๋‹ค๋ฅธ ๊ฒƒ์€ ์ฆ‰์‹œ ๋ˆˆ์— ๋„์ง€ ์•Š์•˜์Šต๋‹ˆ๋‹ค. ๋Œ€๋ถ€๋ถ„์˜ ๊ณ ์ •๋œ ๋ฆฌํ„ฐ๋Ÿด์€ ์˜ค๋ฅ˜ ๋ฉ”์‹œ์ง€์ด๊ฑฐ๋‚˜ ๋ณ€๊ฒฝ ๊ฐ€๋Šฅํ•˜์ง€ ์•Š์„ ๊ฒƒ์œผ๋กœ ์˜ˆ์ƒ๋˜๋Š” ๋ฐฉ์‹์œผ๋กœ ์‚ฌ์šฉ๋˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค.

๋‚˜๋Š” ๋˜ํ•œ Elasticsearch-transport(searchkick์˜ ์ข…์†์„ฑ)์™€ ํ•จ๊ป˜ ํŒจ๋Ÿฌ๋ฐ์ด 0.16.2๋ฅผ ์‚ฌ์šฉํ•  ๋•Œ๋„ ์ด๊ฒƒ์„ ๊ฒฝํ—˜ํ–ˆ์Šต๋‹ˆ๋‹ค. @BobbyMcWho์— ํŒจ์น˜๋ฅผ ๋„ฃ์–ด์ฃผ์…”์„œ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค!

@zspencer ์œ ์ง€ ๊ด€๋ฆฌ์ž๊ฐ€ 0.16.3์„ ๋ฆด๋ฆฌ์Šคํ•  ๊ธฐํšŒ๊ฐ€ ์žˆ์„ ๋•Œ๊นŒ์ง€ ์ง€๊ธˆ ๋‹น์žฅ ํ•„์š”ํ•œ ๊ฒฝ์šฐ gemfile์˜ 0.16.x ๋ถ„๊ธฐ๋ฅผ ๊ฐ€๋ฆฌ์ผœ์•ผ ํ•  ์ˆ˜๋„ ์žˆ์Šต๋‹ˆ๋‹ค.

๊ฐ์‚ฌ ํ•ด์š”! ๋‚˜๋Š” ์ด๋ฏธ ๊ทธ๋ ‡๊ฒŒ ํ–ˆ๋‹ค. ์ด ๋ฌธ์ œ์— ์ง๋ฉดํ•˜์—ฌ searchkick ๋ฐ elasticsearch์™€ ๊ฐ™์€ ๋‹จ์–ด๋ฅผ Google ์ฟผ๋ฆฌ์— ์ถ”๊ฐ€ํ•˜๋Š” ์‚ฌ๋žŒ๋“ค์ด ๋ฌธ์ œ๋ฅผ ์ฐพ์„ ์ˆ˜ ์žˆ๋„๋ก ํ•˜๊ณ  ์‹ถ์—ˆ์Šต๋‹ˆ๋‹ค. (๊ทธ๋ฆฌ๊ณ  ์ˆ˜์ •!)

์•ˆ๋…•ํ•˜์„ธ์š”. v0.16.x ๋ฆด๋ฆฌ์Šค๋กœ ์ธํ•ด ํ˜ผ๋ž€์„ ๋“œ๋ ค ์ •๋ง ์ฃ„์†กํ•ฉ๋‹ˆ๋‹ค.
์ตœ์‹  ์ž‘์—… ๋ฆด๋ฆฌ์Šค v0.15.4๋ฅผ ๋ฐ”๋กœ ๋”ฐ๋ฅด๋Š” ROLLBACK RELEASE v0.17.0์„ ์ˆ˜ํ–‰ํ–ˆ์Šต๋‹ˆ๋‹ค.
์ด์ „ ๋ฒ„์ „๊ณผ์˜ ํ˜ธํ™˜์„ฑ ๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ•˜๋ ค๋ฉด ํ•ด๋‹น ๋ฒ„์ „์œผ๋กœ ์—…๋ฐ์ดํŠธํ•˜์‹ญ์‹œ์˜ค.
์ถ”๊ฐ€ ์ •๋ณด: https://github.com/lostisland/faraday/releases/tag/v0.17.0

@iMacTia ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค. ์ด๊ฒƒ์€ ์ง€๊ธˆ๊นŒ์ง€ faraday ์™€ ๋™์ผํ•œ ๋ฒ„์ „์œผ๋กœ ์œ ์ง€๋˜์—ˆ๋˜ faraday_middleware ์—๋„ ์ ์šฉ๋ฉ๋‹ˆ๊นŒ?

@janpio ์ œ๊ฐ€ ์ดํ•ด๋ฅผ ์ž˜ ๋ชปํ•ด์„œ ์ฃ„์†กํ•ฉ๋‹ˆ๋‹ค. ์ด ๋ฌธ์ œ๋Š” 2์›” ์ดํ›„ ์ƒˆ ๋ฒ„์ „์„ ์ถœ์‹œํ•˜์ง€ ์•Š์•˜์œผ๋ฏ€๋กœ faraday_middleware ์— ์–ด๋–ค ์‹์œผ๋กœ๋“  ์˜ํ–ฅ์„ ๋ฏธ์น˜์ง€ ์•Š์Šต๋‹ˆ๋‹ค.
0.16๊ณผ์˜ ํ˜ธํ™˜์„ฑ์„ ์ถ”๊ฐ€ํ•˜๋Š” ๊ฒƒ์„ ๋ชฉํ‘œ๋กœ ํ•˜๋Š” ์ด PR ์„ ์•Œ๊ณ  ์žˆ์ง€๋งŒ ๋” ์ด์ƒ ๋ฆด๋ฆฌ์Šค๋˜์ง€ ์•Š์Šต๋‹ˆ๋‹ค.

Faraday v1.0์„ ์ถœ์‹œํ•˜๋ฉด Faraday ๋ฏธ๋“ค์›จ์–ด๋„ ์—…๋ฐ์ดํŠธํ•˜๊ณ  ํ˜ธํ™˜ ๊ฐ€๋Šฅํ•œ v1.0์„ ์ถœ์‹œํ•  ๊ฒƒ์ž…๋‹ˆ๋‹ค.

๐Ÿ˜„ ๋˜ ๊ถ๊ธˆํ•œ๊ฑฐ ์žˆ์œผ๋ฉด ์•Œ๋ ค์ฃผ์„ธ์š”.

์–ด๋Š ์ •๋„ - ์šฐ๋ฆฌ gemspec์—์„œ faraday_middleware ๋Š” in sync with faraday $๋กœ ์ฃผ์„ ์ฒ˜๋ฆฌ๋˜์—ˆ์œผ๋ฏ€๋กœ ์‹ค์ œ๋กœ ์ƒˆ ๋ฒ„์ „์ด ํ•„์š”ํ•œ์ง€ ๊ถ๊ธˆํ•ฉ๋‹ˆ๋‹ค. ๊ทธ๋ ‡์ง€ ์•Š์€ ๊ฒฝ์šฐ ์ด์ „ ๋ฒ„์ „์„ ๊ณ„์† ์‚ฌ์šฉํ•  ๊ฒƒ์ž…๋‹ˆ๋‹ค.

Faraday Middleware v0.13.1์€ Faraday v0.15.4์—์„œ ์ž˜ ์ž‘๋™ํ–ˆ์œผ๋ฏ€๋กœ v0.17.0์—์„œ๋„ ์ž˜ ์ž‘๋™ํ•  ๊ฒƒ์œผ๋กœ ์˜ˆ์ƒํ•ฉ๋‹ˆ๋‹ค. ๊ทธ๋ž˜๋„ ํ™•์‹คํžˆ ํ•˜๊ธฐ ์œ„ํ•ด ๋งˆ์Šคํ„ฐ ๋นŒ๋“œ๋ฅผ ์‹คํ–‰ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค ๐Ÿ‘

@janpio ํŠธ๋ฆฌ๊ฑฐ https://travis-ci.org/lostisland/faraday_middleware/builds/595051325 , ๋กœ๊ทธ์—์„œ Faraday v0.17.0์ด ์‚ฌ์šฉ๋˜๊ณ  ๋ชจ๋“  ํ…Œ์ŠคํŠธ๊ฐ€ ํ†ต๊ณผ๋˜์—ˆ์Œ์„ ํ™•์ธํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค ๐ŸŽ‰

์ด ํŽ˜์ด์ง€๊ฐ€ ๋„์›€์ด ๋˜์—ˆ๋‚˜์š”?
0 / 5 - 0 ๋“ฑ๊ธ‰