Pim-community-dev: 20 ๋ฒˆ์งธ ๊ทธ๋ฃน ์ด์ƒ์˜ ๊ฐ€์กฑ์— ์†์„ฑ ์ถ”๊ฐ€

์— ๋งŒ๋“  2017๋…„ 04์›” 20์ผ  ยท  9์ฝ”๋ฉ˜ํŠธ  ยท  ์ถœ์ฒ˜: akeneo/pim-community-dev

๋ฌธ์ œ # 6054์™€ ๊ด€๋ จ์ด์žˆ์„ ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.

๋ฒ„์ „ 1.7.3

์†์„ฑ ํŒจ๋ฐ€๋ฆฌ์— ์†์„ฑ์„ ์ถ”๊ฐ€ ํ•  ๋•Œ sort_order์— ์˜ํ•ด ์‹œ์Šคํ…œ์—์„œ> 20 ๋ฒˆ์งธ ์†์„ฑ ๊ทธ๋ฃน์—์žˆ๋Š” ์†์„ฑ์ด ์‹คํŒจํ•˜๊ณ  javascript ์˜ค๋ฅ˜๊ฐ€ ๋ฐœ์ƒํ•ฉ๋‹ˆ๋‹ค.

attributes.js:109 Uncaught TypeError: Cannot read property 'sort_order' of undefined at child.<anonymous> (attributes.js:109) at underscore.js:380 at Function._.map._.collect (underscore.js:172) at Function._.sortBy (underscore.js:376) at child.<anonymous> (attributes.js:108) at Array.<anonymous> (jquery-1.10.2.js:3204) at fire (jquery-1.10.2.js:3048) at Object.add [as done] (jquery-1.10.2.js:3094) at Array.<anonymous> (jquery-1.10.2.js:3203) at Function.each (jquery-1.10.2.js:657)

์˜ˆ๋กœ์„œ:

screen shot 2017-04-20 at 8 25 05 am

๋‹ค์Œ์€ pim_catalog_attribute_group์˜ ๋ฐ์ดํ„ฐ ๋คํ”„์ž…๋‹ˆ๋‹ค.

screen shot 2017-04-20 at 8 31 44 am

๊ฐ์‚ฌ!

bug has-PR

๊ฐ€์žฅ ์œ ์šฉํ•œ ๋Œ“๊ธ€

์•ˆ๋…•ํ•˜์„ธ์š” @adamrandazzo ๋‹˜ ,์ด ๋ฌธ์ œ๋Š” ๊ธˆ์š”์ผ์— ์ถœ์‹œ ๋œ 1.7.5์—์„œ ์ˆ˜์ •๋˜์—ˆ์Šต๋‹ˆ๋‹ค!
๊ฐ์‚ฌ

๋ชจ๋“  9 ๋Œ“๊ธ€

๋‹ค์Œ ํŒŒ์ผ์—์„œ FETCH_LIMIT๋ฅผ ๋ณ€๊ฒฝํ•˜๋ฉด ๋ฌธ์ œ๊ฐ€ ํ•ด๊ฒฐ๋˜์ง€๋งŒ ์‹œ์Šคํ…œ์— ๋‹ค๋ฅธ ์˜๋ฏธ๊ฐ€ ์žˆ๋Š”์ง€ ํ™•์‹คํ•˜์ง€ ์•Š์œผ๋ฏ€๋กœ ํ’€ ์š”์ฒญ์„ ์ƒ์„ฑํ•˜๊ณ  ์‹ถ์ง€ ์•Š์Šต๋‹ˆ๋‹ค. https://github.com/akeneo/pim-community-dev/blob/494b2c108427556e2818a3c2f18ede40b585c144/src/Akeneo/Component/StorageUtils/Repository/SearchableRepositoryInterface.php

์•ˆ๋…•ํ•˜์„ธ์š” @adamrandazzo , ํ”ผ๋“œ๋ฐฑ์— ๊ฐ์‚ฌ๋“œ๋ฆฝ๋‹ˆ๋‹ค. ์ €ํฌ ์ง€์›ํŒ€์ด์ด๋ฅผ ์‚ดํŽด๋ณด๊ณ  ๊ณ„์† ์—…๋ฐ์ดํŠธ ํ•  ๊ฒƒ์ž…๋‹ˆ๋‹ค. :)

์•ˆ๋…•ํ•˜์„ธ์š”.
์šฐ๋ฆฌ๋Š” ๊ฐ™์€ ๋ฌธ์ œ๊ฐ€ ์žˆ์Šต๋‹ˆ๋‹ค.
๋ฌธ์ œ๋Š” Pim \ Bundle \ EnrichBundle \ Controller \ Rest \ AttributeGroupC ontroller : 76์— ์žˆ์Šต๋‹ˆ๋‹ค.

if (empty($options)) {
    $options = $request->request->get(
        'options',
        [
            'limit' => SearchableRepositoryInterface::FETCH_LIMIT,
            'locale' => null,
        ]
    );
}

์ž๋ฐ” ์Šคํฌ๋ฆฝํŠธ ์• ํ”Œ๋ฆฌ์ผ€์ด์…˜์€์ด ์ปจํŠธ๋กค๋Ÿฌ์— ์†์„ฑ ๊ทธ๋ฃน์„ ์š”์ฒญํ•ฉ๋‹ˆ๋‹ค.
๋ชจ๋“  ์†์„ฑ ๊ทธ๋ฃน์„ ๊ฒ€์ƒ‰ ํ•  ๊ฒƒ์œผ๋กœ ์˜ˆ์ƒํ•˜์ง€๋งŒ 'limit'๋งค๊ฐœ ๋ณ€์ˆ˜๊ฐ€ ์„ค์ •๋˜์ง€ ์•Š์€ ๊ฒฝ์šฐ ์ปจํŠธ๋กค๋Ÿฌ๋Š” ๊ฒฐ๊ณผ๋ฅผ 20 ๊ฐœ ํ•ญ๋ชฉ์œผ๋กœ ์ œํ•œํ•ฉ๋‹ˆ๋‹ค.

๋‚˜๋Š” ์ž๋ฐ” ์Šคํฌ๋ฆฝํŠธ ์‘์šฉ ํ”„๋กœ๊ทธ๋žจ์ด ๊ฒฐ๊ณผ๊ฐ€ ํŽ˜์ด์ง€ ๋งค๊น€๋˜๊ณ  ๋ชจ๋“  ์†์„ฑ ๊ทธ๋ฃน์„ ๊ฒ€์ƒ‰ํ•˜๊ธฐ ์œ„ํ•ด ์—ฌ๋Ÿฌ http ํ˜ธ์ถœ์„ํ•ด์•ผํ•œ๋‹ค๋Š” ๊ฒƒ์„ ์•Œ์•„์•ผํ•œ๋‹ค๊ณ  ์ƒ๊ฐํ•ฉ๋‹ˆ๋‹ค.

์ด ๋ฒ„๊ทธ์˜ ์ˆ˜์ •์„ ๊ธฐ๋‹ค๋ฆฌ๋Š” ๋™์•ˆ ํ•ด๊ฒฐ ๋ฐฉ๋ฒ•์„ ์ ์šฉํ•˜์—ฌ AttributeGroupController๋ฅผ ํ™•์žฅํ•˜๊ณ  ๊ต์ฒดํ–ˆ์Šต๋‹ˆ๋‹ค.

<?php

namespace Idrolab\Bundle\BugfixBundle\Enrich\Controller\Rest;

use Symfony\Component\HttpFoundation\Request;
use Pim\Bundle\EnrichBundle\Controller\Rest\AttributeGroupController as BaseAttributeGroupController;

class AttributeGroupController extends BaseAttributeGroupController
{
    public function indexAction(Request $request)
    {
        // In this way I avoid it will set the default limit of 20 items because the js app expects all items
        $options = $request->request->get('options', [
            // 'limit' => SearchableRepositoryInterface::FETCH_LIMIT,
            'locale' => null,
        ]);
        $request->request->set('options', $options);        
        return parent::indexAction($request);
    }
}

๋„์›€์ด ๋˜๊ธธ ๋ฐ”๋ž๋‹ˆ๋‹ค.

์•ˆ๋…•ํ•˜์„ธ์š” @adamrandazzo ๋‹˜ , ์˜๊ฒฌ์„ ๋ณด๋‚ด ์ฃผ์…”์„œ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค.

์ €๋Š” @ danielsan80 ํ’€ ๋ฆฌํ€˜์ŠคํŠธ์— ์ •๋ง ๊ด€์‹ฌ์ด ์žˆ์ง€๋งŒ, (ํ”„๋ก ํŠธ ์—”๋“œ ์ธก ๋˜๋Š” ๋ฐฑ์—”๋“œ ์ธก์—์„œ) ๊ณ ์ณ์•ผ ํ•  ๋ฐฉ๋ฒ•์„ ์ƒ๊ฐํ•˜๊ธฐ ์ „์— @SamirBoulil๊ณผ ๋…ผ์˜ํ•ด์•ผํ•ฉ๋‹ˆ๋‹ค.

๋ฌธ์•ˆ ์ธ์‚ฌ,

@mickaelandrieu ๋ญ”๊ฐ€ ๋‚ด๊ฐ€ ์ด๋ฏธ PIM-6196 ์–ด๋”˜๊ฐ€์—์„œ ์ˆ˜์ •ํ•˜๊ณ  https://github.com/akeneo/pim-community-dev/pull/5957

์ด ๋ฌธ์ œ๋Š” SLA PIM-6416์—์„œ ์ฒ˜๋ฆฌํ•ด์•ผํ•ฉ๋‹ˆ๋‹ค. ๋‚˜๋Š” ์ด๊ฒƒ์„ ์ˆ˜์ •ํ•˜๊ธฐ ์œ„ํ•ด PR์„ ๋งŒ๋“ค์—ˆ์ง€ ๋งŒ @ a2xchip ์€ ์ด๋ฏธ ๋‹ค๋ฅธ PR์—์„œ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค. ๋‚˜๋Š” ๋‚˜์˜ ๊ฒƒ์„ ๋‹ซ์•˜๋‹ค.

@LaurentPetard , @ a2xchip ์„ค๋ช…์— ๊ฐ์‚ฌ๋“œ๋ฆฝ๋‹ˆ๋‹ค. ํ’€ ์š”์ฒญ์„ ๋ฌธ์ œ์— ์—ฐ๊ฒฐ ํ•œ ๋‹ค์Œ :)

์—ฐ๊ฒฐ๋œ PR์ด ๋ณ‘ํ•ฉ ๋˜์—ˆ๊ธฐ ๋•Œ๋ฌธ์—์ด ๋ฌธ์ œ๋ฅผ ๋‹ซ์Šต๋‹ˆ๋‹ค!
์ด๊ฒƒ์ด ๊ท€ํ•˜์˜ ์š”๊ตฌ์— ๋งž์ง€ ์•Š์œผ๋ฉด ๋‹ค์‹œ ์—ด์–ด ์ฃผ์‹œ๊ธฐ ๋ฐ”๋ž๋‹ˆ๋‹ค;)

์•ˆ๋ถ€!
ํ”ผ์—๋ฅด

์•ˆ๋…•ํ•˜์„ธ์š” @adamrandazzo ๋‹˜ ,์ด ๋ฌธ์ œ๋Š” ๊ธˆ์š”์ผ์— ์ถœ์‹œ ๋œ 1.7.5์—์„œ ์ˆ˜์ •๋˜์—ˆ์Šต๋‹ˆ๋‹ค!
๊ฐ์‚ฌ

์ด ํŽ˜์ด์ง€๊ฐ€ ๋„์›€์ด ๋˜์—ˆ๋‚˜์š”?
0 / 5 - 0 ๋“ฑ๊ธ‰