Pim-community-dev: Adding attributes to family from >20th group

Changing the FETCH_LIMIT in the following file fixes the issue, but I don't want to create a pull request as I am not sure of other implications in the system. https://github.com/akeneo/pim-community-dev/blob/494b2c108427556e2818a3c2f18ede40b585c144/src/Akeneo/Component/StorageUtils/Repository/SearchableRepositoryInterface.php

Hi @adamrandazzo, thanks for this feedback, our support team will take a look at it and keep you updated :)

Hi.
We have the same issue.
The problem is at Pim\Bundle\EnrichBundle\Controller\Rest\AttributeGroupController:76.

if (empty($options)) {
    $options = $request->request->get(
        'options',
        [
            'limit' => SearchableRepositoryInterface::FETCH_LIMIT,
            'locale' => null,
        ]
    );
}

The javascript application asks for the attribute groups to this controller.
It expects to retrieve ALL attribute groups but the controller limits the result to 20 items if the 'limit' parameter is not set.

I think the javascript application should know the result is paginated and it should do several http calls to retrive all attribute groups.

Waiting for the fix of this bug I extended and replaced the AttributeGroupController applying a workaround.

<?php

namespace Idrolab\Bundle\BugfixBundle\Enrich\Controller\Rest;

use Symfony\Component\HttpFoundation\Request;
use Pim\Bundle\EnrichBundle\Controller\Rest\AttributeGroupController as BaseAttributeGroupController;

class AttributeGroupController extends BaseAttributeGroupController
{
    public function indexAction(Request $request)
    {
        // In this way I avoid it will set the default limit of 20 items because the js app expects all items
        $options = $request->request->get('options', [
            // 'limit' => SearchableRepositoryInterface::FETCH_LIMIT,
            'locale' => null,
        ]);
        $request->request->set('options', $options);        
        return parent::indexAction($request);
    }
}

I hope it could help.

Hello @adamrandazzo, thank you for your feedback.

I'm really interested on a pull request @danielsan80 but before I think the way we should fix it (from the frontend side or the backend side) should be discussed with @SamirBoulil.

Regards,

@mickaelandrieu Something remembers me i was already fixing it somewhere in PIM-6196 https://github.com/akeneo/pim-community-dev/pull/5957

This issue should be handled in the SLA PIM-6416. I had even created a PR to fix this, but @a2xchip had already fix it in another PR. I've closed mine.

@LaurentPetard, @a2xchip thanks for the explanations, I link the pull request to the issue then :)

I close this issue because linked PR was merged !
Please feel free to re-open it if this not fits your needs ;)

Regards !
Pierre

Hello @adamrandazzo, this issue is fixed in the 1.7.5 released on Friday!
Thanks