Plots2: ํผ๋ธ”๋ฆญ๋ด‡ ์˜ค๋ฅ˜

์— ๋งŒ๋“  2018๋…„ 01์›” 24์ผ  ยท  4์ฝ”๋ฉ˜ํŠธ  ยท  ์ถœ์ฒ˜: publiclab/plots2

๋ฌธ์ œ(๋˜๋Š” ์•„์ด๋””์–ด)๋ฅผ ์„ค๋ช…ํ•˜์‹ญ์‹œ์˜ค.

๋‚˜๋Š” ํ”Œ๋กฏ์—์„œ ํ’€ ๋ฆฌํ€˜์ŠคํŠธ๋ฅผ ํ•˜๊ณ  ์žˆ์—ˆ๋‹ค. "Fixes #issue_number"๋ฅผ ์ž‘์„ฑํ–ˆ์ง€๋งŒ ์—ฌ์ „ํžˆ ""fixes ..."์™€ ๊ฐ™์ด ์ž…๋ ฅํ•ด์•ผ ํ•ฉ๋‹ˆ๋‹ค.
image
์ด๋ฏธ์ง€์˜ ์ฒซ ๋ฒˆ์งธ ์ค„๊ณผ ๋งˆ์ง€๋ง‰ ์ค„์„ ์ฐธ์กฐํ•˜์‹ญ์‹œ์˜ค.

๋ชจ๋“  4 ๋Œ“๊ธ€

๋‚˜๋„ ์•Œ์•„์ฐจ๋ ธ์–ด. ํ•ญ์ƒ ๋ฐœ์ƒํ•˜๋Š” ๊ฒƒ์€ ์•„๋‹™๋‹ˆ๋‹ค. ๋ฏธํ•ด๊ฒฐ ๋ฌธ์ œ์™€ ์—ฐ๊ฒฐ๋˜์ง€ ์•Š์€ PR #2078์„ ์ฐธ์กฐํ•˜์‹ญ์‹œ์˜ค. ๋ฃจํŠธ ํด๋”์—์„œ Dangerfile ๋ฅผ ๋ณด์…จ์Šต๋‹ˆ๊นŒ?

๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค @seafr ๋ฌธ์ œ ํ•ด๊ฒฐ์— ๋งŽ์€ ๋„์›€์ด ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

๋‚˜๋Š” ์œ„ํ—˜ ํŒŒ์ผ์— #some_number๊ฐ€ ํฌํ•จ๋œ ๋ฉ”์‹œ์ง€๊ฐ€ ์žˆ๋Š” ์ปค๋ฐ‹์ด ์žˆ์œผ๋ฉด ๋ฉ”์‹œ์ง€๊ฐ€ ์ƒ์„ฑ๋˜์ง€ ์•Š๋Š”๋‹ค๋Š” ๊ฒƒ์„ ๋ฐœ๊ฒฌํ–ˆ์Šต๋‹ˆ๋‹ค. ๊ทธ๋Ÿฌ๋‚˜ ๊ทธ ์‚ฌ๋žŒ์ด pr_body์— ๋ฌธ์ œ ๋ฒˆํ˜ธ๋ฅผ ์“ด ๊ฒฝ์šฐ์—๋Š” ์ž‘๋™ํ•˜์ง€ ์•Š์Šต๋‹ˆ๋‹ค.
๊ทธ๋ž˜์„œ @jwarren ๋‚ด๊ฐ€
https://github.com/publiclab/plots2/blob/6051774af117bd32c2af944a23df097d0b2ebaf5/Dangerfile#L5 -L7
NS

unless git.commits.any? { |c| c.message =~ /#[\d]+/ } || github.pr_body.any?{ |c| c.message =~ /#[\d]+/ }
  message "This pull request doesn't link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: `Fixes #123`."

๋Œ€๋ฐ•! ํ›Œ๋ฅญํ•œ ์บ์น˜.

2018๋…„ 1์›” 25์ผ ์˜ค์ „ 10์‹œ 21๋ถ„, "Sidharth Bansal" [email protected]
์ผ๋‹ค:

๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค @seafr https://github.com/seafr ํ•ด๊ฒฐํ•˜๋Š”๋ฐ ๋งŽ์€ ๋„์›€์ด ๋˜์—ˆ์Šต๋‹ˆ๋‹ค
๋ฌธ์ œ.

๋‚˜๋Š” ์œ„ํ—˜ ํŒŒ์ผ์ด ์ปค๋ฐ‹์— ๋‹ค์Œ์„ ํฌํ•จํ•˜๋Š” ๋ฉ”์‹œ์ง€๊ฐ€ ์žˆ๋‹ค๊ณ  ๋งํ•˜๋Š” ๊ฒƒ์„ ๋ฐœ๊ฒฌํ–ˆ์Šต๋‹ˆ๋‹ค.

๊ทธ๋ณด๋‹ค some_number๋Š” ๋ฉ”์‹œ์ง€๋ฅผ ์ƒ์„ฑํ•˜์ง€ ์•Š์Šต๋‹ˆ๋‹ค. ํ•˜์ง€๋งŒ ๊ทธ ์‚ฌ๋žŒ์ด ๊ฐ€์ง€๊ณ  ์žˆ๋‹ค๋ฉด

pr_body์— ๋ฌธ์ œ ๋ฒˆํ˜ธ๋ฅผ ์“ด ๋‹ค์Œ ์ž‘๋™ํ•˜์ง€ ์•Š์Šต๋‹ˆ๋‹ค.
๊ทธ๋ž˜์„œ @jwarren https://github.com/jwarren ๋‚ด๊ฐ€ ๋ฐ”๊ฟ€๊นŒ ?
https://github.com/publiclab/plots2/blob/6051774af117bd32c2af944a23df09
7d0b2ebaf5/Dangerfile#L5-L7
NS

git.commits.any๊ฐ€ ์•„๋‹ˆ๋ฉด? { |c| c.message =~ /#[\d]+/ } || github.pr_body.any?{ |c| c.๋ฉ”์‹œ์ง€ =~ /#[\d]+/ }
message "์ด ํ’€ ๋ฆฌํ€˜์ŠคํŠธ๋Š” ์ด์Šˆ ๋ฒˆํ˜ธ๋กœ ์—ฐ๊ฒฐ๋˜์ง€ ์•Š์Šต๋‹ˆ๋‹ค. Fixes #123 ํ˜•์‹์œผ๋กœ PR ๋ณธ๋ฌธ์—์„œ (์žˆ๋Š” ๊ฒฝ์šฐ) ํ•ด๊ฒฐ๋˜๋Š” ์ด์Šˆ๋ฅผ ์ฐธ์กฐํ•˜์„ธ์š”."

โ€”
์ด ์Šค๋ ˆ๋“œ์— ๊ฐ€์ž…ํ–ˆ๊ธฐ ๋•Œ๋ฌธ์— ์ด ๋ฉ”์‹œ์ง€๋ฅผ ๋ฐ›๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค.
์ด ์ด๋ฉ”์ผ์— ์ง์ ‘ ๋‹ต์žฅํ•˜๊ณ  GitHub์—์„œ ํ™•์ธํ•˜์„ธ์š”.
https://github.com/publiclab/plots2/issues/2086#issuecomment-360497849 ,
๋˜๋Š” ์Šค๋ ˆ๋“œ ์Œ์†Œ๊ฑฐ
https://github.com/notifications/unsubscribe-auth/AABfJzTW7FKZWQ3EkcraqeZ3ZsibKClxks5tOJvAgaJpZM4Rqkil
.

๋ฐ˜๊ฐ‘์Šต๋‹ˆ๋‹ค @SidharthBansal

์ด ํŽ˜์ด์ง€๊ฐ€ ๋„์›€์ด ๋˜์—ˆ๋‚˜์š”?
0 / 5 - 0 ๋“ฑ๊ธ‰