Plots2: PublicBot error

Created on 24 Jan 2018 · 4Comments · Source: publiclab/plots2

Please describe the problem (or idea)

I was doing a pull request at plots. I wrote "Fixes #issue_number" but still it is showing me "You must enter like "fixes ..."

See the first and the last line of the image

bug

Source

SidharthBansal

All 4 comments

I've noticed that too. It does not always happen though. See PR #2078, which is not linked to any open issue. Have you looked at Dangerfile in the root folder?

seafr on 24 Jan 2018

👍1

Thanks @seafr It helped a lot in solving the issue.

I found that the dangerfile says that if any commit has message containing #some_number than that will create no message. But if the person has written the issue number in the pr_body then that does not work.
So, @jwarren shall I change
https://github.com/publiclab/plots2/blob/6051774af117bd32c2af944a23df097d0b2ebaf5/Dangerfile#L5-L7
to

unless git.commits.any? { |c| c.message =~ /#[\d]+/ } || github.pr_body.any?{ |c| c.message =~ /#[\d]+/ }
  message "This pull request doesn't link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: `Fixes #123`."

SidharthBansal on 25 Jan 2018

👍1

Awesome! Great catch.

On Jan 25, 2018 10:21 AM, "Sidharth Bansal" notifications@github.com
wrote:

Thanks @seafr https://github.com/seafr It helped a lot in solving the
issue.

I found that the dangerfile says that if any commit has message containing

some_number than that will create no message. But if the person has

written the issue number in the pr_body then that does not work.
So, @jwarren https://github.com/jwarren shall I change
https://github.com/publiclab/plots2/blob/6051774af117bd32c2af944a23df09
7d0b2ebaf5/Dangerfile#L5-L7
to

unless git.commits.any? { |c| c.message =~ /#[\d]+/ } || github.pr_body.any?{ |c| c.message =~ /#[\d]+/ }
message "This pull request doesn't link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123."

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/2086#issuecomment-360497849,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJzTW7FKZWQ3EkcraqeZ3ZsibKClxks5tOJvAgaJpZM4Rqkil
.