Laravel-excel: [BUG] Documentation mistake for ImportHandler?

Created on 19 Jan 2017  ·  3Comments  ·  Source: Maatwebsite/Laravel-Excel

Laravel-Excel:2.1.7 / Laravel: 5.3.24

In the docs under Import Handlers it states that the handle() function accepts/injects and instance of the Importer class but this not correct if you try and define it that way as the parameter cannot the typehinted:

Declaration of App\ExcelImporters\ContactsImporterHandler::handle() must be compatible with Maatwebsite\Excel\Files\ImportHandler::handle($file)
use Maatwebsite\Excel\Files\ImportHandler;
use App\ExcelImporters\ContactsImporter;

class ContactsImporterHandler implements ImportHandler
{
    public function handle(ContactsImporter $import)
    {
      ...
    }

Is this a mistake in the docs or something I've done wrong?

Most helpful comment

@stevepop Whilst it is a great package there are a lot of issues reported at the moment so I'm guessing the author is busy or MIA.

All 3 comments

I just saw this now too and I wonder why the author has not responded to this issue since it was created since January? I guess he is busy attending to other more 'important issues'

@stevepop Whilst it is a great package there are a lot of issues reported at the moment so I'm guessing the author is busy or MIA.

Nine months passed, and the author did not answer.

Was this page helpful?
0 / 5 - 0 ratings