Laravel-log-viewer: Deleting log file in use can be dangerous
Deleting a log file that is currently in used can be fatal. In my case it caused my artisan service to crash. It would be better if the log file was blanked instead of deleted.
php[591]: PHP Fatal error: Uncaught UnexpectedValueException: The stream or file "/laravel/storage/logs/laravel-2017-07-18.log" could not be opened: failed to open stream
watermelonjuice
All 8 comments
I think Laravel creates a new one if it doesn't exists, right?
marabesi
on 3 Aug 2017
It may do such a check on first run. It is not doing such a check if it is deleted while artisan is accessing it.
watermelonjuice
on 4 Aug 2017
Ok, thank you for contributing! I'm sorry about that crash! (and sorry for my late answer).
IMO, blanking the file is a bit weird (as a user you asked for "deleteting", and it just blanked something). And it will polluate the list of file on the left menu. Still, I understand your need. So I don't know what to do... Any thought?
rap2hpoutre
on 22 Aug 2017
You can blank the log file if it is the current day. Crashing servers is worse than weird behaviour. The weird behaviour can be justified in documentation.
watermelonjuice
on 22 Aug 2017
May I suggest a new button that will save/rename the old log file and start a new one (create a blank file)? That would be great for backup purposes.
maig81
on 4 Oct 2017
rap2hpoutre
on 14 Jun 2018
Fixed via https://github.com/rap2hpoutre/laravel-log-viewer/pull/141
Thanks @dobrik!
rap2hpoutre
on 3 Jul 2018
Available in v0.17.0
rap2hpoutre
on 3 Jul 2018
Related issues
judgej
·
9Comments
raksa
·
3Comments
serdarsaygili
·
11Comments
avesgit
·
7Comments
mstaack
·
6Comments
Most helpful comment
May I suggest a new button that will save/rename the old log file and start a new one (create a blank file)? That would be great for backup purposes.