Lorawan-stack: CLI requires NS and AS for creating devices in JS

Also, the CLI currently requires lorawan_version to be set in all circumstances, while it's only necessary when creating ABP devices for validating the session keys. Suggesting;

diff --git a/cmd/ttn-lw-cli/commands/end_devices.go b/cmd/ttn-lw-cli/commands/end_devices.go
index 2fd69e78..b20c9297 100644
--- a/cmd/ttn-lw-cli/commands/end_devices.go
+++ b/cmd/ttn-lw-cli/commands/end_devices.go
@@ -294,19 +294,6 @@ var (
                paths = append(paths, ttnpb.FlattenPaths(decodedPaths, endDeviceFlattenPaths)...)
            }

-           var macVersion ttnpb.MACVersion
-           s, err := setEndDeviceFlags.GetString("lorawan_version")
-           if err != nil {
-               return err
-           }
-
-           if err := macVersion.UnmarshalText([]byte(s)); err != nil {
-               return err
-           }
-           if err := macVersion.Validate(); err != nil {
-               return errInvalidMACVerson
-           }
-
            setDefaults, _ := cmd.Flags().GetBool("defaults")
            if setDefaults {
                device.NetworkServerAddress = getHost(config.NetworkServerGRPCAddress)
@@ -344,6 +331,17 @@ var (
                        "session.keys.app_s_key.key",
                        "session.dev_addr",
                    )
+                   var macVersion ttnpb.MACVersion
+                   s, err := setEndDeviceFlags.GetString("lorawan_version")
+                   if err != nil {
+                       return err
+                   }
+                   if err := macVersion.UnmarshalText([]byte(s)); err != nil {
+                       return err
+                   }
+                   if err := macVersion.Validate(); err != nil {
+                       return errInvalidMACVerson
+                   }
                    if macVersion.Compare(ttnpb.MAC_V1_1) >= 0 {
                        device.Session.SessionKeys.SNwkSIntKey = &ttnpb.KeyEnvelope{Key: generateKey()}
                        device.Session.SessionKeys.NwkSEncKey = &ttnpb.KeyEnvelope{Key: generateKey()}

cc @rvolosatovs

I think it could be an idea to add (--skip-is,) --skip-ns, --skip-as and --skip-js flags to allow advanced users to skip creates/updates on the (IS/)NS/AS/JS. The --skip-is may be a bit tricky, I think we shouldn't allow that one for creates.

As far as I know the MAC version is very useful, also for OTAA devices. If it's not now, it could still be valuable to have it in the future, so I think it would be wise to keep it where it is.

I think it could be an idea to add (--skip-is,) --skip-ns, --skip-as and --skip-js flags to allow advanced users to skip creates/updates on the (IS/)NS/AS/JS. The --skip-is may be a bit tricky, I think we shouldn't allow that one for creates.

How about skipping them when the concerning ..._grpc_address is empty?

As far as I know the MAC version is very useful, also for OTAA devices. If it's not now, it could still be valuable to have it in the future, so I think it would be wise to keep it where it is.

It's not known when provisioning devices on the JS, for example when provisioning secure elements long before the end device's firmware is chosen. JS doesn't care about MAC version either, it works with the selected MAC version from NS in the join flow.

I don't think it's a good idea to look at address config when deciding where to create end devices, it's just too easy to make mistakes with that (when forgetting to configure an env var). Skipping end device creation on specific server types is a special use case that deserves explicit flags, and should not implicitly be decided when certain config is omitted (possibly by accident).

Removing the MAC version is IMO out of scope for this issue and should be discussed with @rvolosatovs before moving forward with that.

Skipping end device creation on specific server types is a special use case that deserves explicit flags, and should not implicitly be decided when certain config is omitted (possibly by accident).

Standalone AS and standalone JS are not special use cases. Let's go for enabled bools per component then, like Console, by default true.

Regarding the lorawan_version - I agree with @johanstokking, we only need it in CLI for creating ABP devices, so no reason to require it.
bool flags sound good!