Machine: --github-api-token and other global flags not propagated to plugin servers

Created on 14 Nov 2015 · 4Comments · Source: docker/machine

Not an immediately pressing need, but could be troublesome. I realized that global flags like --github-api-token which set properties in e.g. mcnutils naturally do not get set that way for the invoked plugin binaries. Most likely we will need to send these details over the wire, and we need to discuss how to do it safely given the propagation of plugins in the wild now. I think we may need to add a SetLibmachineOptions type method onto the RPC servers in drivers. :( Perhaps we can bundle this and a few other polish things into a version bump, or figure out a workaround through environment variables etc..

kinquality

Source

nathanleclaire

Most helpful comment

we're getting rate limited as GitHub sees our external corpnet as one IP address... and are currently unable to upgrade the boot2docker iso version. Current workaround is to manually re-install docker machine

mattfysh on 9 Jun 2016

👍4

All 4 comments

@dgageot @jeanlaurent Be advised of this issue as it's likely to catch off guard. One possible solution is to set the environment variables for these CLI flags using os.Setenv, which the child process (now that we're invoking the main machine binary) will subsequently inherit. That won't fix it for all plugin drivers, but it would be a temporary workaround for the core.

nathanleclaire on 19 Dec 2015

mattfysh on 9 Jun 2016

👍4

reinstalling docker machine doesnt work

adnan-wahab on 21 Dec 2016

👍1

In 2019 and still seems to not work. ~Also seems like the env var added in this commit also doesn't seem to work?~ I guess that commit was never added, never mind,