Material-ui: MenuItem doesn't respect focusVisibleClassName

Created on 16 May 2018  ·  3Comments  ·  Source: mui-org/material-ui

Related to #10976.

The changes in #10976 work awesome for the Switch, however it looks like the MenuItem's focusVisibleClassName prop doesn't work as expected. Passing a focusVisibleClassName to the item works great from a typing perspective, but they don't seem to be applied to the ListItem correctly.

Example: https://codesandbox.io/s/5638ox58n

bug 🐛 List good first issue
Source
picture ianschmitz

All 3 comments

@ianschmitz Correct, we need to merge the classnames in
https://github.com/mui-org/material-ui/blob/e99f23e85f9f0241a08165b435cd4d51f696ac12/packages/material-ui/src/ListItem/ListItem.js#L108

oliviertassinari picture oliviertassinari on 16 May 2018
👎1

Hi @oliviertassinari, can i take up this issue to solve, as i am a beginner and looking forward to contribute to material-ui :)

ashwani-pandey picture ashwani-pandey on 18 May 2018

We are happy to hear you want to contribute to Material-UI but @rdemirov is already working on this issue. Don't worry, there is a lot that can be improved.

oliviertassinari picture oliviertassinari on 18 May 2018
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

mattmiddlesworth picture mattmiddlesworth  ·  3Comments
sys13 picture sys13  ·  3Comments
activatedgeek picture activatedgeek  ·  3Comments
mb-copart picture mb-copart  ·  3Comments
reflog picture reflog  ·  3Comments