Mongoose: Remove from array[ObjectId]

Created on 24 May 2011 · 10Comments · Source: Automattic/mongoose

Hello,

How can I remove a ObjectId from a array of ObjectId ?

My model :

var User = new Schema({
    title       : { type : String,  index: true },
    name        : String,
    friends     : [ObjectId],
    join_at     : {type:Date, default:Date.now },
    save_at     : {type:Date, default:Date.now }
});

The function for deleting the objectId : uid

User.findOne({'_id' : self.id}, function(err, me){
    for(var i=0; i<=me.friends.length; i++){
        if (String(me.friends[i])==String(uid)){
            me.friends.splice(i, 1);
            break;                          
        }
    }
    me.save(function(err,us){
        next(err,'kljlmjk'+JSON.stringify(me));
    });     
});

Thanks for your response.

Source

gnakor

Most helpful comment

Don't use splice.

me.friends.remove(uid);
me.save(callback);

bnoguchi on 8 Jun 2011

👍30 🎉5 ❤4 😄3 🚀2

All 10 comments

Don't use splice.

me.friends.remove(uid);
me.save(callback);

bnoguchi on 8 Jun 2011

👍30 🎉5 ❤4 😄3 🚀2

That function is beautiful!

alejonext on 18 Feb 2013

👍2

Is there a way to do this to multiple documents as following?

User.update({
    friends: uid
}, {
    '$pull': {
        friends: uid
    }
})

nghuuphuoc on 26 Nov 2013

👍8 👎3

Looking for an answer to this same question (above). How do you do this for multiple documents?

jhickner on 22 May 2014

@jhickner try $pullAll. http://docs.mongodb.org/manual/reference/operator/update/pullAll/

vkarpov15 on 22 May 2014

👍2 ❤1

wonderful

anshupitlia on 23 Apr 2015

@bnoguchi Hi, I know this is an old thread, but it is the first post on google (and I did find a solution here).
Just a quick question, though, for completeness sake. Which usage is preferred:

me.friend.remove(uid);
me.save(callback);

Or:

me.friends.pull(uid);
me.save(callback);

Also, is there any more correct way of inserting new "friends" instead of (in short, better alternative for push()):

me.friend.push(uid);
me.save(callback);

Thanks.

makuc on 14 Dec 2017

👍1

Re: first question, doesn't matter, up to personal preference

Re: 2nd question, better in what way?

vkarpov15 on 19 Dec 2017

As-in more efficient/faster.
Also, I noticed that .pop(...) can have problems when emptying an array, throwing "cannot save undefined" field after calling the me.save(callback) function, while remove() works ok - hence me asking.

makuc on 19 Dec 2017

No, push() should be as fast as you can get while still using save(). You can also do me.update({}, { $push: { friend: uid } }).then(), that will be marginally faster by bypassing middleware, validation, etc. but it won't improve overall latency too much.

Re: the pop() problems, can you open up a separate issue with a stack trace and a script that reproduces this issue please?

vkarpov15 on 27 Dec 2017

👍1

Was this page helpful?

0 / 5 - 0 ratings