Next.js: Minimal apollo example

Some observations: this approach doesn't go deep into the components to load all graphql queries it encounters (something you can enable server-side with react-apollo).

I believe this is a bit problematic with next.js: you aren't really meant to load data deep in the component hierarchy - if you want it to happen both on the client and on the server-side. There is just one point to load the data: in getInitialProps in the root component. I don't know if this is going to change in the future, but if not, then we will have to

1. architecture our apps so that we load all relevant data for a page from the start, or
2. a part of the data only on the client (namely everything we don't load in getInitialProps), with a different strategy

In both cases, the approach above should be fine for the data being loaded in getInitialProps.

Aand if some core developer likes this, I can create a pull request with the example.

About getInitialProps only called at root, see https://github.com/zeit/next.js/issues/192. Would love to have your ideas there.

@sedubois what problems were you running into with react-apollo?

@nmaro your https://github.com/nmaro/apollo-next-example is empty.

@amccloud better to ask @nmaro about that (I still need to get back into the code).

Thanks @sedubois it's now online (always forget to run push origin master instead of just push the first time).

Oops, I mentioned to the wrong person. @nmaro what issue did you have with react-apollo?

The data was loaded in the server, then as soon as the client started loading the page was empty again. I then looked at @sedubois's implementation (https://github.com/RelateMind/relate), and thought it's already quite complex for a quick proof-of-concept, so I finally tried with the lower-level api.

@stubailo since you were wondering why it's so hard to integrate apollo with next.js - it looks like the only place you can fetch data both on the client and on the server is at the page's root component inside an async function called getInitialProps. I think the usual way to integrate react-apollo would only be useful on the client side.

Interesting - are there any other data integrations with Next.js? It looks like using Redux is also pretty hard based on the examples I've seen.

Most modern data systems have some sort of global cache (Redux, Apollo, Relay) so I feel like there needs to be some sort of facility in Next to enable this.

How can we make Next.js play nicer with modern data systems with a global cache (Redux, Apollo, Relay)? I feel like this should be a big priority for the next release. @stubailo @rauchg

Absolutely. We have a Redux example on the wiki, we need to create more like those :)

It's not something we have to do on a release basis btw. We can just write a wiki tutorial at any time.

Btw @nmaro that example looks really neat, thanks for contributing. We can take that as a base and expand it

Oh, odd - I didn't realize the issues involved. @nmaro what is it about react-apollo that makes things hard? seems like you should be able to follow the redux example almost exactly but do new ApolloClient where this uses createStore, and use ApolloProvider instead of Provider.

I'd love to work with someone to make a minimal example. This is our "hello world" example for React, it would be great to have a port for Next.js: https://github.com/apollostack/frontpage-react-app

@stubailo I'd love to work with you on a minimal example. I've been using the universal apollo microframework, Saturn, for a couple projects and would love to port them over to Next.js + Apollo ultimately :)

Nice - yeah just making minimal modifications to the frontpage app to make it run on next.js instead of create-react-app would be my preference. then we can list it on our home page as well!

@stubailo

A small issue was that data was loaded and rendered on the server, only to be replaced with nothing when loading on the client - I guess I just don't know apollo and next enough to get it right. Using apollo-client directly I didn't have this issue.

What's more tricky for server-rendering is if you have queries deeper in the hierarchy. React doesn't have a way to render things asynchronously, i.e. wait for each component to be ready before rendering it. Which means a ssr framework either has to

1. go through the whole component tree twice, once to load the data, and once to render it.
2. provide an async entry point in the root - this is next.js approach with getInitialProps

Now the question is whether apollo has a way to detect all the data calls that will be needed to render a component tree, and do this all in one function call that can be provided to getInitialProps.

@stubailo Is there a solve for this? ^

@nmaro @ads1018 have you seen getDataFromTree? As used e.g in my example: https://github.com/RelateMind/relate/blob/master/hocs/apollo.js

BTW I wonder if things can be simplified now that https://github.com/zeit/next.js/pull/301 is merged. Haven't looked into that yet.

@sedubois I checked that out thanks for sharing! Yeah, I imagine your example using react-apollo can be simplified with the new programmatic API (#301) that was just merged into Master so that you don't have to wrap all page components with your own HOC. If you make any progress on that, please let me know! Would be cool to get a next.js example on the apollo homepage :)

NB @ads1018 https://github.com/zeit/next.js/pull/301 is about extracting common code with CommonsChunkPlugin, not Programmatic API. But yes programmatic API will definitely help as well, looking forward to have it released.

Has anyone had any luck getting react-apollo working with the new 2.0.0-beta.2 release?

@sedubois @stubailo I pushed up my attempt at next + react-apollo if you want to take a look. You can find it here: https://github.com/ads1018/frontpage-next-app

One issue I'm facing right now is that components are only getting rendered client side and not server side. Perhaps we can use react-apollo's getDataFromTree method inside server.js? Or maybe inside our own custom <document> ? Any suggestions / pull requests are welcome!

Would love to eventually include this hello world example inside the Next examples folder and the Apollo home page.

The only pre-requisite for server-rendering the data is that it's returned as an object in getInitialProps, no need for overrides.

Gotcha. I think this is a bit difficult with react-apollo because as @nmaro pointed out:

the question is whether apollo has a way to detect all the data calls that will be needed to render a component tree, and do this all in one function call that can be provided to getInitialProps.

Gotcha

@ads1018 From a little bit of poking about, if the top level component was exposed on getInitialProps, it could then be rendered to string using the Apollo helper.

The _document would then be something like:

export default class MyDocument extends Document {
  static async getInitialProps ({ app }) {
    const wrapped = React.createElement(ApolloProvider, { client }, app)
    const rendered = await renderToStringWithData(wrapped)
    return { html: rendered, initialState: client.store.getState() }
  }

  render () {

    return (
      <html>
        <Head>
          <title>My page</title>
        </Head>
        <body>
          <ApolloProvider client={client}>
            <Main />
          </ApolloProvider>
          <NextScript />
        </body>
      </html>
    )
  }
}

@rauchg It seems a simple change to expose the app in addition to renderPage, but is there something I'm overlooking?

@bs1180 ah brilliant. That's what I was looking for. Hopefully, it's a simple change to expose app. It would instantly make Next a graphql client-friendly framework.

@bs1180 I've exposed app inside the renderPage return object. Does this align with what you were thinking?

@ads1018 Not quite - in your version render is still being called, which would be unnecessary duplication if renderToStringWithData is going to be called manually.

I did some more work on this and my end result is not nearly as pretty as I first imagined, primarily because the main app is getting rendered as a child of the <Main /> component (into the __next div), which blows away any context from being passed down to your application from above. So it still needs a HOC to add the Apollo context again.

@bs1180 I see. Is it possible to render <Main /> as a child of ApolloProvider so we can pass down the context?

I'm not sure what you mean, but I think it's the wrong direction. Perfect SSR can be achieved with just a HOC- here's my cobbled-together version as a starting point:

export default (options = {}) => Component => class ApolloHOC extends React.Component {
  static async getInitialProps (ctx) {
    const user = process.browser ? getUserFromLocalStorage() : getUserFromCookie(ctx.req)
    const jwt = process.browser ? null : getJwtFromCookie(ctx.req)

    if (options.secure && !user) {
      return null // skip graphql queries completely if auth will fail
    }

    const client = initClient(jwt)
    const store = initStore(client)

   // This inserts the context so our queries will work properly during the getDataFromTree call,
   //  as well as ensuring that any components which are expecting the url work properly 
    const app = React.createElement(ApolloProvider, { client, store },
      React.createElement(Component, { url: { query: ctx.query }}))

 // this is the most important bit :)
    await getDataFromTree(app)

    const initialState = {[client.reduxRootKey]: {
      data: client.store.getState()[client.reduxRootKey].data
    }}

    return { initialState, user }
  }

  constructor (props) {
    super(props)
    this.client = initClient()
    this.store = initStore(this.client, this.props.initialState)
  }

  render () {
    return (
      <ApolloProvider client={this.client} store={this.store}>
          <Component url={this.props.url} />
      </ApolloProvider>
    ) 
  }
}

The initClient and initStore are modelled on the redux example. Every page then looks like this:

import ApolloHOC from '../hoc'
import { graphql } from 'react-apollo'

export default ApolloHOC({ secure: false })(() => <b>Hello world</b>)

Hope that's useful - I'd love to know if there are other avenues to investigate, or something I'm overlooking.

@bs1180 Cool, this is super useful thanks for sharing.

Is there anything else we can to render pages with graphql data inside _document.js? It would be nice if we could bypass that HOC all together like you initially proposed.

I don't think so - from what I can see, the client side render will remove anything being passed on the context (be it Apollo client, the standard Redux store, themes etc.) from the custom _document.js. Although some of the Apollo SSR logic could be moved there, some sort of HOC/wrapper component will still be necessary to add the necessary objects back onto the context.
Someone with a better knowledge of next.js internals might have a better idea though.

Well if you manage to get a working example up, would love to check it out. I'm still fighting getting this to work.

I've got a working example of React Apollo and Next 😄 🚀 I hope many of you find it useful. You can check it out here: https://github.com/ads1018/next-apollo-example (I've also deployed a demo using Now.)

I ended up using a HOC inside my page called withData() which wraps the page with ApolloProvider. I was initially turned off by using providers on a per page basis as opposed to once inside a single file, but I was convinced by some really smart people that it's better for readability and scalability. I actually think withData(MyComponent) looks quite nice and provides good context to the reader (no pun intended) that a particular page fetches data.

Thanks @bs1180 and @rauchg for pointing me in the right direction. If you'd like to add a with-apollo example to the repo let me know and I can create a pull request.

Thanks @ads1018 😊 Compared to my example https://Relate.now.sh, does this example solve the issue of using Apollo in deeply nested components (avoiding the cascade of getInitialProps)? Maybe the example should showcase that as it's the main pain point. And I'm sure adding this to the examples folder would be very appreciated.

@sedubois I'm unable to reproduce the error you referenced in #192. I'm using Apollo inside nested components without any problems. If you pull down my example and are able to reproduce it would you let me know?

Thanks @ads1018, things work great with the fixes in https://github.com/ads1018/next-apollo-example/issues/2 🎉. I updated my example as well: https://github.com/RelateNow/relate

Nice work, @ads1018 @sedubois! I've been following along on this and #192, I've also been investigating prefetching/async views using Apollo and vanilla React.

Have you noticed or do you anticipate any performance issues with running getDataFromTree before each page displays? Since technically, that method renders the whole tree recursively, and then when getInitialProps returns, React renders the tree again (albeit with data from the cache).

Real nice solution 👍 I think rendering twice is the only option to ensure all child data is cached, just curious what you guys think about performance.

Hey @estrattonbailey - I haven't noticed any performance issues and I don't anticipate any. In fact, it's super snappy! As for running getDataFromTree, I've wrapped that method call inside a conditional that checks if we're on the server so it only ever gets called when a user first loads the app and is bypassed on all subsequent route changes. You can play around with the demo if you want to check out the performance. Please let me know if you have any feedback!

@ads1018 some ideas for your example:

• simplify initialState like this
• separate middleware, store and reducer in files like this
• simplify isServer to typeof window !== 'undefined', drop !!ctx.req
• extract that IS_SERVER const to lib, no need to pass it around as param

@ads1018 Great to hear! Nice little demo.

What I meant to ask is: how well will this scale? Though I haven't used Next yet, as I understand it, Next calls getInitialProps on each route transition, if available on a page component i.e. pages/page.js. On a full scale app/website with hundreds of nodes and lots of data coming in I imagine that rendering twice on each route could contribute to some latency.

The project I'm working on is a large scale editorial site, so I hope to do some benchmarking of different approaches, including yours. Would love to discuss more on twitter if you'd like. Thanks for your work!

@estrattonbailey Gotcha. I imagine it will scale very well. For the initial page load, getInitialProps will execute on the server only. You're correct that getInitialProps will be executed again on the client but no data would get requested twice because getDataFromTree is wrapped inside a conditional that checks if we're on the server or not.

Side note - if you're concerned about initial page load time due to lots of components and data being requested on a page you can always tell apollo to intentionally skip specific queries during SSR and offload them to the client by passing ssr: false in the apollo query options.

I'll connect with you on twitter if you want to discuss further :)

You're correct that getInitialProps will be executed again on the client but no data would get requested twice because getDataFromTree is wrapped inside a conditional that checks if we're on the server or not.

Important to keep in mind getInitialProps gets executed on the client side only when transitioning with <Link>, not after the initial load

@ads1018 @estrattonbailey AFAIK there are still indeed 2 renders server-side on first page load: getDataFromTree gets executed and renders the whole tree internally, then the render is called again to construct the HTML response. Don't think if there's any way to avoid that, but I guess is still quite performant thanks to the network round-trips avoided by SSR.

I guess the performance is maximum when the GraphQL server is hosted on the same machine as the Next.js server, so you could always try that if you'd be concerned with performance (at this point, I prototype my app with Graphcool for the backend, while the Next.js is deployed with Now/Zeit World).

@sedubois @estrattonbailey Correct me if I'm wrong, but we are still only rendering once. getDataFromTree does not render the tree, it simply returns a promise which resolves when the data is ready in our Apollo Client store. At the point that the promise resolves, our Apollo Client store will be completely initialized and we can optionally render the tree if we want to pass the stringified results in the response of an HTTP request but we're not doing that in my example.

getDataFromTree does not render the tree

@ads1018 AFAIK and looking at the Apollo code, it _does_ render the tree recursively (just to trigger the Apollo data-fetching). So that's 2 renders server-side on first page load.

But anyway, thanks to your demo, now we have a usable integration between Apollo and Next, and remaining questions about Apollo SSR performance don't have anything specific to Next.js anymore I think. I'd suggest to ask questions about that over there.

@sedubois what is a render anyhow? I'd call it walking and shaking the tree. Seems to be optimized pretty well – suppressed setState and no reconciliation into DOM.

@ads1018 nice example! Looks like it's been added to the Wiki here as well, so this issue could probably be closed?

cc @rauchg

We should get a blog post about Apollo + Next.js on the Apollo blog!

@stubailo @ads1018's example is great 👏 For something bigger using same Apollo principles, can check my app: https://github.com/relatenow/relate

Thanks @helfer. I'm thrilled with how it came out. I feel like I discovered the holy grail of app development with Next.js + Apollo. I've been meaning to follow up with a blog post in an effort to spread the gospel but just haven't gotten around to it. @stubailo I'd be happy to collaborate on a piece on the Apollo medium publication :)

Huge shout out to @sedubois for helping out with the example and his sweet app. 😄

@ads1018 would love to get you on the blog. When you're ready to chat about it, ping me (thea) on Apollo Slack. :)

@helfer You are totally right. I should do a new issue pass to see if issues can be closed 😄

@stubailo @theadactyl awesome idea ❤️

Anyone know of an issue/PR to watch - regarding requesting data twice server side? Just curious