Ngx-drag-scroll: Prepare for Angular 8

Created on 8 May 2019 · 14Comments · Source: bfwg/ngx-drag-scroll

I'm submitting a ...
- [ ] bug report
- [x] feature request
- [ ] support request => Please do not submit support request here, see note at the top of this template.
What is the current behavior?
Unknown
What is the expected behavior?
Package should be checked to work with Angular 8, when released (probably by the end of May, it's already in RC).
What is the motivation / use case for changing the behavior?
Ability tu use this package with newer versions

Source

IlCallo

👍3

All 14 comments

I'm going to upgrade the library to Angular 8 sometime this week.

bfwg on 27 May 2019

Resolved in #234

bfwg on 30 May 2019

Shouldn't you tag it as version 8.0.0, given that you switched to following Angular major version some time ago? 🤔
Or so I guessed, given that at a point you jumped from v2 to v7

IlCallo on 30 May 2019

Also, have your checked it works even when ivy compiler is turned on?

IlCallo on 30 May 2019

Not yet, my projects are currently on Anguar 7. Good point about the versioning. I'll do that in the next PR.

bfwg on 30 May 2019

❤1

Yeah, no hurry, mines too. I'm just reminding everyone to get ready, to be able to migrade flawlessly later on :P
You should probably re-open the issue until you test this with Ivy, considering that's the major new feature into Angular 8

IlCallo on 30 May 2019

👍1

We desperately need this too. Our Angular 8 upgrade effort is on hold until this (awesome) module supports it.

demisx on 11 Jun 2019

@demisx , do you think you can submit a PR for Angular 8 support? I'm pretty busy at the moment to do the dev work but I will be happy to do the review for you.

bfwg on 11 Jun 2019

@bfwg I wish I could. I am a techlead/PM and, unfortunately, do not posses Angular knowledge to be able to help here. 😢

demisx on 11 Jun 2019

Hey, I've tried upgrading the packages myself but unit tests fail and I don't have the library understanding to fix them. Could you please take a look at my PR and maybe give me a hint as to what to do:

https://github.com/bfwg/ngx-drag-scroll/pull/243