Node: deps: fix TODO in tools/icu/README.md

Created on 22 Jul 2016  ·  3Comments  ·  Source: nodejs/node
  • Subsystem: deps

Fix TODO in https://github.com/nodejs/node/blob/master/tools/icu/README.md

small-icu is the default now.

doc i18n-api
Source
picture srl295
👍1

All 3 comments

  • watch out for deps/icu-small/source/data/in/icudt*.dat :
  • that's where a 2MB binary file will be - make sure to git add it
  • don't forget to delete the old ICU's file
srl295 picture srl295 on 22 Jul 2016
👍1

/ping @srl295 There are two TODOs in the icu README. Are either of them addressable at this time?

Trott picture Trott on 9 Jul 2017
👍1

also:

it should mention pre-landing to simplify the diffs (with fix-whitespace - what I do is actually "pre-land" the patch using the Collaborator's guide onto a fresh master, then push that again otherwise the PR diff shows gratuitous whitespace diffs that aren't really part of the final land)
it should also cleanup the order of operations and mention running the license generator after 'make distclean ; configure ' so that the path to ICU is consistent

srl295 picture srl295 on 10 Nov 2017
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

willnwhite picture willnwhite  ·  3Comments
Icemic picture Icemic  ·  3Comments
ksushilmaurya picture ksushilmaurya  ·  3Comments
styfle picture styfle  ·  3Comments
dfahlander picture dfahlander  ·  3Comments