Octofarm: Problem with printer data (temp, time)

Created on 19 Apr 2021 · 7Comments · Source: OctoFarm/OctoFarm

To better help the developer understand your issue, please fill in the information below. Failing to do so will waste the developer and your own time in sorting the issue. Thanks!

Client or Server side error
Client error
Uncaught (in promise) TypeError: Cannot set property 'innerHTML' of null
at panelViewRunner.min.js:6504
at u (serverAliveCheck.min.js:6554)
at Generator._invoke (serverAliveCheck.min.js:6784)
at Generator.next (serverAliveCheck.min.js:6609)
at g (panelViewRunner.min.js:5864)
at o (panelViewRunner.min.js:5866)
(anonymous) @ panelViewRunner.min.js:6504
u @ serverAliveCheck.min.js:6554
(anonymous) @ serverAliveCheck.min.js:6784
(anonymous) @ serverAliveCheck.min.js:6609
g @ panelViewRunner.min.js:5864
o @ panelViewRunner.min.js:5866
Promise.then (async)
g @ panelViewRunner.min.js:5864
o @ panelViewRunner.min.js:5866
(anonymous) @ panelViewRunner.min.js:5866
(anonymous) @ panelViewRunner.min.js:5866
(anonymous) @ panelViewRunner.min.js:5954

Describe the bug
If you don't connect the 1st printer of the list you can't see data for the second printer in panel tab or in camera tab (camera is ok, but data like time and temp are not ok)

To Reproduce
Steps to reproduce the behavior:

Have at least 2 printer registered, shutdown the octopi of the first printer in the list
Lanch a print on the second printer
Go to 'Panel' tab
See data abour temp and time are not refreshed

Expected behavior
Data should be refresh as they are if the first printer is connected

Screenshots
Screenshots of my second printer (First printer offline)
https://media.discordapp.net/attachments/709293261646200842/831923458534932530/unknown.png

Screenshots of my second printer (First printer online)
https://media.discordapp.net/attachments/709293261646200842/831926710332817438/unknown.png

Code snippet :

https://media.discordapp.net/attachments/709293261646200842/833694529273593876/unknown.png

Versions (please complete the following information):

NodeJS Version [12.22.1]
OctoFarm Version [1.1.12]
OctoPrint Version [1.5.3]
OctoPrint Plugins [N/A]

Additional context
N/A.

bug investigating further

Source

3DRemake

Most helpful comment

Tested on development branch. Issue is fixed

3DRemake on 24 Apr 2021

🎉2

All 7 comments

Thanks to @3DRemake the place in code was found. It most probably resides here:

viewUpdater.js line 998 to 1015

tool element is not found

davidzwa on 19 Apr 2021

Thanks to @3DRemake the place in code was found. It most probably resides here:

viewUpdater.js line 998 to 1015

tool element is not found

Indeed, when the status is 'Offline' there is no tool element. Note it's not the printer that is not connected to Octopi, but the octopi that is offline.

3DRemake on 19 Apr 2021

That's a pointless if statement if I ever saw one 😁

NotExpectedYet on 19 Apr 2021

😄1

Still couldn't reproduce this but looking now.

Spool selected.

Index 0 printer offline
index 1 printer printing.

NotExpectedYet on 23 Apr 2021

PR #447

Once david has time to review that PR I'd like confirmation from you @3DRemake if at all possible.

I'm not sure if the issue lies deeper with something else as if you check the PR I tried a few different variations from my knowledge of the backend/frontend. I've put checks in and removed some of the pointless code and considering the printer is offline this should suffice to resolve the issue for now.

NotExpectedYet on 23 Apr 2021

Tested on development branch. Issue is fixed

3DRemake on 24 Apr 2021

🎉2