Openlibrary: Books without covers not showing title/author in carousels on 3+ page

Created on 9 Jan 2020  ·  4Comments  ·  Source: internetarchive/openlibrary

Books which don't have covers should show title/author even if on 3+ page of carousel.

Evidence / Screenshot (if possible)

image

Relevant url?

e.g. https://openlibrary.org/publishers/John_Bartholomew_&_Son

Steps to Reproduce

  1. Go to https://openlibrary.org/publishers/John_Bartholomew_&_Son
  2. Scroll forward 2 pages

  • Actual: Books display empty covers
  • Expected: Books to still show the gray "placeholder" cover if missing cover

Details

  • Logged in (Y/N)? Y
  • Browser type/version? FF71
  • Operating system? Win10
  • Environment (prod/dev/local)? prod

Proposal & Constraints

Related files

Stakeholders

UI @jdlrobson Investigation 3 Bug carousels

Most helpful comment

this appears to be fixed

Screen Shot 2021-01-07 at 10 15 45 AM

All 4 comments

@cdrini idk why, but it shows a blank cover instead of no cover at all. If that's removed, then the screen behind it (with the title and author) can show.

Still an issue.
The images in question are pointing to URIs such as
//covers.openlibrary.org/b/id/undefined-M.jpg

This is because a cover id is not defined in https://openlibrary.org/publishers/John_Bartholomew_&_Son.json?limit=12&offset=12

Not sure if this is the client side handling or the API itself.

this appears to be fixed

Screen Shot 2021-01-07 at 10 15 45 AM

that is amazing! Not having to deal with those blank covers is a big weight/load off here. Great work everyone.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

LeadSongDog picture LeadSongDog  ·  5Comments

jdlrobson picture jdlrobson  ·  5Comments

cdrini picture cdrini  ·  5Comments

BrittanyBunk picture BrittanyBunk  ·  5Comments

dcapillae picture dcapillae  ·  4Comments