Pim-community-dev: Error when deleting export profile

Created on 19 Mar 2017  ·  5Comments  ·  Source: akeneo/pim-community-dev

Hello 👋 ,

We're using Akeneo CE 1.7

Currently if you go to export profiles, select any and try to delete it (from edit profile page)you will get next error (browser console):

screen shot 2017-03-19 at 00 12 03

bug has-PR

Most helpful comment

Hello @juliensnz will make pull request this week.

All 5 comments

Hello @gotgelf,

Thanks a lot for this bug report, you spotted a good one :)
The problem is that the Job instance remover uses identifier key instead of code (https://github.com/akeneo/pim-community-dev/blob/1.7/src/Pim/Bundle/EnrichBundle/Resources/public/js/remover/job-instance-import-remover.js#L26 and https://github.com/akeneo/pim-community-dev/blob/1.7/src/Pim/Bundle/EnrichBundle/Resources/public/js/remover/job-instance-export-remover.js#L26).

Would you be interested to contribute and handle the fix yourself? If yes, you can create a pull request from your fork, change those two remover to use code instead of identifier as a key and add a small behat scenario to ensure that the issue will not come back in six months :)

Also, if you create a pull request, don't forget to sign our contribution agreement https://www.akeneo.com/contributor-license-agreement/

Hello @juliensnz will make pull request this week.

Hi @juliensnz, can you please give me reference for the ticket (PIM-xxxx), to create the patch?

Hello @gotgelf,

Awesome! You can name your branch like that: GITHUB-5949 :)

Hello @gotgelf !

Thanks for raising this issue, the PR fixing the bug has been merged today 🎉 !

Was this page helpful?
0 / 5 - 0 ratings