@publiclab/mentors what is the required submission for this task... I've to create a PR showing only the locations where OAuth can be implemented?

NO PR REQUIRED.
Just tell me some places where we need login modal to be displayed on clicking the login/sign up.
Example we should have login modal on the question page. You know that OAuth modal is worked upon in other prs. So this issue's implementation will be after that issues completion. I hope this makes sense.

Okay.. that seems good.. I'll then claim this one on gci in a while

• [x] write a research note
  link- https://publiclab.org/post
  plots2/app/views/sidebar/_related.html.erb #4151
• [x] follow a post
  link - https://publiclab.org/notes/joyofsoy/11-09-2018/fighting-the-flood-community-activism-and-education-in-pensacola
  app/views/users/_follow.html.erb #4152
• [x] like a research note
  link - https://publiclab.org/notes/joyofsoy/11-09-2018/fighting-the-flood-community-activism-and-education-in-pensacola
  app/views/like/_like.html.erb #4153
• [x] like a wiki page #4154

@SidharthBansal

• ask a question
• comment
• I have done activity column
• Get Involved tab => Post your work
• Like, follow, Flag as spam, Emoji on posts, comments and wikis
• Tag click => Follow => Login/Sign up

@mohitRJranjan @oorjitchowdhary please don't write same points. Also, supply the route for it.
Thanks
Please write how that page is linked also. Like do we have a button for it or for the direct route, etc. Explain well.

okay

@oorjitchowdhary please organise in the form of checkboxes. Append the above changes also.
Thanks

• [x] Get Involved Tab -> Post your work
  app/views/layouts/_header.html.erb

  4194

• [x] Like, follow, Flag as Spam on comments and wikis
  app/views/notes/_comment.html.erb
app/views/questions/_answers.html.erb
app/views/questions/_answer.html.erb
app/views/wiki/_header.html.erb

  4165

This works? @SidharthBansal

Like, follow, Flag as Spam, Emoji on comments and wikis
app/views/notes/_comment.html.erb
app/views/questions/_answers.html.erb
app/views/questions/_answer.html.erb
app/views/wiki/_header.html.erb

break this properly into different checkboxes and write sequence of flow for modal to get integrated like you write Get Involved Tab -> Post your work
Also append https://github.com/publiclab/plots2/issues/4132#issue-387916183 checkboxes with description.
Also write the urls. Thanks
Thanks

• [x] Comments page on notes
  publiclab.org/notes/
  app/views/notes/_comments.html.erb

#4156

• [x] Answers page on /questions
  publiclab.org/questions/
  app/views/questions/_answers.html.erb

#4157

• [x] Compose new answer on Answers on /questions
  publiclab.org/questions/
  app/views/questions/_answer.html.erb #4158

• [x] Questions page
  publiclab.org/questions/
  app/views/questions/show.html.erb

• [x] Subscribe/Follow Tags
  publiclab.org/tags/
  app/views/tag/index.html.erb

@mohitRJranjan @oorjitchowdhary have you guys claimed this task? I see it's still available on the dashboard.

@JonathanXu1 it is multiple instance count task. They have done the task. If you wish to do it you can claim and suggest me. Thanks

@oorjitchowdhary Can you please help me for creating issues for your comment https://github.com/publiclab/plots2/issues/4132#issuecomment-444972178

I have created some tasks so please see that your tasks will not repeat with my issues created.

Just to ping all GCI students that creating n first timer issues will count as n tasks.
There are many activities which are small on GCI dashboard. So, please take those tasks. I created those activities so that you can work on more number of issues and get approval soon. And we can judge you better.

Here's some more areas to add logins:

• [x] Ask a question in public lab store:
  
  https://store.publiclab.org/collections/featured-kits/products/papercraft-spectrometer-intro-kit?variant=6100877213724
• [x] Log in icon on pubic lab store:
  
• [x] Subscribe to emails in requests page:
  
  https://publiclab.org/wiki/requests
• [x] Join public lab link on research page:
  
  https://publiclab.org/research

@SidharthBansal is this sufficient?

@JonathanXu1 so for the store, I'm seeing this as the login:

Do you mean that we should add Oauth to it?

Great work!!!
It will be great if you can raise separate issues for these tasks and link them to this issue.

@dinaelhanan let @JonathanXu1 raise the issue and link it here. We will converse about https://github.com/publiclab/plots2/issues/4132#issuecomment-445475252 in that issue

@JonathanXu1 so for the store, I'm seeing this as the login:

Do you mean that we should add Oauth to it?

Wow.. that is just a great login page.. We could perhaps make it into a modal, add Oauths to it... And maybe also implement the same design on the publiclab.org login modal..

@oorjitchowdhary that's what I'm going to do :) #4120

Wow.. that is just a great login page.. We could perhaps make it into a modal, add Oauths to it...

@oorjitchowdhary ,@dinaelhanan no you need not to do the OAuth for providers on the store. Store is a different website. Its codebase is not available to us.
I think we need not to link the login/sign up modal to that store page.

Oh i see.. So perhaps we can implement only its design for our login modal?

So should I remove both #4190 and #4191?

@JonathanXu1 no I just edited the title, we just have to make it a modal

I guess yes..

Let's have this conversation in the issue created.
No need to close issues @JonathanXu1

Alright. Can I submit this task on GCI then?

Yes. Go ahead.

Great, thanks! I'll send it in after the redundant share your work task has been approved.

You have not claimed it yet. I am online let's do it now.

Approved

@SidharthBansal for this PR: #4149 I did all the requirements by @jywarren . I would like to get started on other tasks since the deadline is near, so can you please approve this task?
https://codein.withgoogle.com/dashboard/task-instances/4824240835526656/
Jeff has reviewed it and I met all criteria :)

@dinaelhanan @JonathanXu1 this issue is about identification of different pages to link the login modal, please don't make this conversation divergent. I hope you both will not mind if you will tag me in the respective issues.

@dinaelhanan I will try to do it.

@oorjitchowdhary https://github.com/publiclab/plots2/issues/4132#issuecomment-444972178 please do the task which you forget to do in this issue. Thanks everyone

Oh.. I'll make the issues

@SidharthBansal For the future, where can we best contact mentors like you about non-task specific questions?

For gci related issues on the gci platform, for the reward related queries in the issue itself.
If still the task is not related to any issue on github or gci then you can contact us on gitter chat or #3698.
I hope this helps

Oh.. I'll make the issues

@SidharthBansal #4194

Thanks, that's very helpful.

@oorjitchowdhary emojis are remaining. Can you create an issue for it also?

@oorjitchowdhary emojis are remaining. Can you create an issue for it also?

Yes.. I was just searching if an issue was made for it.. I'll make it

No issue is created for the emojis

@SidharthBansal I think the emojis aren't shown when you aren't logged in.. So we don't need an issue for linking... My bad there..

Thanks for the correction. I have already rewarded you for this task.
I missed to ask you to create issues for them

On Sun, Dec 9, 2018 at 12:07 AM Oorjit Chowdhary notifications@github.com
wrote:

@SidharthBansal https://github.com/SidharthBansal I think the emojis
aren't shown when you aren't logged in.. So we don't need an issue for
linking... My bad there..

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4132#issuecomment-445480356,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ2faokWQPsZE5QuLkela7Fw5_nkVks5u3AbUgaJpZM4ZEqRU
.

Sorry about that.

*[x] Joining a group

Please provide two more similar places where we want to link login modal

On Mon, Dec 10, 2018, 7:40 AM d1g1t4ld1n4 <[email protected] wrote:

[x] Joining a group:

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4132#issuecomment-445627632,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ6TF-zFZ3dIjk48FMBNQYO8ipOsTks5u3cKvgaJpZM4ZEqRU
.

@SidharthBansal I will try to tommorow :)

OK great take some rest

On Mon, Dec 10, 2018, 7:55 AM d1g1t4ld1n4 <[email protected] wrote:

@SidharthBansal https://github.com/SidharthBansal I will try to
tommorow :)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4132#issuecomment-445632709,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ6KxrWFKEDNBwDsoVnua_-JlR207ks5u3cYmgaJpZM4ZEqRU
.

• [x] https://github.com/publiclab/plots2/issues/4231 Help answer future questions on wiki page
• [x] https://github.com/publiclab/plots2/issues/4230 Ask a Question on wiki page
• [x] https://github.com/publiclab/plots2/issues/4229 Request an activity on wiki page
• [x] https://github.com/publiclab/plots2/issues/4241 Empty Notes Grids on wiki page

Thanks a lot

On Mon, Dec 10, 2018, 12:39 PM kevinzluo <[email protected] wrote:

>

• #4231 https://github.com/publiclab/plots2/issues/4231 Help answer
  future questions
• #4230 https://github.com/publiclab/plots2/issues/4230 Ask a
  Question
• #4229 https://github.com/publiclab/plots2/issues/4229 Request an
  activity
• #4241 https://github.com/publiclab/plots2/issues/4241 Empty Notes
  Grids

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4132#issuecomment-445709159,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ5mXbAa6s_ettSlIQOeliEdB6nz_ks5u3giegaJpZM4ZEqRU
.

@SidharthBansal looking back, I did find two! I found the store one, but Jonathan helped and opened the issue, so I identified two already :) I will add image of the joining a group but I don't know where to find it on the website

No problem. Please claim the task to get your rewards. I will give you rewards.

@SidharthBansal I have currently claimed the link login modal to follow post task, so I will wait till I finish that one, thanks!

ok

On Mon, Dec 10, 2018 at 7:30 PM d1g1t4ld1n4 notifications@github.com
wrote:

@SidharthBansal https://github.com/SidharthBansal I have currently
claimed the link login modal to follow post task, so I will wait till I
finish that one, thanks!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4132#issuecomment-445824605,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ2WEWZywjAzRkxY7StZmw5OtuFwwks5u3mj2gaJpZM4ZEqRU
.

@SidharthBansal I have abandoned another task so I can get this approved. Please check it out here:
https://codein.withgoogle.com/dashboard/task-instances/5943340534071296/

Approved

On Mon, Dec 10, 2018, 7:49 PM d1g1t4ld1n4 <[email protected] wrote:

@SidharthBansal https://github.com/SidharthBansal I have abandoned
another task so I can get this approved. Please check it out here:
https://codein.withgoogle.com/dashboard/task-instances/5943340534071296/

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4132#issuecomment-445831052,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ2r3SALkkPYq6Rf0iP208NZBl0Q_ks5u3m1_gaJpZM4ZEqRU
.

Wow, amazing work folks!

4303 is related to this.

Issues are being worked upon. This issue is broken down into subsissues.
So closing this.

Reopening it as still many issues are left to be explored and created. Some are listed below:

• [x] #4415
• [x]
  Link the flash message, add one row, ask a question about...., subscribe to... etc.
• [x]
  ask related question, subscribe to.... etc to login modal
  Ticked marked means these issues are broken down into individual issues*

• [x] I'm creating a fto for ask related question #4416

Please note that linking to login modal common function is made. So for
that you can create a fto
But linking to signup modal common Js function is not made as per as I
remember. So please don't form fto for that.
Please link fto to here for sure. Thanks a lot.

On Thu, Dec 27, 2018, 2:04 AM Oorjit Chowdhary <[email protected]
wrote:

I'm creating a fto for ask related question

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4132#issuecomment-450022142,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ-b3mXbF3grrICcRdnMJgnIZsCGMks5u891FgaJpZM4ZEqRU
.

Here, #4416 for adding login modal
Please add the labels

• [x] #4419 linking login modal to ask a related question
  

• [x] ask a question about tag on tags.. #4431

Hi everyone, can you please search the website and tell us if still more such linking issues are present. If they are present then please write comment in this thread and make a fto for it.
Thanks

@oorjitchowdhary can you please create ftos for the remaining stuff of https://github.com/publiclab/plots2/issues/4132#issuecomment-450020938. I believe that you know what is remaining so it will be quite easy for you. Hence pinging you. Don't forget to link them here.
Thanks.

Hi @SidharthBansal ..
The login modal has been linked to:-

• [x] ask related question
• [x] ask a related question
• [x] ask a question about 'tag' on tags
• [x] subscribe to answer questions on this topic on tags

I can find only one place where it hasn't been linked..

• [x] subscribe to answer questions on this topic flash message on questions.. I can make a fto for this one.. #4433

Can you please create fto for it?

On Fri, Dec 28, 2018, 5:59 PM Oorjit Chowdhary <[email protected]
wrote:

Hi @SidharthBansal https://github.com/SidharthBansal ..
The login modal has been linked to:-

• ask related question
• ask a related question
• ask a question about 'tag' on tags
• subscribe to answer questions on this topic on tags

I can find only one place where it hasn't been linked..

• subscribe to answer questions on this topic flash message on
  questions.. I can make a fto for this one..

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4132#issuecomment-450352029,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ3yiCgZJjYC-SIVa4Xcdmurtsn29ks5u9g6PgaJpZM4ZEqRU
.

Also check at the website if there are more places where we need to link
the modals. That would be a great help.
Thank you

On Fri, Dec 28, 2018, 6:11 PM Sidharth Bansal [email protected]
wrote:

Can you please create fto for it?

On Fri, Dec 28, 2018, 5:59 PM Oorjit Chowdhary <[email protected]
wrote:

Hi @SidharthBansal https://github.com/SidharthBansal ..
The login modal has been linked to:-

• ask related question
• ask a related question
• ask a question about 'tag' on tags
• subscribe to answer questions on this topic on tags

I can find only one place where it hasn't been linked..

• subscribe to answer questions on this topic flash message on
  questions.. I can make a fto for this one..

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4132#issuecomment-450352029,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ3yiCgZJjYC-SIVa4Xcdmurtsn29ks5u9g6PgaJpZM4ZEqRU
.

• [x] flash message
• [x] add one row
  

@oorjitchowdhary did you see any other similar issues?

Found just one.. Should I create an issue for this @SidharthBansal

• [ ] Log in button on /signup page

But we're implementing the signup modal too right.. so is this required? Will we keep the log in button in the modal?

@oorjitchowdhary
I believe @JonathanXu1 has linked the log in button on the signup modal to the log in modal.

Take a look at stable.publiclab.org

• [x] #4437
  login modal should be prompted while clicking on follow icon
  

@kevinzluo @oorjitchowdhary Jonathan has made the links to both the modals and they are woking correctly. But on hte /signup and /login they are not redirecting to each other pages. We need to have submit a fix after forming issue for it. @oorjitchowdhary can you kindly solve this? Kevin is taking some other work so I don't want to burden him much. Thanks both of you.

@sidharthbansal okay.. You mean to solve #4437 right?

No, sorry for the misunderstanding. #4437 is being solved by @geekychaser.
@oorjitchowdhary you can create an issue for https://github.com/publiclab/plots2/issues/4132#issuecomment-450510778 + https://github.com/publiclab/plots2/issues/4132#issuecomment-450550193 and submit a PR for this. Once you finish this up please ping me I will assign you more tasks. I found some tasks upon which you will love to contribute.
Thanks @oorjitchowdhary

@oorjitchowdhary you can definitely help people asking for help like in #4437 go ahead and help @geekychaser as he is stuck.
Thanks

@SidharthBansal @oorjitchowdhary i think this can be solved now , i should post a PR after this get merged https://github.com/publiclab/plots2/pull/4453

@oorjitchowdhary some work is done in #4457. Please refer it before submitting a pr for https://github.com/publiclab/plots2/issues/4132#issuecomment-450551508.
Thanks for the amazing work you are doing at public lab.

@sidharthbansal I saw the stable PL status..
The log in on /signup doesn't work and sign up on /login doesn't work.. So should I link the respective modals to the buttons or the respective pages?

You are right @oorjitchowdhary! #4457 also depends on this. Do we want the links at /signup and /login to open the modals or redirect to the pages? I am in favor of the modals.

Having the signup modal over login page looks ambiguous to me. I think we
should redirect to the pages if present in the pages.

On Mon, Dec 31, 2018, 6:21 AM kevinzluo <[email protected] wrote:

You are right @oorjitchowdhary https://github.com/oorjitchowdhary! #4457
https://github.com/publiclab/plots2/issues/4457 also depends on this.
Do we want the links at /signup and /login to open the modals or redirect
to the pages? I am in favor of the modals.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4132#issuecomment-450597872,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ9MTYVp2WvMGskBsWzClTbgg4hPNks5u-V-TgaJpZM4ZEqRU
.

I'm a little confused about our modals..
If we have made modals, we should link to everywhere. And then why do we need the /login and /signup pages?

We could eliminate the /login and /signup pages, and just keep the modals..

Hi, @oorjitchowdhary actually Public Lab is a website which we are maintaining since 10 yrs. So there are many places which contain link to login and signup as /signup or /login. In case we will remove these pages those links will stop working. Functionality is more important than redundancy. I liked your suggestion but we cannot implement it.
Thanks for the suggestion.

• [x] Link login modal to 'Write a research note' at '/wiki/comment-templates'
  

  4481

@oorjitchowdhary we are creating the modals so that the person will not get derailed from the public labs while signup. I hope this solves your query.

This is a spectacular effort, folks! Very impressive to see. Do you think it's worth adding to the README or docs somewhere that this new class can be added to any link to require login first?

Thanks!!! 👍 🎉

Also it's useful to have distinct /login and /signup pages so that we can send people the link to those if necessary. Modals don't have a URL, although of course we could send them the URL of a page that they can't access, but that's a little more complex to remember.

I.e. "Oh, welcome! Try making an account at https://publiclab.org/signup"!

Right now we are linking each Try making an account to signup modal and try logging in to login modal.
Thank you Jeff

• [x] fix login link at /signup #4507

I hope we have created issues for all the buttons/links where ever we require the login modal. In case we will require any more button to be linked we can simply open up a first timer only labelled issue @jywarren so wrapping up here and closing this IMMENSE issue. Thanks to all the folks who helped PL for the login/sign up front end migration for better UI.

this is the most epic issue! :-) thank you all SO MUCH

On Mon, Jan 7, 2019 at 9:24 AM Sidharth Bansal notifications@github.com
wrote:

Closed #4132 https://github.com/publiclab/plots2/issues/4132.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/4132#event-2057701550, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AABfJ_1zXv-qB78WkP88Xss0J0w-wAZgks5vA1htgaJpZM4ZEqRU
.