Plots2: Follow up bugs in new designs of All sections including Profile,Tags, People etc

Hi @jywarren @gautamig54 I had a doubt regarding this -
In the one main card of Individual Tag page , we have a subscribe button but when I click on the button, it shows related tag, but not let us subscribe to that particular tag. We are only able to subscribe to related tags and not the main tag whose Individual page we are on.

Instead we have another button below called Subscribe to answer questions on this topic. And this button is the one which lets us subscribe to tag.

This should be fixed right ? Or Is it going to be like this only.

No I think you're right, it should be fixed!

On Sat, Aug 3, 2019, 10:28 AM Lekhika Dugtal notifications@github.com
wrote:

Hi @jywarren https://github.com/jywarren @gautamig54
https://github.com/gautamig54 I had a doubt regarding this -
In the one main card of Individual Tag page , we have a subscribe button
but when I click on the button, it shows related tag, but not let us
subscribe to that particular tag. We are only able to subscribe to related
tags and not the main tag whose Individual page we are on.

Instead we have another button below called Subscribe to answer questions
on this topic. And this button is the one which lets us subscribe to tag.

[image: Screenshot from 2019-08-03 12-53-11]
https://user-images.githubusercontent.com/26685258/62408943-b7616200-b5ed-11e9-8d0e-7e9bac75a16a.png

This should be fixed right ? Or Is it going to be like this only.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6097?email_source=notifications&email_token=AAAF6J6J326MZGNIUFI526LQCUXOLA5CNFSM4II6ZY4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3PJB6A#issuecomment-517902584,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAF6JYTKNDSUDMJSW6ZZGLQCUXOLANCNFSM4II6ZY4A
.

Cool!! I'll fix it.

On the individual tags page, for a few tags, the content on the side bar shifts to the bottom. Whereas the page seems to be divided properly.

I think this happens when there are tab content. With no tab contents, it displays it on the right side only.
Can you also generate this issue @CleverFool77?

Can you write down specific points of generating this Issue, I tried it in
3-4 tags but I'm unable to generate this.

On Sun, Aug 4, 2019 at 10:35 PM Gautami Gupta notifications@github.com
wrote:

I think this happens when there are tab content. With no tab contents, it
displays it on the right side only.
Can you also generate this issue @CleverFool77
https://github.com/CleverFool77?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6097?email_source=notifications&email_token=AGLS6SWZWXWOQ5BQG6GUBRLQC4D33A5CNFSM4II6ZY4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3QFVLI#issuecomment-518019757,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGLS6SWFQ5U6IONQQNUIVWDQC4D33ANCNFSM4II6ZY4A
.

Hi @gautamig54 I was able to reproduce this Issue. I'll try fixing it. Cool.
Thanks !!

Hi @CleverFool77. I think the problem is with the questions tab. It is working fine for wikis and posts

Hi @gautamig54 I checked it, Its pretty similar to matter when we have the side-wrap issue in tag page without login. I saw that the col-3 sidebar is going out the row class and thus its wrapping up in tab-content. Instead both of them should be inside the div of row class. So I'm checking and trying to work it out.
Thanks !!

Hi @CleverFool77! Should we make a separate issue for correcting the responsiveness of pages?

No need to piling up issues I guess. Juts adding in this checklist would be
ok according to me.
Thanks !!

On Thu, Aug 8, 2019 at 12:28 PM Gautami Gupta notifications@github.com
wrote:

Hi @CleverFool77 https://github.com/CleverFool77! Should we make a
separate issue for correcting the responsiveness of pages?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6097?email_source=notifications&email_token=AGLS6SUGKC5LC4GCV5O2WZDQDO72JA5CNFSM4II6ZY4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD32VB3Y#issuecomment-519393519,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGLS6SUZJY3374Y7V3PEQTTQDO72JANCNFSM4II6ZY4A
.

If you wanna add a new feature then opening an issue would do, In bug we can just checklist here for now ?

Sure @CleverFool77 !

Hi @gautamig54 @jywarren
Found this -
I clicked on question and found this -

Maybe this is related to Individual tags page ?

I saw the unstable and I don't see any map here. What could be the reason ?
As much as I know, even if the location is not added, a map should be still there. ??

@ebarry @steviepubliclab how do you feel about the functionality of the Subscribe button opening a dropdown with not only the tag itself but other related tags, in a "multi-subscribe" function, as in the screenshot above (https://github.com/publiclab/plots2/issues/6097#issuecomment-517902584)? (on tag pages)

This made sense in other places, but now that the tag page is kind of the lead page for a topic-based forum, maybe it should just subscribe you to the tag itself, and if you're subscribed, show unsubscribe? Or do we like this multi-subscribe?

The simpler subscribe/unsubscribe is shown on the /tags page, for comparison:

Versus on the tag page now:

Hi! One more I noticed - -perhaps the "X more posts" links in the profile page tag cards should go not just to the tag page, but to the page showing tagged content by that author:

https://publiclab.org/profile/warren

so, to https://publiclab.org/tag/community-atlas/author/warren for example. What do you think?

Hi @jywarren
I found another thing !!

I saw what you wrote about link ! and opened a PR on this !!
But I have one doubt !!
When I clicked on the link, its showed 3 more posts but when I clicked on it, the directed link to list of posts doesn't show those three posts ..

Here is full page of new directed page !!

The post count for that tag is for profile user only and couldn't be wrong. So I was wondering where the bug and problem could be ?

Oh hmm, how odd. What you can try is to do this locally and watch your
rails console output to see if the queries differ. Or you could trace
through the code to see how each is calculated?

On Fri, Aug 16, 2019 at 2:17 AM Lekhika Dugtal notifications@github.com
wrote:

Hi @jywarren https://github.com/jywarren
I found another thing !!

I saw what you wrote about link ! and opened a PR on this !!
But I have one doubt !!
When I clicked on the link, its showed 3 more posts but when I clicked on
it, the directed link to list of posts doesn't show those three posts ..

[image: li]
https://user-images.githubusercontent.com/26685258/63147315-525d3180-c01b-11e9-9bad-186aa11ec10d.gif

Here is full page of new directed page !!

[image: Screenshot from 2019-08-16 11-45-34]
https://user-images.githubusercontent.com/26685258/63147333-64d76b00-c01b-11e9-8790-d0ca344e894f.png

The post count for that tag is for profile user only and couldn't be
wrong. So I was wondering where the bug and problem would be ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6097?email_source=notifications&email_token=AAAF6J7J6MYMKBTQWISB55TQEZA4FA5CNFSM4II6ZY4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4NYUOQ#issuecomment-521898554,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAF6J4ZOLHACQ2EXFSOMMDQEZA4FANCNFSM4II6ZY4A
.

I'll try this.
Cool.

There is another bug here !!
I have used the tags bu there isn't any note being shown in these topic cards !!

Hi @jywarren !!
We had discussed this earlier but Is it still ok to have this much repetition of the notes ?
Like as we can see in screenshot that one of the notes is being repeated a lot. And As I haven't used much tags, so repetition wasn't much compared to a condition when we will have lots of tags in one note.

Ah, so this might need the same kind of "tagCard(tagname, excludeNids)"
template helper as where we've discussed elsewhere, that includes some kind
of parameter of [1,2,3] nids to exclude from displaying, that would have
been displayed higher up?

On Sat, Aug 17, 2019 at 8:52 AM Lekhika Dugtal notifications@github.com
wrote:

Hi @jywarren https://github.com/jywarren !!
We had discussed this earlier but Is it still ok to have this much
repetition of the notes ?
Like as we can see in screenshot that one of the notes is being repeated a
lot. And As I haven't used much tags, so repetition wasn't much compared to
a condition when we will have lots of tags in one note.

[image: Screenshot from 2019-08-17 18-18-43]
https://user-images.githubusercontent.com/26685258/63211923-95063300-c11b-11e9-8eeb-b36de1b60ec5.png

[image: Screenshot from 2019-08-17 18-19-02]
https://user-images.githubusercontent.com/26685258/63211924-95063300-c11b-11e9-8fc8-637053b31d1a.png

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6097?email_source=notifications&email_token=AAAF6J4T23EVVF4PV4LO7PLQE7X5HA5CNFSM4II6ZY4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4QKQ3I#issuecomment-522233965,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAF6J5EBNQNHAQ2NWDJAPDQE7X5HANCNFSM4II6ZY4A
.

Back to the multi-subscribe dropdown currently offered on a specific tag page, i agree with your idea that perhaps it should just be subscribe/unsubscribe as shown on the top-level /tags page.

I was also interested in changing the 2-page icon to a ... -- i'm sorry if i missed the discussion on that one!

That's a pretty simple one if folks are OK with it?

sure!

+1 336-269-1539 / @lizbarry http://twitter.com/lizbarry / lizbarry.net

On Mon, Aug 19, 2019 at 6:25 PM Jeffrey Warren notifications@github.com
wrote:

I was also interested in changing the 2-page icon to a ... -- i'm sorry
if i missed the discussion on that one!

[image: image]
https://user-images.githubusercontent.com/24359/63303744-b64b5880-c2ae-11e9-8ef5-9482f6f2a35d.png

That's a pretty simple one if folks are OK with it?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6097?email_source=notifications&email_token=AABHNH2OKQ5SAELERMUPEODQFMMWJA5CNFSM4II6ZY4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4UPGIY#issuecomment-522777379,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABHNH3MDSDK6G3YRJS26XTQFMMWJANCNFSM4II6ZY4A
.

Sure @jywarren @ebarry I'll fix these bugs !!
Thanks !!

Hi @jywarren Regarding the 2 page icon to .... What's the position of ... icon ? Is it a same position of 2-page icon? is it besides the title of notes as per the draft design ?

But the modal shown after clicking on ... icon on draft is not print page modal rather its different and consist of data from notes like views and etc.
So does that mean we'll have two ... in same page ? which are -

• One in sidebar with modal of print page
• Another in note with details of notes hidden behind this button and opened on modal only when clicked.

Hm, that's a good point. Shall we try to combine the two into a single ...
menu in the sidebar, alongside the other circle buttons?

On Tue, Aug 27, 2019 at 10:26 AM Lekhika Dugtal notifications@github.com
wrote:

Hi @jywarren https://github.com/jywarren Regarding the 2 page icon to
.... What's the position of ... icon ? Is it a same position of 2-page
icon? is it besides the title of notes as per the draft design ?

[image: 63303744-b64b5880-c2ae-11e9-8ef5-9482f6f2a35d]
https://user-images.githubusercontent.com/26685258/63779149-b1685380-c903-11e9-8faf-1a8b2042b722.png

[image: Screenshot from 2019-08-27 19-52-54]
https://user-images.githubusercontent.com/26685258/63779523-4ec38780-c904-11e9-9361-423f30d9ebf3.png

But the modal shown after clicking on ... icon on draft is not print page
modal rather its different and consist of data from notes like views and
etc.
So does that mean we'll have two ... in same page ? which are -

• One in sidebar with modal of print page
• Another in note with details of notes hidden behind this button and
  opened on modal only when clicked.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6097?email_source=notifications&email_token=AAAF6J6ZCHA6AEJYWSU5PG3QGU2OFA5CNFSM4II6ZY4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5H5L6I#issuecomment-525325817,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAF6J5TAO5BCXYWUKTQKHLQGU2OFANCNFSM4II6ZY4A
.

Hi @jywarren
We can combine it but I'm not sure how it would look all-together. As both of them have different information.

• one of them shows print option
• And another shows the views, comments etc.

I'm not sure how we gonna Combine these two - ??

Instead; having two icon buttons , one of them at side of notes-title and another on sidebar looks much better.

cc: @gautamig54 What's your views regarding this.

Or should we change the icons ? Let one them have ... and have a different one for second one ?? Maybe we can have a print icon https://fontawesome.com/v4.7.0/icon/print instead of 2-page icon ? And for the info regarding the notes like views,comments. We have ... https://fontawesome.com/icons/ellipsis-h?style=solid icon.

How about:

• we compact the barnstar item to 1 line if possible
• we remove the header section of "More tools" etc
• we have a horizontal divider so the views, revisions, talk, can all go at
  the top
• some, like comments, permalink, and views, could be made into simply
  icons, like comment-bubble, "chain link" icon, and "eye" icons, on a single
  line, to save space? Also Delete could be a trash can.

Could that help?

On Tue, Aug 27, 2019 at 10:49 AM Lekhika Dugtal notifications@github.com
wrote:

cc: @gautamig54 https://github.com/gautamig54 What's your views
regarding this.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6097?email_source=notifications&email_token=AAAF6J4RG7QKCHC5ZWFHTNDQGU5ELA5CNFSM4II6ZY4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5H76CY#issuecomment-525336331,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAF6J2FOFM2YKIKZ7GZXATQGU5ELANCNFSM4II6ZY4A
.

Ohkk !! This seems fine. And So to put barn-stars in one line; We can have a button and we can have dropdown along with it for various kinds of barnstars.
We all just this much portion in button and dropdown -

And rest would would be -
information like views, comments etc...

And other extra stuff would be removed.

What about the position of button ? Its looks fine and cool below notes title .. is it ?

I'll take this issue up and resolve this,
Thanks !!

I guess I imagine it may be more naturally placed next to the other circle
buttons.

Just watch out that we should try to have this reflected on the
notes/questions pages, but the wiki page too!

On Tue, Aug 27, 2019 at 11:00 AM Lekhika Dugtal notifications@github.com
wrote:

I'll take this issue up and resolve this,
Thanks !!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6097?email_source=notifications&email_token=AAAF6J4MIDPLC3N3MRAIXWDQGU6NFA5CNFSM4II6ZY4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5IBEUI#issuecomment-525341265,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAF6J7UVHNLR54I2NTXJWTQGU6NFANCNFSM4II6ZY4A
.

Sure. I'll see it all pages including notes,wikis, questions etc.
Thanks !!

On Tue, Aug 27, 2019 at 9:42 PM Jeffrey Warren notifications@github.com
wrote:

I guess I imagine it may be more naturally placed next to the other circle
buttons.

Just watch out that we should try to have this reflected on the
notes/questions pages, but the wiki page too!

On Tue, Aug 27, 2019 at 11:00 AM Lekhika Dugtal notifications@github.com
wrote:

I'll take this issue up and resolve this,
Thanks !!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/publiclab/plots2/issues/6097?email_source=notifications&email_token=AAAF6J4MIDPLC3N3MRAIXWDQGU6NFA5CNFSM4II6ZY4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5IBEUI#issuecomment-525341265
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAAF6J7UVHNLR54I2NTXJWTQGU6NFANCNFSM4II6ZY4A

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6097?email_source=notifications&email_token=AGLS6SWBU5GSI6BBQ5F7ZN3QGVG5JA5CNFSM4II6ZY4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5II73A#issuecomment-525373420,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGLS6SSEUIWS7JFBIIEMXDDQGVG5JANCNFSM4II6ZY4A
.

The maps on profile pages are GREAT! Could we have them zoomed in more, though?

I think there is code for determining zoom level from the precision of the lat/lon tags already. It follows the basic concept here: https://www.npmjs.com/package/leaflet-blurred-location#human-readable-blurring

But we've already coded this up... let me look for the reference!

Got it! https://github.com/publiclab/plots2/blob/d4d69ab4144d1457749ff215c53b63e167cc7142/app/views/map/_leaflet.html.erb#L38

Hi, I think I found an issue related to the new UI changes. On the Profile page, a new tag is not longer added to the list of user tags but it shows at page reload.

I looked into it a bit to fix it but now I am not sure how. It seems that the JS code relies on the "tags" id and the same id was also used to the most common tags section.

Ohh !!! So Renaming tags id would do ?? I'll check into this.

On Wed, Aug 28, 2019 at 6:22 PM Simona Stefan notifications@github.com
wrote:

Hi, I think I found an issue related to the new UI changes. On the Profile
page, a new tag is not longer added to the list of user tags but it shows
at page reload.

I looked into it a bit to fix it but now I am not sure how. It seems that
the JS code relies on the "tags" id and the same id was also used to the
most common tags section.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6097?email_source=notifications&email_token=AGLS6SWBJ5I64VQ6DWT6L4LQGZYHNA5CNFSM4II6ZY4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5LAKAQ#issuecomment-525731074,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGLS6SWMMHZ254SB3FDHMILQGZYHNANCNFSM4II6ZY4A
.

Hi, I would like to take up renaming of the tags id.

Hi @Anupam-dagar Sure. And one more thing. There would be uses of tags id in js too, you need to keep that in mind too.
Thanks !!!

Hi @CleverFool77 !
Very much enjoying all the new UI features 🤗

I'm wondering if it is the goal to eventually have the list of contributions by type that's shown on profile pages be linked to the actual content? For instance, shown in this screenshot, the grey text is not clickable, meaning that to the best of my current understanding, there's no way to see what someone has contributed from their profile page which, i feel, should be possible:

Also i'm wondering if it's intentional that the word "asked" appears after the username?
Thank you!

Hi @ebarry i intentionally added asked as per the style guide. Regarding
clickable thing. It's not visible, like hover or other feature. But While
changing the Ui, I didn't remove the link in them. So we do reach on
different pages after clicking on it. Notes, questions, activity posted and
attempted are working.
Wikis don't work because we usually don't have another page for list of
Wikis which have been edited i guess.

Also, we did had a list of Wikis to be shown in profile page earlier in
right bottom corner of Page. But we don't have this anymore
So should we add this? Or maybe do some Refinements to ui.

I'll look into comments matter.

Right now, I'm working on adding all Info of note and print feature into
one dropdown PR. I'll most probably complete the final Patch soon in a day
. And after that I'll look into it.

On Thu, 29 Aug 2019, 23:01 Liz Barry, notifications@github.com wrote:

Hi @CleverFool77 https://github.com/CleverFool77 !
Very much enjoying all the new UI features 🤗

I'm wondering if it is the goal to eventually have the list of
contributions by type that's shown on profile pages be linked to the
actual content? For instance, shown in this screenshot, the grey text is
not clickable, meaning that to the best of my current understanding,
there's no way to see what someone has contributed from their profile page
which, i feel, should be possible:

[image: Screen Shot 2019-08-28 at 4 04 41 PM]
https://user-images.githubusercontent.com/161439/63962501-fce44400-ca60-11e9-8f52-17bc32fca563.png

Also i'm wondering if it's intentional that the word "asked" appears after
the username?
Thank you!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6097?email_source=notifications&email_token=AGLS6SXZBG6HXBHHWS44SW3QHABVVA5CNFSM4II6ZY4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5PHSSQ#issuecomment-526285130,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGLS6SUR5GNMG2CMSLFWKOTQHABVVANCNFSM4II6ZY4A
.

Hi @CleverFool77! I notice some bug here on the tags page.
Also, here teh subscribe and the learn more button doesn't work.

I see its working fine for other tags like air-quality :

Hi @gautamig54 The bug is not in subscribe button rather its the distortion because of huge content for that particular tag. If you would have noticed than you must have seen that we are able to subscribe other tags.

And I've recently updated the subscribed button work. As earlier, we are just able to subscribe to related-tags but not that actual tag. So It will be updated soon when it get pushed to production.

To fix this bug, we can limit the content of a particular tag to be shown in the main card of that individual tag page.

That content is limited to 2 lines as you can see in air-quality tag.

On Fri, Aug 30, 2019, 12:35 Lekhika Dugtal notifications@github.com wrote:

Hi @gautamig54 https://github.com/gautamig54 The bug is not in subscribe
button rather its the distortion because of huge content for that
particular tag. If you would have noticed than you must have seen that we
are able to subscribe other tags.

And I've recently updated the subscribed button work. As earlier, we are
just able to subscribe to related-tags but not that actual tag. So It
will be updated soon when it get pushed to production.

To fix this bug, we can limit the content of a particular tag to be shown
in the main card of that individual tag page.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6097?email_source=notifications&email_token=AINQWIOHGFLNWVQP57QIIYTQHDBCFA5CNFSM4II6ZY4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5QYO7I#issuecomment-526485373,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AINQWIOK2JZI62WCFNXYJ7LQHDBCFANCNFSM4II6ZY4A
.

ohk Cool. So bug is somewhere else. But not in button I guess. Is there any other pages which you have seen with same bug ? of not able to subscribe ?

Hm, is it limited by # of newlines, or # of characters? Could this just be
a really really long paragraph?

On Fri, Aug 30, 2019 at 3:12 AM Lekhika Dugtal notifications@github.com
wrote:

ohk Cool. So bug is somewhere else. But not in button I guess. Is there
any other pages which you have seen with same bug ? of not able to
subscribe ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6097?email_source=notifications&email_token=AAAF6J63NPN7VC2CEIEPVFLQHDB45A5CNFSM4II6ZY4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5QY6CY#issuecomment-526487307,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAF6JZKBAMDVPTBTSPNF7TQHDB45ANCNFSM4II6ZY4A
.

Hi @gautamig54 As jeff asked, did you add limit by newline ?

On Fri, Aug 30, 2019 at 10:26 PM Jeffrey Warren notifications@github.com
wrote:

Hm, is it limited by # of newlines, or # of characters? Could this just be
a really really long paragraph?

On Fri, Aug 30, 2019 at 3:12 AM Lekhika Dugtal notifications@github.com
wrote:

ohk Cool. So bug is somewhere else. But not in button I guess. Is there
any other pages which you have seen with same bug ? of not able to
subscribe ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/publiclab/plots2/issues/6097?email_source=notifications&email_token=AAAF6J63NPN7VC2CEIEPVFLQHDB45A5CNFSM4II6ZY4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5QY6CY#issuecomment-526487307
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAAF6JZKBAMDVPTBTSPNF7TQHDB45ANCNFSM4II6ZY4A

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6097?email_source=notifications&email_token=AGLS6SRVSEFAQFWDB7KGXCDQHFGLBA5CNFSM4II6ZY4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5SGOPQ#issuecomment-526673726,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGLS6SQWUF7HPBLSUQVASO3QHFGLBANCNFSM4II6ZY4A
.

Yes. I have limited the content by the number of lines.

This is really amazing piece of work folks. Super thanks

Oops, re-opening! Also, we found this one, could be related to #6027 perhaps...

The URL is https://publiclab.org/tag/activity:*/author/mimiss

Thanks!!!

I noticed the edit button in the new sidebar is not visible in mobile-width devices. Could there be a relatively quick fix for this?

HI @gautamig54 @jywarren
Upcoming week would be my exams , So I won't be able to contribute much. I would be regular from next week onward.

Thanks !!

I noticed the edit button in the new sidebar is not visible in mobile-width devices. Could there be a relatively quick fix for this?

I'll Fix it.
Thanks !!

Great Lekhika!

On Fri, Sep 13, 2019 at 8:10 AM Lekhika Dugtal notifications@github.com
wrote:

I noticed the edit button in the new sidebar is not visible in
mobile-width devices. Could there be a relatively quick fix for this?

I'll Fix it.
Thanks !!

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6097?email_source=notifications&email_token=AFAAEQ5V4C7RFXGR3VKVXK3QJL4SHA5CNFSM4II6ZY4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6TZRUA#issuecomment-531077328,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFAAEQ2I4R4ZEGIDDEJAJDTQJL4SHANCNFSM4II6ZY4A
.

I think i've got the edit button fix in my big new PR here: #6322 -- lots of fixes there!

Thanks for the fix @jywarren .
My exams has ended finally. I'll look for other fixes in the design.
Thanks !!

awesome. I'm working on a lot of smaller items in #6326! I'd love help with
the weird ones with the wildcard tags, where the tag card is going a bit
out of control. And the one where there's a big space below the tag card on
/tag/____ on mobile devices!

On Tue, Sep 24, 2019 at 6:40 AM Lekhika Dugtal notifications@github.com
wrote:

Thanks for the fix @jywarren https://github.com/jywarren .
My exams has ended finally. I'll look for other fixes in the design.
Thanks !!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6097?email_source=notifications&email_token=AAAF6J3F76SW6N77EY24WRTQLHU6RA5CNFSM4II6ZY4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7N5FJY#issuecomment-534500007,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAF6J5BXSOXU7BOKLKOT7LQLHU6RANCNFSM4II6ZY4A
.

Aha - ok, now the tag page header cards are really in bad shape, and I think I found the issue. These lines set percentage-based positioning, and the use of row/col is a little odd within the card:

https://github.com/publiclab/plots2/blob/02b44b9daafc1ec0e8bc4f4dbb1f575ed7587336/app/views/tag/show.html.erb#L73-L126

If you are able to do some reworking of this, please do, and we'll try to rush it into production late tonight or early tomorrow.

I think we should set top: 70px and redo the row/col code there. That should address a lot of the other issues with that card as well!

That is, the wiki-sub and tag-buttons should be in their own <div class="row">, i think!

Quick attempt here: https://github.com/publiclab/plots2/pull/6328

Continued work here: https://github.com/publiclab/plots2/pull/6330

I am still not getting the background to show up on mobile screens:

But everything else is relatively better organized and with fewer custom styles. There are still some custom .card styles however, in /app/views/notes/_notes.html.erb -- I'd prefer to go with strict Bootstrap styles as much as possible, as it helps avoid the kinds of unexpected layout issues we're seeing here! https://getbootstrap.com/docs/4.3/components/card/

Oof, made it even worse in some scenarios. It's very strange that there are differences between stable, local, and production!

OK, did some more work on this, and the latest changes are publishing to the live site now!

Lots of pages look much better now!!!

I believe this is complete now. Any last follow-ups?

I guess this is ready.
Thanks @jywarren !!!